16 Oct, 2006

1 commit

  • Use inc/dec_preempt_count() rather than preempt_enable/disable() and manually
    add in the compiler barriers that were provided by the latter. This makes FRV
    consistent with other archs.

    Furthermore, the compiler barrier effects are now there unconditionally - at
    least as far as preemption is concerned - because we don't want the compiler
    moving memory accesses out of the section of code in which the mapping is in
    force - in effect the kmap_atomic() must imply a LOCK-class barrier and the
    kunmap_atomic() must imply an UNLOCK-class barrier to the compiler.

    Signed-off-by: David Howells
    Acked-by: Peter Zijlstra
    Signed-off-by: Linus Torvalds

    David Howells
     

12 Oct, 2006

1 commit

  • There's nothing arch-specific about check_signature(), so move it to
    . Use a cross between the Alpha and i386 implementations as
    the generic one.

    Signed-off-by: Matthew Wilcox
    Acked-by: Alan Cox
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Matthew Wilcox
     

05 Oct, 2006

1 commit

  • Maintain a per-CPU global "struct pt_regs *" variable which can be used instead
    of passing regs around manually through all ~1800 interrupt handlers in the
    Linux kernel.

    The regs pointer is used in few places, but it potentially costs both stack
    space and code to pass it around. On the FRV arch, removing the regs parameter
    from all the genirq function results in a 20% speed up of the IRQ exit path
    (ie: from leaving timer_interrupt() to leaving do_IRQ()).

    Where appropriate, an arch may override the generic storage facility and do
    something different with the variable. On FRV, for instance, the address is
    maintained in GR28 at all times inside the kernel as part of general exception
    handling.

    Having looked over the code, it appears that the parameter may be handed down
    through up to twenty or so layers of functions. Consider a USB character
    device attached to a USB hub, attached to a USB controller that posts its
    interrupts through a cascaded auxiliary interrupt controller. A character
    device driver may want to pass regs to the sysrq handler through the input
    layer which adds another few layers of parameter passing.

    I've build this code with allyesconfig for x86_64 and i386. I've runtested the
    main part of the code on FRV and i386, though I can't test most of the drivers.
    I've also done partial conversion for powerpc and MIPS - these at least compile
    with minimal configurations.

    This will affect all archs. Mostly the changes should be relatively easy.
    Take do_IRQ(), store the regs pointer at the beginning, saving the old one:

    struct pt_regs *old_regs = set_irq_regs(regs);

    And put the old one back at the end:

    set_irq_regs(old_regs);

    Don't pass regs through to generic_handle_irq() or __do_IRQ().

    In timer_interrupt(), this sort of change will be necessary:

    - update_process_times(user_mode(regs));
    - profile_tick(CPU_PROFILING, regs);
    + update_process_times(user_mode(get_irq_regs()));
    + profile_tick(CPU_PROFILING);

    I'd like to move update_process_times()'s use of get_irq_regs() into itself,
    except that i386, alone of the archs, uses something other than user_mode().

    Some notes on the interrupt handling in the drivers:

    (*) input_dev() is now gone entirely. The regs pointer is no longer stored in
    the input_dev struct.

    (*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking. It does
    something different depending on whether it's been supplied with a regs
    pointer or not.

    (*) Various IRQ handler function pointers have been moved to type
    irq_handler_t.

    Signed-Off-By: David Howells
    (cherry picked from 1b16e7ac850969f38b375e511e3fa2f474a33867 commit)

    David Howells
     

04 Oct, 2006

1 commit


02 Oct, 2006

1 commit

  • The last in-kernel user of errno is gone, so we should remove the definition
    and everything referring to it. This also removes the now-unused lib/execve.c
    file that was introduced earlier.

    Also remove every trace of __KERNEL_SYSCALLS__ that still remained in the
    kernel.

    Signed-off-by: Arnd Bergmann
    Cc: Andi Kleen
    Cc: Paul Mackerras
    Cc: Benjamin Herrenschmidt
    Cc: Richard Henderson
    Cc: Ivan Kokshaysky
    Cc: Russell King
    Cc: Ian Molton
    Cc: Mikael Starvik
    Cc: David Howells
    Cc: Yoshinori Sato
    Cc: Hirokazu Takata
    Cc: Ralf Baechle
    Cc: Kyle McMartin
    Cc: Heiko Carstens
    Cc: Martin Schwidefsky
    Cc: Paul Mundt
    Cc: Kazumoto Kojima
    Cc: Richard Curnow
    Cc: William Lee Irwin III
    Cc: "David S. Miller"
    Cc: Jeff Dike
    Cc: Paolo 'Blaisorblade' Giarrusso
    Cc: Miles Bader
    Cc: Chris Zankel
    Cc: "Luck, Tony"
    Cc: Geert Uytterhoeven
    Cc: Roman Zippel
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Arnd Bergmann
     

01 Oct, 2006

2 commits

  • Now that ptep_establish has a definition in PAE i386 3-level paging code, the
    only paging model which is insane enough to have multi-word hardware PTEs
    which are not efficient to set atomically, we can remove the ghost of
    set_pte_atomic from other architectures which falesly duplicated it, and
    remove all knowledge of it from the generic pgtable code.

    set_pte_atomic is now a private pte operator which is specific to i386

    Signed-off-by: Zachary Amsden
    Cc: Rusty Russell
    Cc: Jeremy Fitzhardinge
    Cc: Andi Kleen
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Zachary Amsden
     
  • Remove a few unused defines and remove obsolete information from comments.

    Signed-off-by: Roman Zippel
    Cc: john stultz
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Roman Zippel
     

27 Sep, 2006

1 commit


26 Sep, 2006

6 commits

  • Optimise ffs(x) by using fls(x & x - 1) which we optimise to use the SCAN
    instruction.

    Signed-off-by: David Howells
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    David Howells
     
  • Implement fls64() for FRV without recource to conditional jumps.

    Signed-off-by: David Howells
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    David Howells
     
  • Fix FRV fls() to handle bit 31 being set correctly (it should return 32 not 0).

    Signed-off-by: David Howells
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    David Howells
     
  • Make the FRV arch use the generic IRQ code rather than having its own
    routines for doing so.

    Signed-off-by: David Howells
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    David Howells
     
  • One of the changes necessary for shared page tables is to standardize the
    pxx_page macros. pte_page and pmd_page have always returned the struct
    page associated with their entry, while pte_page_kernel and pmd_page_kernel
    have returned the kernel virtual address. pud_page and pgd_page, on the
    other hand, return the kernel virtual address.

    Shared page tables needs pud_page and pgd_page to return the actual page
    structures. There are very few actual users of these functions, so it is
    simple to standardize their usage.

    Since this is basic cleanup, I am submitting these changes as a standalone
    patch. Per Hugh Dickins' comments about it, I am also changing the
    pxx_page_kernel macros to pxx_page_vaddr to clarify their meaning.

    Signed-off-by: Dave McCracken
    Cc: Hugh Dickins
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Dave McCracken
     
  • They all contain the same thing. Instead, have a single generic one in
    include/asm-generic, and permit an arch to override as needed.

    Signed-off-by: Jeff Garzik

    Jeff Garzik
     

25 Sep, 2006

1 commit


15 Jul, 2006

1 commit

  • set_wmb should not be used in the kernel because it just confuses the
    code more and has no benefit. Since it is not currently used in the
    kernel this patch removes it so that new code does not include it.

    All archs define set_wmb(var, value) to do { var = value; wmb(); }
    while(0) except ia64 and sparc which use a mb() instead. But this is
    still moot since it is not used anyway.

    Hasn't been tested on any archs but x86 and x86_64 (and only compiled
    tested)

    Signed-off-by: Steven Rostedt
    Signed-off-by: Linus Torvalds

    Steven Rostedt
     

13 Jul, 2006

1 commit

  • During the recent discussion of taking 'volatile' off of the spinlock, I
    noticed that while most arches #define cpu_relax() such that it implies
    barrier(), some arches define cpu_relax() to be empty.

    This patch changes the definition of cpu_relax() for frv, h8300, m68knommu,
    sh, sh64, v850 and xtensa from an empty while(0) to the compiler barrier().

    Signed-off-by: Chase Venters
    Acked-by: Arjan van de Ven
    Signed-off-by: Linus Torvalds

    Chase Venters
     

11 Jul, 2006

2 commits


05 Jul, 2006

1 commit

  • * git://git.infradead.org/hdrinstall-2.6:
    Remove export of include/linux/isdn/tpam.h
    Remove and from userspace export
    Restrict headers exported to userspace for SPARC and SPARC64
    Add empty Kbuild files for 'make headers_install' in remaining arches.
    Add Kbuild file for Alpha 'make headers_install'
    Add Kbuild file for SPARC 'make headers_install'
    Add Kbuild file for IA64 'make headers_install'
    Add Kbuild file for S390 'make headers_install'
    Add Kbuild file for i386 'make headers_install'
    Add Kbuild file for x86_64 'make headers_install'
    Add Kbuild file for PowerPC 'make headers_install'
    Add generic Kbuild files for 'make headers_install'
    Basic implementation of 'make headers_check'
    Basic implementation of 'make headers_install'

    Linus Torvalds
     

03 Jul, 2006

1 commit


30 Jun, 2006

1 commit

  • This patch implements an API whereby an application can determine the
    label of its peer's Unix datagram sockets via the auxiliary data mechanism of
    recvmsg.

    Patch purpose:

    This patch enables a security-aware application to retrieve the
    security context of the peer of a Unix datagram socket. The application
    can then use this security context to determine the security context for
    processing on behalf of the peer who sent the packet.

    Patch design and implementation:

    The design and implementation is very similar to the UDP case for INET
    sockets. Basically we build upon the existing Unix domain socket API for
    retrieving user credentials. Linux offers the API for obtaining user
    credentials via ancillary messages (i.e., out of band/control messages
    that are bundled together with a normal message). To retrieve the security
    context, the application first indicates to the kernel such desire by
    setting the SO_PASSSEC option via getsockopt. Then the application
    retrieves the security context using the auxiliary data mechanism.

    An example server application for Unix datagram socket should look like this:

    toggle = 1;
    toggle_len = sizeof(toggle);

    setsockopt(sockfd, SOL_SOCKET, SO_PASSSEC, &toggle, &toggle_len);
    recvmsg(sockfd, &msg_hdr, 0);
    if (msg_hdr.msg_controllen > sizeof(struct cmsghdr)) {
    cmsg_hdr = CMSG_FIRSTHDR(&msg_hdr);
    if (cmsg_hdr->cmsg_len cmsg_level == SOL_SOCKET &&
    cmsg_hdr->cmsg_type == SCM_SECURITY) {
    memcpy(&scontext, CMSG_DATA(cmsg_hdr), sizeof(scontext));
    }
    }

    sock_setsockopt is enhanced with a new socket option SOCK_PASSSEC to allow
    a server socket to receive security context of the peer.

    Testing:

    We have tested the patch by setting up Unix datagram client and server
    applications. We verified that the server can retrieve the security context
    using the auxiliary data mechanism of recvmsg.

    Signed-off-by: Catherine Zhang
    Acked-by: Acked-by: James Morris
    Signed-off-by: David S. Miller

    Catherine Zhang
     

23 Jun, 2006

9 commits


18 Jun, 2006

1 commit


29 Apr, 2006

1 commit


26 Apr, 2006

1 commit


11 Apr, 2006

2 commits

  • __NR_sys_kexec_load should be __NR_kexec_load. Mainly affects users of the
    _syscallN() macros, and glibc is already checking for __NR_kexec_load.

    Cc: Ulrich Drepper
    Cc: "Eric W. Biederman"
    Cc: Mikael Starvik
    Cc: David Howells
    Cc: Yoshinori Sato
    Cc: Hirokazu Takata
    Cc: Paul Mundt
    Cc: Kazumoto Kojima
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Andrew Morton
     
  • Remove unused prepare_to_switch() macros.

    Signed-off-by: Hirokazu Takata
    Cc: Mikael Starvik
    Cc: David Howells
    Cc: Yoshinori Sato
    Cc: Miles Bader
    Cc: Chris Zankel
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Hirokazu Takata
     

28 Mar, 2006

3 commits

  • - fix: initialize the robust list(s) to NULL in copy_process.

    - doc update

    - cleanup: rename _inuser to _inatomic

    - __user cleanups and other small cleanups

    Signed-off-by: Ingo Molnar
    Cc: Thomas Gleixner
    Cc: Arjan van de Ven
    Cc: Ulrich Drepper
    Cc: Andi Kleen
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Ingo Molnar
     
  • This patchset provides a new (written from scratch) implementation of robust
    futexes, called "lightweight robust futexes". We believe this new
    implementation is faster and simpler than the vma-based robust futex solutions
    presented before, and we'd like this patchset to be adopted in the upstream
    kernel. This is version 1 of the patchset.

    Background
    ----------

    What are robust futexes? To answer that, we first need to understand what
    futexes are: normal futexes are special types of locks that in the
    noncontended case can be acquired/released from userspace without having to
    enter the kernel.

    A futex is in essence a user-space address, e.g. a 32-bit lock variable
    field. If userspace notices contention (the lock is already owned and someone
    else wants to grab it too) then the lock is marked with a value that says
    "there's a waiter pending", and the sys_futex(FUTEX_WAIT) syscall is used to
    wait for the other guy to release it. The kernel creates a 'futex queue'
    internally, so that it can later on match up the waiter with the waker -
    without them having to know about each other. When the owner thread releases
    the futex, it notices (via the variable value) that there were waiter(s)
    pending, and does the sys_futex(FUTEX_WAKE) syscall to wake them up. Once all
    waiters have taken and released the lock, the futex is again back to
    'uncontended' state, and there's no in-kernel state associated with it. The
    kernel completely forgets that there ever was a futex at that address. This
    method makes futexes very lightweight and scalable.

    "Robustness" is about dealing with crashes while holding a lock: if a process
    exits prematurely while holding a pthread_mutex_t lock that is also shared
    with some other process (e.g. yum segfaults while holding a pthread_mutex_t,
    or yum is kill -9-ed), then waiters for that lock need to be notified that the
    last owner of the lock exited in some irregular way.

    To solve such types of problems, "robust mutex" userspace APIs were created:
    pthread_mutex_lock() returns an error value if the owner exits prematurely -
    and the new owner can decide whether the data protected by the lock can be
    recovered safely.

    There is a big conceptual problem with futex based mutexes though: it is the
    kernel that destroys the owner task (e.g. due to a SEGFAULT), but the kernel
    cannot help with the cleanup: if there is no 'futex queue' (and in most cases
    there is none, futexes being fast lightweight locks) then the kernel has no
    information to clean up after the held lock! Userspace has no chance to clean
    up after the lock either - userspace is the one that crashes, so it has no
    opportunity to clean up. Catch-22.

    In practice, when e.g. yum is kill -9-ed (or segfaults), a system reboot is
    needed to release that futex based lock. This is one of the leading
    bugreports against yum.

    To solve this problem, 'Robust Futex' patches were created and presented on
    lkml: the one written by Todd Kneisel and David Singleton is the most advanced
    at the moment. These patches all tried to extend the futex abstraction by
    registering futex-based locks in the kernel - and thus give the kernel a
    chance to clean up.

    E.g. in David Singleton's robust-futex-6.patch, there are 3 new syscall
    variants to sys_futex(): FUTEX_REGISTER, FUTEX_DEREGISTER and FUTEX_RECOVER.
    The kernel attaches such robust futexes to vmas (via
    vma->vm_file->f_mapping->robust_head), and at do_exit() time, all vmas are
    searched to see whether they have a robust_head set.

    Lots of work went into the vma-based robust-futex patch, and recently it has
    improved significantly, but unfortunately it still has two fundamental
    problems left:

    - they have quite complex locking and race scenarios. The vma-based
    patches had been pending for years, but they are still not completely
    reliable.

    - they have to scan _every_ vma at sys_exit() time, per thread!

    The second disadvantage is a real killer: pthread_exit() takes around 1
    microsecond on Linux, but with thousands (or tens of thousands) of vmas every
    pthread_exit() takes a millisecond or more, also totally destroying the CPU's
    L1 and L2 caches!

    This is very much noticeable even for normal process sys_exit_group() calls:
    the kernel has to do the vma scanning unconditionally! (this is because the
    kernel has no knowledge about how many robust futexes there are to be cleaned
    up, because a robust futex might have been registered in another task, and the
    futex variable might have been simply mmap()-ed into this process's address
    space).

    This huge overhead forced the creation of CONFIG_FUTEX_ROBUST, but worse than
    that: the overhead makes robust futexes impractical for any type of generic
    Linux distribution.

    So it became clear to us, something had to be done. Last week, when Thomas
    Gleixner tried to fix up the vma-based robust futex patch in the -rt tree, he
    found a handful of new races and we were talking about it and were analyzing
    the situation. At that point a fundamentally different solution occured to
    me. This patchset (written in the past couple of days) implements that new
    solution. Be warned though - the patchset does things we normally dont do in
    Linux, so some might find the approach disturbing. Parental advice
    recommended ;-)

    New approach to robust futexes
    ------------------------------

    At the heart of this new approach there is a per-thread private list of robust
    locks that userspace is holding (maintained by glibc) - which userspace list
    is registered with the kernel via a new syscall [this registration happens at
    most once per thread lifetime]. At do_exit() time, the kernel checks this
    user-space list: are there any robust futex locks to be cleaned up?

    In the common case, at do_exit() time, there is no list registered, so the
    cost of robust futexes is just a simple current->robust_list != NULL
    comparison. If the thread has registered a list, then normally the list is
    empty. If the thread/process crashed or terminated in some incorrect way then
    the list might be non-empty: in this case the kernel carefully walks the list
    [not trusting it], and marks all locks that are owned by this thread with the
    FUTEX_OWNER_DEAD bit, and wakes up one waiter (if any).

    The list is guaranteed to be private and per-thread, so it's lockless. There
    is one race possible though: since adding to and removing from the list is
    done after the futex is acquired by glibc, there is a few instructions window
    for the thread (or process) to die there, leaving the futex hung. To protect
    against this possibility, userspace (glibc) also maintains a simple per-thread
    'list_op_pending' field, to allow the kernel to clean up if the thread dies
    after acquiring the lock, but just before it could have added itself to the
    list. Glibc sets this list_op_pending field before it tries to acquire the
    futex, and clears it after the list-add (or list-remove) has finished.

    That's all that is needed - all the rest of robust-futex cleanup is done in
    userspace [just like with the previous patches].

    Ulrich Drepper has implemented the necessary glibc support for this new
    mechanism, which fully enables robust mutexes. (Ulrich plans to commit these
    changes to glibc-HEAD later today.)

    Key differences of this userspace-list based approach, compared to the vma
    based method:

    - it's much, much faster: at thread exit time, there's no need to loop
    over every vma (!), which the VM-based method has to do. Only a very
    simple 'is the list empty' op is done.

    - no VM changes are needed - 'struct address_space' is left alone.

    - no registration of individual locks is needed: robust mutexes dont need
    any extra per-lock syscalls. Robust mutexes thus become a very lightweight
    primitive - so they dont force the application designer to do a hard choice
    between performance and robustness - robust mutexes are just as fast.

    - no per-lock kernel allocation happens.

    - no resource limits are needed.

    - no kernel-space recovery call (FUTEX_RECOVER) is needed.

    - the implementation and the locking is "obvious", and there are no
    interactions with the VM.

    Performance
    -----------

    I have benchmarked the time needed for the kernel to process a list of 1
    million (!) held locks, using the new method [on a 2GHz CPU]:

    - with FUTEX_WAIT set [contended mutex]: 130 msecs
    - without FUTEX_WAIT set [uncontended mutex]: 30 msecs

    I have also measured an approach where glibc does the lock notification [which
    it currently does for !pshared robust mutexes], and that took 256 msecs -
    clearly slower, due to the 1 million FUTEX_WAKE syscalls userspace had to do.

    (1 million held locks are unheard of - we expect at most a handful of locks to
    be held at a time. Nevertheless it's nice to know that this approach scales
    nicely.)

    Implementation details
    ----------------------

    The patch adds two new syscalls: one to register the userspace list, and one
    to query the registered list pointer:

    asmlinkage long
    sys_set_robust_list(struct robust_list_head __user *head,
    size_t len);

    asmlinkage long
    sys_get_robust_list(int pid, struct robust_list_head __user **head_ptr,
    size_t __user *len_ptr);

    List registration is very fast: the pointer is simply stored in
    current->robust_list. [Note that in the future, if robust futexes become
    widespread, we could extend sys_clone() to register a robust-list head for new
    threads, without the need of another syscall.]

    So there is virtually zero overhead for tasks not using robust futexes, and
    even for robust futex users, there is only one extra syscall per thread
    lifetime, and the cleanup operation, if it happens, is fast and
    straightforward. The kernel doesnt have any internal distinction between
    robust and normal futexes.

    If a futex is found to be held at exit time, the kernel sets the highest bit
    of the futex word:

    #define FUTEX_OWNER_DIED 0x40000000

    and wakes up the next futex waiter (if any). User-space does the rest of
    the cleanup.

    Otherwise, robust futexes are acquired by glibc by putting the TID into the
    futex field atomically. Waiters set the FUTEX_WAITERS bit:

    #define FUTEX_WAITERS 0x80000000

    and the remaining bits are for the TID.

    Testing, architecture support
    -----------------------------

    I've tested the new syscalls on x86 and x86_64, and have made sure the parsing
    of the userspace list is robust [ ;-) ] even if the list is deliberately
    corrupted.

    i386 and x86_64 syscalls are wired up at the moment, and Ulrich has tested the
    new glibc code (on x86_64 and i386), and it works for his robust-mutex
    testcases.

    All other architectures should build just fine too - but they wont have the
    new syscalls yet.

    Architectures need to implement the new futex_atomic_cmpxchg_inuser() inline
    function before writing up the syscalls (that function returns -ENOSYS right
    now).

    This patch:

    Add placeholder futex_atomic_cmpxchg_inuser() implementations to every
    architecture that supports futexes. It returns -ENOSYS.

    Signed-off-by: Ingo Molnar
    Signed-off-by: Thomas Gleixner
    Signed-off-by: Arjan van de Ven
    Acked-by: Ulrich Drepper
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Ingo Molnar
     
  • FRV can use generic funcs.

    Signed-off-by: KAMEZAWA Hiroyuki
    Cc: David Howells
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    KAMEZAWA Hiroyuki
     

27 Mar, 2006

1 commit

  • - remove ffz()
    - remove find_{next,first}{,_zero}_bit()
    - remove generic_ffs()
    - remove __ffs()
    - remove generic_fls64()
    - remove sched_find_first_bit()
    - remove generic_hweight{32,16,8}()
    - remove ext2_{set,clear,test,find_first_zero,find_next_zero}_bit()
    - remove minix_{test,set,test_and_clear,test,find_first_zero}_bit()

    Signed-off-by: Akinobu Mita
    Cc: David Howells
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Akinobu Mita