07 Oct, 2010

7 commits


06 Oct, 2010

8 commits

  • As suggested by Stephen Hemminger:
    1) Made functions and data structures static wherever possible.
    2) Removed unused code.

    Signed-off-by: Debashis Dutt
    Signed-off-by: Rasesh Mody
    Signed-off-by: David S. Miller

    Rasesh Mody
     
  • This fix handles the case when IRQ handler is called (for shared IRQs)
    even before the driver is ready to handle interrupts.

    Signed-off-by: Debashis Dutt
    Signed-off-by: Rasesh Mody
    Signed-off-by: David S. Miller

    Rasesh Mody
     
  • Allow sysadmins to configure the number of multicast
    membership report sent on a link failure event.

    Signed-off-by: Flavio Leitner
    Signed-off-by: David S. Miller

    Flavio Leitner
     
  • During a failover, the IGMP membership is sent to update
    the switch restoring the traffic, but it misses groups added
    to VLAN devices running on top of bonding devices.

    This patch changes it to iterate over all VLAN devices
    on top of it sending IGMP memberships too.

    Signed-off-by: Flavio Leitner
    Signed-off-by: David S. Miller

    Flavio Leitner
     
  • Removing the msleep() call in check_sqs() function, and replacing by a wait queue.

    Signed-off-by: Breno Leitao
    Signed-off-by: David S. Miller

    Breno Leitao
     
  • This patch just remove a msleep loop and change to wait queue,
    making the code cleaner.

    Signed-off-by: Breno Leitao
    Acked-by: David Howells
    Signed-off-by: David S. Miller

    Breno Leitao
     
  • Following patch fixes warnings reported by `make namespacecheck`

    Reported by Stephen Hemminger

    CC: Stephen Hemminger
    Signed-off-by: Emil Tantilov
    Acked-by: Greg Rose
    Tested-by: Jeff Pieper
    Signed-off-by: Jeff Kirsher
    Signed-off-by: David S. Miller

    Emil Tantilov
     
  • In various situations, a device provides a packet to our stack and we
    drop it before it enters protocol stack :
    - softnet backlog full (accounted in /proc/net/softnet_stat)
    - bad vlan tag (not accounted)
    - unknown/unregistered protocol (not accounted)

    We can handle a per-device counter of such dropped frames at core level,
    and automatically adds it to the device provided stats (rx_dropped), so
    that standard tools can be used (ifconfig, ip link, cat /proc/net/dev)

    This is a generalization of commit 8990f468a (net: rx_dropped
    accounting), thus reverting it.

    Signed-off-by: Eric Dumazet
    Signed-off-by: David S. Miller

    Eric Dumazet
     

05 Oct, 2010

15 commits

  • Qemu supports up to UIO_MAXIOV s/g so we have to match that because guest
    drivers may rely on this.

    Allocate indirect and log arrays dynamically to avoid using too much contigious
    memory and make the length of hdr array to match the header length since each
    iovec entry has a least one byte.

    Test with copying large files w/ and w/o migration in both linux and windows
    guests.

    Signed-off-by: Jason Wang
    Signed-off-by: Michael S. Tsirkin

    Jason Wang
     
  • Do this instead of subverting fields in skb proper.

    The macros that could very easily match variable or function
    names were also just asking for trouble.

    Signed-off-by: David S. Miller

    David S. Miller
     
  • Make wimax variables and functions local if possible.
    Compile tested only.

    This also removes a couple of unused EXPORT_SYMBOL.
    If this breaks some out of tree code, please fix that
    by putting the code in the kernel tree.

    Signed-off-by: Stephen Hemminger
    Signed-off-by: David S. Miller

    stephen hemminger
     
  • This driver has several pieces of dead code (found by running
    make namespacecheck). This patch removes them.

    Signed-off-by: Stephen Hemminger
    Signed-off-by: David S. Miller

    stephen hemminger
     
  • The kernel doesn't have a symbol called BCM63XX. There is a symbol
    BCM63XX_ENET (introduced in 9b1fc55a0500, 6 weeks after 09bb9aa0ed that
    introduced BCM63XX_PHY), but the driver compiles without that, too.

    Cc: Maxime Bizon
    Cc: Florian Fainelli
    Cc: David S. Miller
    Cc: Ralf Baechle
    Signed-off-by: Uwe Kleine-König
    Signed-off-by: David S. Miller

    Uwe Kleine-König
     
  • MODULE_DEVICE_TABLE only expands to something if it's compiled
    for a module. So when building-in support for the phys, the
    mdio_device_id tables are unused. Marking them with __maybe_unused
    fixes the following warnings:

    drivers/net/phy/bcm63xx.c:134: warning: 'bcm63xx_tbl' defined but not used
    drivers/net/phy/broadcom.c:933: warning: 'broadcom_tbl' defined but not used
    drivers/net/phy/cicada.c:162: warning: 'cicada_tbl' defined but not used
    drivers/net/phy/davicom.c:222: warning: 'davicom_tbl' defined but not used
    drivers/net/phy/et1011c.c:114: warning: 'et1011c_tbl' defined but not used
    drivers/net/phy/icplus.c:137: warning: 'icplus_tbl' defined but not used
    drivers/net/phy/lxt.c:226: warning: 'lxt_tbl' defined but not used
    drivers/net/phy/marvell.c:724: warning: 'marvell_tbl' defined but not used
    drivers/net/phy/micrel.c:234: warning: 'micrel_tbl' defined but not used
    drivers/net/phy/national.c:154: warning: 'ns_tbl' defined but not used
    drivers/net/phy/qsemi.c:141: warning: 'qs6612_tbl' defined but not used
    drivers/net/phy/realtek.c:82: warning: 'realtek_tbl' defined but not used
    drivers/net/phy/smsc.c:257: warning: 'smsc_tbl' defined but not used
    drivers/net/phy/ste10Xp.c:135: warning: 'ste10Xp_tbl' defined but not used
    drivers/net/phy/vitesse.c:195: warning: 'vitesse_tbl' defined but not used

    Signed-off-by: Uwe Kleine-König
    Signed-off-by: David S. Miller

    Uwe Kleine-König
     
  • Setting mtu < 68 is not supported.

    Signed-off-by: Sritej Velaga
    Signed-off-by: Amit Kumar Salecha
    Signed-off-by: David S. Miller

    Sritej Velaga
     
  • Port mode setting is not required for Qlogic CNA adapters.

    Signed-off-by: Sritej Velaga
    Signed-off-by: Amit Kumar Salecha
    Signed-off-by: David S. Miller

    Sritej Velaga
     
  • Signed-off-by: Sucheta Chakraborty
    Signed-off-by: Amit Kumar Salecha
    Signed-off-by: David S. Miller

    Sucheta Chakraborty
     
  • o desc->vlan_tci is in __le16 format. Doing htons and
    cpu_to_le64 again on vlan_tci, result in invalid value on ppc.

    Signed-off-by: Sucheta Chakraborty
    Signed-off-by: Amit Kumar Salecha
    Signed-off-by: David S. Miller

    Sucheta Chakraborty
     
  • ipaddress in ifa->ifa_address field are in big endian format.
    Also device requires ip address in big endian only.

    Signed-off-by: Sucheta Chakraborty
    Signed-off-by: Amit Kumar Salecha
    Signed-off-by: David S. Miller

    Sucheta Chakraborty
     
  • regs_buff[i] and diag_registers[j] array should use different index
    variable.

    Signed-off-by: Amit Kumar Salecha
    Signed-off-by: David S. Miller

    Amit Kumar Salecha
     
  • Some of the counters are not implemented in fw.
    Fw return NOT AVAILABLE VALUE as (0xffffffffffffffff).
    Adding these counters, result in invalid value.

    Signed-off-by: Amit Kumar Salecha
    Signed-off-by: David S. Miller

    Amit Kumar Salecha
     
  • o Loop 10 times with delay of 1 ms to rcv packet.
    o Print garbage packet.
    o Try send/receive MAX(16) packet, instead of exit from test,
    if a packet is not received.

    Signed-off-by: Amit Kumar Salecha
    Signed-off-by: David S. Miller

    Amit Kumar Salecha
     
  • Conflicts:
    net/ipv4/Kconfig
    net/ipv4/tcp_timer.c

    David S. Miller
     

04 Oct, 2010

7 commits

  • This patch adds multiple RX queue support to be2net. There are
    upto 4 extra rx-queues per port into which TCP/UDP traffic can be hashed into.
    Some of the ethtool stats are now displayed on a per queue basis.

    Signed-off-by: Sathya Perla
    Signed-off-by: David S. Miller

    Sathya Perla
     
  • David S. Miller
     
  • This patch adapts qeth to handle tagged frames with VLAN-ID 0 and
    with or without priority information in the tag. It enables qeth to
    receive priority-tagged frames on a base interface, for example from
    z/OS, without configuring an additional VLAN interface.

    Signed-off-by: Ursula Braun
    Signed-off-by: Frank Blaschka
    Signed-off-by: David S. Miller

    Ursula Braun
     
  • Remove a bogus PCI function number check from the driver's .remove
    method that causes pci_release_regions not to be called for function 0
    if additional functions are attached and one of them is used as primary.

    Signed-off-by: Dimitris Michailidis
    Signed-off-by: David S. Miller

    Dimitris Michailidis
     
  • This code does not call deinit_card(card); in an error case, as done in
    other error-handling code in the same function. But actually, the called
    function init_sram can only return 0, so there is no need for the error
    check at all.

    init_sram is also given a void return type, and its single return statement
    at the end of the function is dropped.

    A simplified version of the sematic match that finds this problem is as
    follows: (http://coccinelle.lip6.fr/)

    //
    @r exists@
    @r@
    statement S1,S2,S3;
    constant C1,C2,C3;
    @@

    *if (...)
    {... S1 return -C1;}
    ...
    *if (...)
    {... when != S1
    return -C2;}
    ...
    *if (...)
    {... S1 return -C3;}
    //

    Signed-off-by: Julia Lawall
    Signed-off-by: David S. Miller

    Julia Lawall
     
  • ERROR: trailing statements should be on next line
    #23: FILE: drivers/net/tulip/de4x5.c:5477:
    + if (copy_to_user(ioc->data, tmp.lval, ioc->len)) return -EFAULT;

    total: 1 errors, 0 warnings, 8 lines checked

    ./patches/drivers-net-tulip-de4x5c-fix-copy-length-in-de4x5_ioctl.patch has style problems, please review. If any of these errors
    are false positives report them to the maintainer, see
    CHECKPATCH in MAINTAINERS.

    Please run checkpatch prior to sending patches

    Cc: Dan Rosenberg
    Cc: Grant Grundler
    Cc: Jeff Mahoney
    Signed-off-by: Andrew Morton
    Signed-off-by: David S. Miller

    Andrew Morton
     
  • Since 'select' ignores dependencies, drivers that select INET_LRO must
    depend on INET. This fixes the broken configuration reported in
    .

    Reported-by: Subrata Modak
    Signed-off-by: Ben Hutchings
    Signed-off-by: David S. Miller

    Ben Hutchings
     

01 Oct, 2010

3 commits