Eric Lee / smarc-ti-linux-kernel

14 Oct, 2014

5 commits

  • a20cd88e2   rtc: max77686: Use ffs() to calculate tm_wday ... Browse Code »

    max77686_rtc_calculate_wday() is used to calculate the day of the week
    to be filled in struct rtc_time but that function only calculates the
    number of bits shifted. So the ffs() function can be used to find the
    first bit set instead of a special function.

    [akpm@linux-foundation.org: add comment clarifying ffs() use]
    Signed-off-by: Javier Martinez Canillas
    Cc: Joe Perches
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Javier Martinez Canillas
     
  • ea33c31b6   rtc: max77686: remove unneeded info log ... Browse Code »

    If devm_rtc_device_register() fails a dev_err() is already reported so
    there is no need to do an additional dev_info().

    Signed-off-by: Javier Martinez Canillas
    Cc: Doug Anderson
    Cc: Krzysztof Kozlowski
    Cc: Alessandro Zummo
    Cc: Olof Johansson
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Javier Martinez Canillas
     
  • 1745d6d3b   rtc: max77686: fail to probe if no RTC regmap irqchip is set ... Browse Code »

    The max77686 mfd driver adds a regmap IRQ chip which creates an IRQ
    domain that is used to map the virtual RTC alarm1 interrupt.

    The RTC driver assumes that this will always be true since the PMIC IRQ
    is a required property according to the max77686 DT binding doc. If an
    "interrupts" property is not defined for a max77686 PMIC, then the mfd
    probe function will fail and the RTC platform driver will never be
    probed.

    But even when it is not possible to probe the rtc-max77686 driver
    without a regmap IRQ chip, it's better to explicitly check if the IRQ
    chip data is not NULL and gracefully fail instead of getting an OOPS.

    Signed-off-by: Javier Martinez Canillas
    Reported-by: Krzysztof Kozlowski
    Cc: Doug Anderson
    Cc: Alessandro Zummo
    Cc: Olof Johansson
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Javier Martinez Canillas
     
  • 6b50fac5d   rtc: max77686: remove dead code for SMPL and WTSR ... Browse Code »

    The MAX77686 RTC chip has two features called SMPL (Sudden Momentary
    Power Loss) and WTSR (Watchdog Timeout and Software Resets). Support
    for these features seems to be implemented in the driver but compilation
    is disabled using a C pre-processor conditional.

    This code has been disabled since the driver was original merged in
    commit fca1dd031a28 ("rtc: max77686: add Maxim 77686 driver").

    So, since this code has never been built, let's just remove it.

    Signed-off-by: Javier Martinez Canillas
    Reviewed-by: Krzysztof Kozlowski
    Cc: Doug Anderson
    Cc: Alessandro Zummo
    Cc: Olof Johansson
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Javier Martinez Canillas
     
  • e7f7fc736   rtc: max77686: Allow the max77686 rtc to wakeup the system ... Browse Code »

    This series add support for the Real Time clock present in the Maxim 77802
    Power Managment IC. The version number is quite high because it
    previously was part of a bigger series [0] that aimed to add support for
    all the devices in the max77802 PMIC. But now that the max77802
    dependencies were already merged for 3.17, the series were split but I
    kept the version numbering.

    While working on the max77802 rtc support a lot of feedback was given and
    the issues pointed out also apply to a driver for a similar PMIC RTC
    (max77686). So patches 01/06 to 05/06 in the series are cleanups for the
    max77686 driver and patch 06/06 adds the support for the max77802 RTC.

    The series were tested on an Exynos5250 Snow (max77686) and
    Exynos5420 Peach Pit (max77802) machines.

    This patch (of 6):

    The max77686 includes an RTC that keeps power during suspend. It's
    convenient to be able to use it as a wakeup source.

    Signed-off-by: Doug Anderson
    Signed-off-by: Javier Martinez Canillas
    Reviewed-by: Krzysztof Kozlowski
    Cc: Alessandro Zummo
    Cc: Olof Johansson
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Doug Anderson
     

21 Jul, 2014

1 commit

12 Sep, 2013

1 commit

04 Jul, 2013

2 commits

30 Apr, 2013

8 commits

22 Feb, 2013

2 commits

  • 3cebeb53d   rtc: max77686: use dev_info() instead of printk() ... Browse Code »

    Fix the checkpatch warning as below:

    WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ...

    Signed-off-by: Jingoo Han
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jingoo Han
     
  • fca1dd031   rtc: max77686: add Maxim 77686 driver ... Browse Code »
    13

    Add a driver to support max77686 rtc. MAX77686 rtc support smpl and wtsr
    mode. It has two alarm register which can be used for alarming to wake
    system up. This drvier uses regmap to access its register.

    [akpm@linux-foundation.org: remove inline, __devinit annotations]
    [jg1.han@samsung.com: fix build warnings]
    [akpm@linux-foundation.org: simplify code]
    Signed-off-by: Chiwoong Byun
    Signed-off-by: Jonghwa Lee
    Signed-off-by: Myugnjoo Ham
    Signed-off-by: Kyungmin Park
    Signed-off-by: Jingoo Han
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jonghwa Lee