04 Nov, 2014
1 commit
-
Signed-off-by: Geert Uytterhoeven
Signed-off-by: Greg Kroah-Hartman
24 Sep, 2014
5 commits
-
Allow user mode to add and remove application specific information
elements (ASIEs) to the beacon of a uwb_rc device.Signed-off-by: Thomas Pugliese
Signed-off-by: Greg Kroah-Hartman -
Documentation/usb/WUSB-Design-overview.txt states that UWB devices seen
by a UWB radio controller are added to /sys/bus/uwb/devices, but this
was not actually being done. This functionality is needed in order for
UWB peer devices to be enumerated by user mode tools. This patch
creates a uwb bus type and adds UWB peer devices to it as they are
discovered by the radio controller.Signed-off-by: Thomas Pugliese
Signed-off-by: Greg Kroah-Hartman -
UWB does not require PCI to be enabled so remove build dependency.
Signed-off-by: Thomas Pugliese
Signed-off-by: Greg Kroah-Hartman -
Print info about the radio controller device instead of the its parent
when UWB devices connect and disconnect.Signed-off-by: Thomas Pugliese
Signed-off-by: Greg Kroah-Hartman -
Fix line length in uwb-internal.h
Signed-off-by: Thomas Pugliese
Signed-off-by: Greg Kroah-Hartman
09 Sep, 2014
1 commit
-
Make sure the uwb_dev->bce entry is set before calling uwb_dev_add in
uwbd_dev_onair so that usermode will only see the device after it is
properly initialized. This fixes a kernel panic that can occur if
usermode tries to access the IEs sysfs attribute of a UWB device before
the driver has had a chance to set the beacon cache entry.Signed-off-by: Thomas Pugliese
Cc: stable@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman
02 Aug, 2014
1 commit
-
Correct typo in the name of the type given to sizeof. Because it is the
size of a pointer that is wanted, the typo has no impact on compilation or
execution.This problem was found using Coccinelle (http://coccinelle.lip6.fr/). The
semantic patch used can be found in message 0 of this patch series.Signed-off-by: Julia Lawall
Signed-off-by: Greg Kroah-Hartman
28 May, 2014
5 commits
-
Fix variable set but not used warnings in UWB.
Signed-off-by: Thomas Pugliese
Signed-off-by: Greg Kroah-Hartman -
Comment typo fix.
Signed-off-by: Thomas Pugliese
Signed-off-by: Greg Kroah-Hartman -
Fix whitespace and line length issues reported by checkpatch.
Signed-off-by: Thomas Pugliese
Signed-off-by: Greg Kroah-Hartman -
Add better error messages during the channel change/reservation establish
process.Signed-off-by: Thomas Pugliese
Signed-off-by: Greg Kroah-Hartman -
Make the transition to the UWB_RSV_STATE_NONE state synchronous so that
there is not a race between uwb_rsv_terminate and uwb_rsv_establish.
uwb_rsv_terminate would set the rsv->state to UWB_RSV_STATE_NONE but did
not release the stream resource until a 320ms timeout had expired. If a
user called uwb_rsv_establish during that time, it could fail to
establish the reservation because no stream resources were available.
This patch removes the timer from the uwb_rsv_terminate process since it
is not needed when transitioning to UWB_RSV_STATE_NONE.Signed-off-by: Thomas Pugliese
Signed-off-by: Greg Kroah-Hartman
25 Apr, 2014
1 commit
-
This patch converts the use of spin_lock_irq/spin_unlock_irq to
spin_lock_irqsave/spin_unlock_irqrestore in uwb_rc_set_drp_cmd_done
which is called from a USB completion handler. There are also
whitespace cleanups to make checkpatch.pl happy.Signed-off-by: Thomas Pugliese
Signed-off-by: Greg Kroah-Hartman
17 Apr, 2014
1 commit
-
There is checking NULL before dereferncing but
it need to add "return".Signed-off-by: Daeseok Youn
Signed-off-by: Greg Kroah-Hartman
21 Dec, 2013
4 commits
-
Only acquire rc->uwb_dev.mutex in the error case in
uwbd_evt_handle_rc_bp_slot_change. This fixes a bug where establishing
a reservation on a new channel will fail if we were unable to establish
a reservation on the previous channel due to DRP conflict.If rc->uwb_dev.mutex is acquired in the non-error case when the uwb
system is attempting to start beaconing, it will block because the start
beaconing code is holding this mutex. This prevents any other
notifications from the URC from being processed. In particular, the
DRP_AVAILABILITY notification will not be processed during the start
beaconing process which can result in a failure to establish a
reservation. It is safe to not hold the mutex in the non-error
case since the only other place rc->uwb_dev.beacon_slot is accessed is
in the same worker thread that uwbd_evt_handle_rc_bp_slot_change
executes in.Signed-off-by: Thomas Pugliese
Signed-off-by: Greg Kroah-Hartman -
Use uwb_rsv_callback wrapper instead of calling rsv->callback directly.
uwb_rsv_callback checks for NULL and is used by other callers of the
callback routine.Signed-off-by: Thomas Pugliese
Signed-off-by: Greg Kroah-Hartman -
various whitespace and comment cleanups
Signed-off-by: Thomas Pugliese
Signed-off-by: Greg Kroah-Hartman -
Add debug prints during channel change and beacon actions.
Signed-off-by: Thomas Pugliese
Signed-off-by: Greg Kroah-Hartman
20 Dec, 2013
1 commit
-
This is required so that we give up the last reference to the device.
Signed-off-by: Levente Kurusa
Signed-off-by: Greg Kroah-Hartman
09 Dec, 2013
1 commit
-
Use PCI standard marco dev_is_pci() instead of directly compare
pci_bus_type to check whether it is pci device.Signed-off-by: Yijing Wang
Signed-off-by: Greg Kroah-Hartman
07 Nov, 2013
1 commit
-
Pull driver core / sysfs patches from Greg KH:
"Here's the big driver core / sysfs update for 3.13-rc1.There's lots of dev_groups updates for different subsystems, as they
all get slowly migrated over to the safe versions of the attribute
groups (removing userspace races with the creation of the sysfs
files.) Also in here are some kobject updates, devres expansions, and
the first round of Tejun's sysfs reworking to enable it to be used by
other subsystems as a backend for an in-kernel filesystem.All of these have been in linux-next for a while with no reported
issues"* tag 'driver-core-3.13-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core: (83 commits)
sysfs: rename sysfs_assoc_lock and explain what it's about
sysfs: use generic_file_llseek() for sysfs_file_operations
sysfs: return correct error code on unimplemented mmap()
mdio_bus: convert bus code to use dev_groups
device: Make dev_WARN/dev_WARN_ONCE print device as well as driver name
sysfs: separate out dup filename warning into a separate function
sysfs: move sysfs_hash_and_remove() to fs/sysfs/dir.c
sysfs: remove unused sysfs_get_dentry() prototype
sysfs: honor bin_attr.attr.ignore_lockdep
sysfs: merge sysfs_elem_bin_attr into sysfs_elem_attr
devres: restore zeroing behavior of devres_alloc()
sysfs: fix sysfs_write_file for bin file
input: gameport: convert bus code to use dev_groups
input: serio: remove bus usage of dev_attrs
input: serio: use DEVICE_ATTR_RO()
i2o: convert bus code to use dev_groups
memstick: convert bus code to use dev_groups
tifm: convert bus code to use dev_groups
virtio: convert bus code to use dev_groups
ipack: convert bus code to use dev_groups
...
30 Oct, 2013
1 commit
-
The ATTRIBUTE_GROUPS() macro can be used in the uwb code to reduce the
number of lines of code.Signed-off-by: Greg Kroah-Hartman
17 Oct, 2013
1 commit
-
The dev_attrs field of struct bus_type is going away soon, dev_groups
should be used instead. This converts the uwb bus code to use the
correct field.Cc: Bruno Morelli
Cc:
Signed-off-by: Greg Kroah-Hartman
20 Aug, 2013
1 commit
-
These local symbols are used only in this file.
Fix the following sparse warnings:drivers/uwb/drp-ie.c:30:5: warning: symbol 'uwb_rsv_reason_code' was not declared. Should it be static?
drivers/uwb/drp-ie.c:58:5: warning: symbol 'uwb_rsv_companion_reason_code' was not declared. Should it be static?Signed-off-by: Jingoo Han
Signed-off-by: Greg Kroah-Hartman
13 Aug, 2013
2 commits
-
In the disconnect routine for the hwa_hc interface, it calls
uwb_pal_unregister to unregister itself from the UWB subsystem. This
function attempts to clean up the link to the host controller directory in
the device's UWB radio control interface directory. If the disconnect
routine for the radio control interface has already run, the uwb directory
will be gone so the call to sysfs_remove_link generates a warning.Signed-off-by: Thomas Pugliese
Signed-off-by: Greg Kroah-Hartman -
This patch fixes a kernel panic that can occur when unplugging the HWA
dongle while a downstream device is in the process of disconnecting.
This involved 2 changes. First, call usb_lock_device_for_reset before
usb_reset_device to synchronize the HWA's post_rest and disconnect
routines. Second, set the hwarc->neep_urb and hwarc->rd_buffer to NULL
when they are freed in the error path in the post_reset routine. This
prevents a double free when the disconnect routine is called and attempts
to free those resources again.Signed-off-by: Thomas Pugliese
Signed-off-by: Greg Kroah-Hartman
04 Jul, 2013
1 commit
-
Calling dev_set_name with a single paramter causes it to be handled as a
format string. Many callers are passing potentially dynamic string
content, so use "%s" in those cases to avoid any potential accidents,
including wrappers like device_create*() and bdi_register().Signed-off-by: Kees Cook
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
25 Jun, 2013
1 commit
-
This patch fixes a race condition that caused the HWA_HC interface probe
function to occasionally fail. The HWA_HC would attempt to register
itself with the HWA_RC by searching for a uwb_rc class device with the
same parent device ptr. If the probe function for the HWA_RC interface
had yet to run, the uwb_rc class device would not have been created
causing the look up to fail and the HWA_HC probe function to return an
error causing the device to be unusable.The fix is for the HWA to delay registering with the HWA_RC until
receiving the command from userspace to start the wireless channel. It
is the responsibility of userspace to ensure that the uwb_rc class
device has been created before starting the HWA channel.Signed-off-by: Thomas Pugliese
Signed-off-by: Greg Kroah-Hartman
07 Jun, 2013
1 commit
-
This patch adds support for the Alereon 5310 and 5611 devices to the
HWA-rc driver.Signed-off-by: Thomas Pugliese
Signed-off-by: Greg Kroah-Hartman
04 Jun, 2013
1 commit
-
In kernel we have nice specifier %*ph to dump small buffers. Let's use it.
Signed-off-by: Andy Shevchenko
Signed-off-by: Greg Kroah-Hartman
22 May, 2013
2 commits
-
The rc object's members can be accessed from both a timer and URB
callback. Use spin_*_irq instead of spin_*_bh.Signed-off-by: Thomas Pugliese
Signed-off-by: Greg Kroah-Hartman -
Removing some boilerplate by using module_pci_driver instead of calling
register and unregister in the otherwise empty init/exit functions.Signed-off-by: Peter Huewe
Signed-off-by: Greg Kroah-Hartman
30 Apr, 2013
1 commit
-
Use preferable function name which implies using a pseudo-random
number generator.Signed-off-by: Akinobu Mita
Cc: Greg KH
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
07 Feb, 2013
1 commit
-
All in-kernel users of class_find_device() don't really need mutable
data for match callback.In two places (kernel/power/suspend_test.c, drivers/scsi/osd/osd_uld.c)
this patch changes match callbacks to use const search data.The const is propagated to rtc_class_open() and power_supply_get_by_name()
parameters.Note that there's a dev reference leak in suspend_test.c that's not
touched in this patch.Signed-off-by: Michał Mirosław
Acked-by: Grant Likely
Signed-off-by: Greg Kroah-Hartman
27 Nov, 2012
1 commit
-
There is the only path in uwb_rc_cmd_async() where rc->uwb_dev is left unlocked.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov
Signed-off-by: Greg Kroah-Hartman
16 Nov, 2012
1 commit
-
The CONFIG_EXPERIMENTAL config item has not carried much meaning for a
while now and is almost always enabled by default. As agreed during the
Linux kernel summit, remove it from any "depends on" lines in Kconfigs.Signed-off-by: Kees Cook
Signed-off-by: Greg Kroah-Hartman
26 Oct, 2012
1 commit
-
Fix usage of device_trylock. It has the same semantics of mutex_trylock, so it
returns 1 if the lock has been acquired successfully.Signed-off-by: Claudio Scordino
Signed-off-by: Bruno Morelli
Signed-off-by: Greg Kroah-Hartman
19 Apr, 2012
2 commits
-
Fatal errors such as a device disconnect must not trigger
error handling. The error returns must be checked.Signed-off-by: Oliver Neukum
Cc: stable
Signed-off-by: Greg Kroah-Hartman -
del_timer_sync() cannot be used in interrupt.
Replace it with del_timer() and a flagSigned-off-by: Oliver Neukum
Cc: stable
Signed-off-by: Greg Kroah-Hartman
