Eric Lee / smarc-ti-linux-kernel

01 Feb, 2008

3 commits

16 Oct, 2007

2 commits

11 May, 2007

1 commit

09 Feb, 2007

1 commit

05 Dec, 2006

2 commits

09 Oct, 2006

1 commit

05 Oct, 2006

1 commit

  • 7d12e780e   IRQ: Maintain regs pointer globally rather than passing to IRQ handlers ... Browse Code »

    Maintain a per-CPU global "struct pt_regs *" variable which can be used instead
    of passing regs around manually through all ~1800 interrupt handlers in the
    Linux kernel.

    The regs pointer is used in few places, but it potentially costs both stack
    space and code to pass it around. On the FRV arch, removing the regs parameter
    from all the genirq function results in a 20% speed up of the IRQ exit path
    (ie: from leaving timer_interrupt() to leaving do_IRQ()).

    Where appropriate, an arch may override the generic storage facility and do
    something different with the variable. On FRV, for instance, the address is
    maintained in GR28 at all times inside the kernel as part of general exception
    handling.

    Having looked over the code, it appears that the parameter may be handed down
    through up to twenty or so layers of functions. Consider a USB character
    device attached to a USB hub, attached to a USB controller that posts its
    interrupts through a cascaded auxiliary interrupt controller. A character
    device driver may want to pass regs to the sysrq handler through the input
    layer which adds another few layers of parameter passing.

    I've build this code with allyesconfig for x86_64 and i386. I've runtested the
    main part of the code on FRV and i386, though I can't test most of the drivers.
    I've also done partial conversion for powerpc and MIPS - these at least compile
    with minimal configurations.

    This will affect all archs. Mostly the changes should be relatively easy.
    Take do_IRQ(), store the regs pointer at the beginning, saving the old one:

    struct pt_regs *old_regs = set_irq_regs(regs);

    And put the old one back at the end:

    set_irq_regs(old_regs);

    Don't pass regs through to generic_handle_irq() or __do_IRQ().

    In timer_interrupt(), this sort of change will be necessary:

    - update_process_times(user_mode(regs));
    - profile_tick(CPU_PROFILING, regs);
    + update_process_times(user_mode(get_irq_regs()));
    + profile_tick(CPU_PROFILING);

    I'd like to move update_process_times()'s use of get_irq_regs() into itself,
    except that i386, alone of the archs, uses something other than user_mode().

    Some notes on the interrupt handling in the drivers:

    (*) input_dev() is now gone entirely. The regs pointer is no longer stored in
    the input_dev struct.

    (*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking. It does
    something different depending on whether it's been supplied with a regs
    pointer or not.

    (*) Various IRQ handler function pointers have been moved to type
    irq_handler_t.

    Signed-Off-By: David Howells
    (cherry picked from 1b16e7ac850969f38b375e511e3fa2f474a33867 commit)

    David Howells
     

23 Sep, 2006

3 commits

13 Jul, 2006

1 commit

  • cb6dd2609   [ALSA] Memory leak in sound/pcmcia/pdaudiocf/pdaudiocf.c ... Browse Code »

    if one of the first three CS_CHECKS fails, we goto cs_failed:
    In this case parse we donr kfree() parse. Since the the last three
    CS_CHECKS might also fail, i moved the kfree() below all the CS_CHECKs
    and added one in the error path. This fixes coverity bug id #1099

    Signed-off-by: Eric Sesterhenn
    Signed-off-by: Takashi Iwai
    Signed-off-by: Jaroslav Kysela

    Eric Sesterhenn
     

23 Jun, 2006

3 commits

28 Apr, 2006

1 commit

31 Mar, 2006

9 commits

22 Mar, 2006

2 commits

10 Jan, 2006

1 commit

06 Jan, 2006

1 commit

03 Jan, 2006

6 commits

04 Nov, 2005

1 commit

12 Sep, 2005

1 commit

  • 561b220a4   [ALSA] Replace with kzalloc() - others ... Browse Code »

    Documentation,SA11xx UDA1341 driver,Generic drivers,MPU401 UART,OPL3
    OPL4,Digigram VX core,I2C cs8427,I2C lib core,I2C tea6330t,L3 drivers
    AK4114 receiver,AK4117 receiver,PDAudioCF driver,PPC PMAC driver
    SPARC AMD7930 driver,SPARC cs4231 driver,Synth,Common EMU synth
    USB generic driver,USB USX2Y
    Replace kcalloc(1,..) with kzalloc().

    Signed-off-by: Takashi Iwai

    Takashi Iwai