04 Apr, 2014

1 commit

  • NO_IRQ may be defined as '(unsigned int) -1' in some architectures (arm,
    sh ...), and either may not be defined in some architectures (arm64) which
    can enable RTC_DRV_S3C.

    Also since platform_get_irq returns err-code in case of any error, we do
    not need to intialize s3c_rtc_alarmno and s3c_rtc_tickno.

    Signed-off-by: Pankaj Dubey
    Cc: Alessandro Zummo
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Pankaj Dubey
     

04 Mar, 2014

1 commit


04 Jul, 2013

1 commit

  • The driver core clears the driver data to NULL after device_release or
    on probe failure, since commit 0998d063100 ("device-core: Ensure drvdata
    = NULL when no driver is bound"). Thus, it is not needed to manually
    clear the device driver data to NULL.

    Signed-off-by: Jingoo Han
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jingoo Han
     

18 May, 2013

1 commit


03 May, 2013

1 commit

  • Pull ARM SoC multiplatform updates from Olof Johansson:
    "More multiplatform enablement for ARM platforms. The ones converted
    in this branch are:

    - bcm2835
    - cns3xxx
    - sirf
    - nomadik
    - msx
    - spear
    - tegra
    - ux500

    We're getting close to having most of them converted!

    One of the larger platforms remaining is Samsung Exynos, and there are
    a bunch of supporting patches in this merge window for it. There was
    a patch in this branch to a early version of multiplatform conversion,
    but it ended up being reverted due to need of more bake time. The
    revert commit is part of the branch since it would have required
    rebasing multiple dependent branches and they were stable by then"

    * tag 'multiplatform-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc: (70 commits)
    mmc: sdhci-s3c: Fix operation on non-single image Samsung platforms
    clocksource: nomadik-mtu: fix up clocksource/timer
    Revert "ARM: exynos: enable multiplatform support"
    ARM: SPEAr13xx: Fix typo "ARCH_HAVE_CPUFREQ"
    ARM: exynos: enable multiplatform support
    rtc: s3c: make header file local
    mtd: onenand/samsung: make regs-onenand.h file local
    thermal/exynos: remove unnecessary header inclusions
    mmc: sdhci-s3c: remove platform dependencies
    ARM: samsung: move mfc device definition to s5p-dev-mfc.c
    ARM: exynos: move debug-macro.S to include/debug/
    ARM: exynos: prepare for sparse IRQ
    ARM: exynos: introduce EXYNOS_ATAGS symbol
    ARM: tegra: build assembly files with -march=armv7-a
    ARM: Push selects for TWD/SCU into machine entries
    ARM: ux500: build hotplug.o for ARMv7-a
    ARM: ux500: move to multiplatform
    ARM: ux500: make remaining headers local
    ARM: ux500: make irqs.h local to platform
    ARM: ux500: get rid of
    ...

    Linus Torvalds
     

30 Apr, 2013

3 commits


19 Apr, 2013

1 commit

  • Nothing outside of the rtc driver includes plat/regs-rtc.h,
    so we can simply move the file into the same directory,
    which allows us to build the file as platform-independent
    code.

    Signed-off-by: Arnd Bergmann
    Cc: rtc-linux@googlegroups.com
    Cc: Alessandro Zummo

    Arnd Bergmann
     

22 Feb, 2013

2 commits

  • Merge misc patches from Andrew Morton:

    - Florian has vanished so I appear to have become fbdev maintainer
    again :(

    - Joel and Mark are distracted to welcome to the new OCFS2 maintainer

    - The backlight queue

    - Small core kernel changes

    - lib/ updates

    - The rtc queue

    - Various random bits

    * akpm: (164 commits)
    rtc: rtc-davinci: use devm_*() functions
    rtc: rtc-max8997: use devm_request_threaded_irq()
    rtc: rtc-max8907: use devm_request_threaded_irq()
    rtc: rtc-da9052: use devm_request_threaded_irq()
    rtc: rtc-wm831x: use devm_request_threaded_irq()
    rtc: rtc-tps80031: use devm_request_threaded_irq()
    rtc: rtc-lp8788: use devm_request_threaded_irq()
    rtc: rtc-coh901331: use devm_clk_get()
    rtc: rtc-vt8500: use devm_*() functions
    rtc: rtc-tps6586x: use devm_request_threaded_irq()
    rtc: rtc-imxdi: use devm_clk_get()
    rtc: rtc-cmos: use dev_warn()/dev_dbg() instead of printk()/pr_debug()
    rtc: rtc-pcf8583: use dev_warn() instead of printk()
    rtc: rtc-sun4v: use pr_warn() instead of printk()
    rtc: rtc-vr41xx: use dev_info() instead of printk()
    rtc: rtc-rs5c313: use pr_err() instead of printk()
    rtc: rtc-at91rm9200: use dev_dbg()/dev_err() instead of printk()/pr_debug()
    rtc: rtc-rs5c372: use dev_dbg()/dev_warn() instead of printk()/pr_debug()
    rtc: rtc-ds2404: use dev_err() instead of printk()
    rtc: rtc-efi: use dev_err()/dev_warn()/pr_err() instead of printk()
    ...

    Linus Torvalds
     
  • Use dev_dbg() instaed of pr_debug() to be consistent.

    Signed-off-by: Jingoo Han
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jingoo Han
     

23 Jan, 2013

1 commit

  • Convert all uses of devm_request_and_ioremap() to the newly introduced
    devm_ioremap_resource() which provides more consistent error handling.

    devm_ioremap_resource() provides its own error messages so all explicit
    error messages can be removed from the failure code paths.

    Signed-off-by: Thierry Reding
    Acked-by: Viresh Kumar
    Cc: Alessandro Zummo
    Signed-off-by: Greg Kroah-Hartman

    Thierry Reding
     

04 Jan, 2013

1 commit

  • CONFIG_HOTPLUG is going away as an option. As a result, the __dev*
    markings need to be removed.

    This change removes the use of __devinit, __devexit_p, __devinitdata,
    __devinitconst, and __devexit from these drivers.

    Based on patches originally written by Bill Pemberton, but redone by me
    in order to handle some of the coding style issues better, by hand.

    Cc: Bill Pemberton
    Cc: Alessandro Zummo
    Cc: Srinidhi Kasagar
    Cc: Linus Walleij
    Cc: Mike Frysinger
    Cc: Wan ZongShun
    Cc: Guan Xuetao
    Cc: Mark Brown
    Signed-off-by: Greg Kroah-Hartman

    Greg Kroah-Hartman
     

18 Dec, 2012

3 commits


19 Nov, 2012

1 commit


06 Oct, 2012

1 commit


31 Jul, 2012

1 commit


30 May, 2012

1 commit


13 Apr, 2012

2 commits

  • Driver data field is a pointer, hence assigning that to an integer results
    in compilation warnings.

    Fixes following compilation warnings:

    drivers/rtc/rtc-s3c.c: In function `s3c_rtc_get_driver_data':
    drivers/rtc/rtc-s3c.c:452:3: warning: return makes integer from pointer without a cast [enabled by default]
    drivers/rtc/rtc-s3c.c: At top level:
    drivers/rtc/rtc-s3c.c:674:3: warning: initialization makes pointer from integer without a cast [enabled by default]
    drivers/rtc/rtc-s3c.c:674:3: warning: (near initialization for `s3c_rtc_dt_match[1].data') [enabled by default]
    drivers/rtc/rtc-s3c.c:677:3: warning: initialization makes pointer from integer without a cast [enabled by default]
    drivers/rtc/rtc-s3c.c:677:3: warning: (near initialization for `s3c_rtc_dt_match[2].data') [enabled by default]
    drivers/rtc/rtc-s3c.c:680:3: warning: initialization makes pointer from integer without a cast [enabled by default]
    drivers/rtc/rtc-s3c.c:680:3: warning: (near initialization for `s3c_rtc_dt_match[3].data') [enabled by default]

    Signed-off-by: Tushar Behera
    Cc: Heiko Stuebner
    Cc: Alessandro Zummo
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Tushar Behera
     
  • Fix this error:

    drivers/rtc/rtc-s3c.c: At top level:
    drivers/rtc/rtc-s3c.c:671:3: error: request for member `data' in something not a structure or union
    drivers/rtc/rtc-s3c.c:674:3: error: request for member `data' in something not a structure or union
    drivers/rtc/rtc-s3c.c:677:3: error: request for member `data' in something not a structure or union
    drivers/rtc/rtc-s3c.c:680:3: error: request for member `data' in something not a structure or union

    Signed-off-by: Tushar Behera
    Cc: Heiko Stuebner
    Cc: Alessandro Zummo
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Tushar Behera
     

28 Mar, 2012

1 commit

  • Pull "ARM: driver specific updates" from Arnd Bergmann:
    "These are all specific to some driver. They are typically the
    platform side of a change in the drivers directory, such as adding a
    new driver or extending the interface to the platform. In cases where
    there is no maintainer for the driver, or the maintainer prefers to
    have the platform changes in the same branch as the driver changes,
    the patches to the drivers are included as well.

    A much smaller set of driver updates that depend on other branches
    getting merged first will be sent later.

    The new export of tegra_chip_uid conflicts with other changes in
    fuse.c. In rtc-sa1100.c, the global removal of IRQF_DISABLED
    conflicts with the cleanup of the interrupt handling of that driver.

    Signed-off-by: Arnd Bergmann "

    Fixed up aforementioned trivial conflicts.

    * tag 'drivers' of git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc: (94 commits)
    ARM: SAMSUNG: change the name from s3c-sdhci to exynos4-sdhci
    mmc: sdhci-s3c: add platform data for the second capability
    ARM: SAMSUNG: support the second capability for samsung-soc
    ARM: EXYNOS: add support DMA for EXYNOS4X12 SoC
    ARM: EXYNOS: Add apb_pclk clkdev entry for mdma1
    ARM: EXYNOS: Enable MDMA driver
    regulator: Remove bq24022 regulator driver
    rtc: sa1100: add OF support
    pxa: magician/hx4700: Convert to gpio-regulator from bq24022
    ARM: OMAP3+: SmartReflex: fix error handling
    ARM: OMAP3+: SmartReflex: fix the use of debugfs_create_* API
    ARM: OMAP3+: SmartReflex: micro-optimization for sanity check
    ARM: OMAP3+: SmartReflex: misc cleanups
    ARM: OMAP3+: SmartReflex: move late_initcall() closer to its argument
    ARM: OMAP3+: SmartReflex: add missing platform_set_drvdata()
    ARM: OMAP3+: hwmod: add SmartReflex IRQs
    ARM: OMAP3+: SmartReflex: clear ERRCONFIG_VPBOUNDINTST only on a need
    ARM: OMAP3+: SmartReflex: Fix status masking in ERRCONFIG register
    ARM: OMAP3+: SmartReflex: Add a shutdown hook
    ARM: OMAP3+: SmartReflex Class3: disable errorgen before disable VP
    ...

    Conflicts:
    arch/arm/mach-tegra/Makefile
    arch/arm/mach-tegra/fuse.c
    drivers/rtc/rtc-sa1100.c

    Linus Torvalds
     

24 Mar, 2012

1 commit

  • Since commit e58aa3d2d0cc ("genirq: run irq handlers with interrupts
    disabled") we run all interrupt handlers with interrupts disabled and we
    even check and yell when an interrupt handler returns with interrupts
    enabled - see commit b738a50a2026 ("genirq: warn when handler enables
    interrupts").

    So now this flag is a NOOP and can be removed.

    Signed-off-by: Yong Zhang
    Acked-by: Linus Walleij
    Acked-by: Wan ZongShun
    Cc: Alessandro Zummo
    Cc: Thomas Gleixner
    Cc: Ingo Molnar
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Yong Zhang
     

07 Feb, 2012

2 commits


11 Jan, 2012

1 commit

  • This patch converts the drivers in drivers/rtc/* to use the
    module_platform_driver() macro which makes the code smaller and a bit
    simpler.

    Signed-off-by: Axel Lin
    Acked-by: Mark Brown
    Acked-by: Mike Frysinger
    Acked-by: Guan Xuetao
    Acked-by: Linus Walleij
    Acked-by: Haojian Zhuang
    Cc: Alessandro Zummo
    Cc: Srinidhi Kasagar
    Cc: Lars-Peter Clausen
    Cc: Ben Dooks
    Cc: John Stultz
    Acked-by: Jean-Christophe PLAGNIOL-VILLARD
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Axel Lin
     

23 Dec, 2011

1 commit


09 Dec, 2011

1 commit


15 Sep, 2011

1 commit

  • The driver does not generate an alarm interrupt even though a time for
    an alarm is set.

    This results from disabling rtc_clk after setting the alarm time.

    To generate an alarm interrupt the driver should maintain its enabled
    state for rtc_clk the until alarm interrupt occurs. This patch permits
    generation of an alarm interrupt.

    [akpm@linux-foundation.org: make s3c_rtc_alarm_clk_lock local to s3c_rtc_alarm_clk_enable()]
    Signed-off-by: Donggeun Kim
    Signed-off-by: MyungJoo Ham
    Signed-off-by: Kyungmin Park
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Donggeun Kim
     

26 Aug, 2011

2 commits

  • The previous rtc-s3c had two issues related with its IRQ.

    1. Users cannot open rtc multiple times because an open operation
    calls request_irq on the same IRQ. (e.g., two user processes wants to
    open and read RTC time from rtc-s3c at the same time)

    2. If alarm is set and no one has the rtc opened with filesystem
    (either the alarm is set by kernel/boot-loader or user set an alarm and
    closed rtc dev file), the pending bit is not cleared and no further
    interrupt is invoked. When the alarm is used by the system itself such
    as a resume from suspend-to-RAM or other Low-power modes/idle, this is
    a critical issue.

    This patch mitigates these issues by calling request_irq at probe and
    free_irq at remove.

    Signed-off-by: MyungJoo Ham
    Signed-off-by: Kyungmin Park
    Acked-by: Kukjin Kim
    Cc: Alessandro Zummo
    Cc: Changhwan Youn
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    MyungJoo Ham
     
  • RTC-S3C used to print out debug messages incorrectly. This patch
    corrects incorrect outputs. (undecoded bcd numbers, incorrectly decoded
    register values)

    This patch affects the pr-debug messages only.

    Signed-off-by: MyungJoo Ham
    Signed-off-by: Kyungmin Park
    Acked-by: Kukjin Kim
    Cc: Alessandro Zummo
    Cc: Changhwan Youn
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    MyungJoo Ham
     

26 Jul, 2011

2 commits

  • * Merge akpm patch series: (122 commits)
    drivers/connector/cn_proc.c: remove unused local
    Documentation/SubmitChecklist: add RCU debug config options
    reiserfs: use hweight_long()
    reiserfs: use proper little-endian bitops
    pnpacpi: register disabled resources
    drivers/rtc/rtc-tegra.c: properly initialize spinlock
    drivers/rtc/rtc-twl.c: check return value of twl_rtc_write_u8() in twl_rtc_set_time()
    drivers/rtc: add support for Qualcomm PMIC8xxx RTC
    drivers/rtc/rtc-s3c.c: support clock gating
    drivers/rtc/rtc-mpc5121.c: add support for RTC on MPC5200
    init: skip calibration delay if previously done
    misc/eeprom: add eeprom access driver for digsy_mtc board
    misc/eeprom: add driver for microwire 93xx46 EEPROMs
    checkpatch.pl: update $logFunctions
    checkpatch: make utf-8 test --strict
    checkpatch.pl: add ability to ignore various messages
    checkpatch: add a "prefer __aligned" check
    checkpatch: validate signature styles and To: and Cc: lines
    checkpatch: add __rcu as a sparse modifier
    checkpatch: suggest using min_t or max_t
    ...

    Did this as a merge because of (trivial) conflicts in
    - Documentation/feature-removal-schedule.txt
    - arch/xtensa/include/asm/uaccess.h
    that were just easier to fix up in the merge than in the patch series.

    Linus Torvalds
     
  • Add support for clock gating. Power consumption can be reduced by setting
    rtc_clk disabled state except for when RTC related registers are accessed.

    Signed-off-by: Donggeun Kim
    Signed-off-by: MyungJoo Ham
    Signed-off-by: KyungMin Park
    Cc: Alessandro Zummo
    Cc: Ben Dooks
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Donggeun Kim
     

10 Jun, 2011

1 commit


12 May, 2011

1 commit

  • The driver is not balancing set_irq and disable_irq_wake() calls, so
    ensure that it keeps track of whether the wake is enabled.

    The fixes the following error on S3C6410 devices:

    WARNING: at kernel/irq/manage.c:382 set_irq_wake+0x84/0xec()
    Unbalanced IRQ 92 wake disable

    Signed-off-by: Ben Dooks
    Signed-off-by: Mark Brown
    Cc: Alessandro Zummo
    Cc:
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Ben Dooks
     

30 Mar, 2011

1 commit

  • s3c_rtc_setpie was removed, and it resulted in compiler error:

    drivers/rtc/rtc-s3c.c: In function s3c_rtc_release
    drivers/rtc/rtc-s3c.c:339:2: error: implicit declaration of function
    s3c_rtc_setpie

    Fix it by removing s3c_rtc_release calls.

    [jstultz: An identical fix was also sent in by Jiri Pinkava
    ]

    CC: Thomas Gleixner
    CC: Alessandro Zummo
    Signed-off-by: Vasily Khoruzhick
    Signed-off-by: John Stultz

    Vasily Khoruzhick
     

10 Mar, 2011

2 commits

  • With the generic rtc code now emulating PIE mode irqs via an
    hrtimer, no one calls the rtc_class_ops->irq_set_freq call.

    This patch removes the hook and deletes the driver functions
    if no one else calls them.

    CC: Thomas Gleixner
    CC: Alessandro Zummo
    CC: Marcelo Roberto Jimenez
    CC: rtc-linux@googlegroups.com
    Signed-off-by: John Stultz

    John Stultz
     
  • With PIE mode interrupts now emulated in generic code via an hrtimer,
    no one calls rtc_class_ops->irq_set_state(), so this patch removes it
    along with driver implementations.

    CC: Thomas Gleixner
    CC: Alessandro Zummo
    CC: Marcelo Roberto Jimenez
    CC: rtc-linux@googlegroups.com
    Signed-off-by: John Stultz

    John Stultz
     

05 Mar, 2011

1 commit

  • Fix s3c_rtc_setaie() prototype to eliminate the following compile
    warning:

    drivers/rtc/rtc-s3c.c:383: warning: initialization from incompatible pointer type

    (akpm: the rtc_class_ops.alarm_irq_enable() handler is being passed two
    arguments where it expects just one, presumably with undesired effects)

    Signed-off-by: Axel Lin
    Cc: Alessandro Zummo
    Cc: Ben Dooks
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Axel Lin