30 Mar, 2014

1 commit

  • Testing NFS4.0 by pynfs, I got some messeages as,
    "nfsd: inode locked twice during operation."

    When one compound RPC contains two or more ops that locks
    the filehandle,the second op will cause the message.

    As two SETATTR ops, after the first SETATTR, nfsd will not call
    fh_put() to release current filehandle, it means filehandle have
    unlocked with fh_post_saved = 1.
    The second SETATTR find fh_post_saved = 1, and printk the message.

    v2: introduce helper fh_clear_wcc().

    Signed-off-by: Kinglong Mee
    Signed-off-by: J. Bruce Fields

    Kinglong Mee
     

25 Oct, 2013

1 commit


04 Jan, 2012

1 commit


14 Oct, 2010

1 commit

  • As of commit 43a9aa64a2f4330a9cb59aaf5c5636566bce067c "NFSD:
    Fill in WCC data for REMOVE, RMDIR, MKNOD, and MKDIR", we sometimes call
    fh_unlock on a filehandle that isn't fully initialized.

    We should fix up the callers, but as a quick fix it is also sufficient
    just to remove this assertion.

    Reported-by: Marius Tolzmann
    Cc: Chuck Lever
    Signed-off-by: J. Bruce Fields

    J. Bruce Fields
     

16 Dec, 2009

1 commit