24 Nov, 2014

1 commit

  • Based on the spatch

    @@
    expression e;
    @@
    - return (e);
    + return e;

    with heavy hand editing because some of the changes are either whitespace
    or identation only or result in excessivly long lines.

    Signed-off-by: Ralf Baechle

    Ralf Baechle
     

24 Oct, 2014

1 commit

  • When CONFIG_MIPS_MT_SMP is enabled, the following compilation error
    occurs:

    arch/mips/pmcs-msp71xx/msp_irq_cic.c:134: error: ‘irq’ undeclared

    This code clearly never saw a compiler.
    The surrounding code suggests, that 'd->irq' was intended, not
    'irq'.

    This error was found with vampyr.

    Signed-off-by: Stefan Hengelein
    Fixes: d7881fbdf866d7d0 ("MIPS: msp71xx: Convert to new irq_chip functions")
    Acked-by: Geert Uytterhoeven
    Cc: linux-mips@linux-mips.org
    Cc: linux-kernel@vger.kernel.org
    Patchwork: https://patchwork.linux-mips.org/patch/8116/
    Signed-off-by: Ralf Baechle

    Stefan Hengelein
     

23 Oct, 2014

1 commit

  • When CONFIG_MIPS_MT is defined, code is enabled that tries to call
    'set_vi_handler()'. This function is declared in but the
    header is never included. Therefore, the compilation breaks.

    arch/mips/pmcs-msp71xx/msp_irq.c:133: error: implicit declaration of function 'set_vi_handler'

    This error was found with vampyr.

    Signed-off-by: Stefan Hengelein
    Cc: linux-mips@linux-mips.org
    Cc: linux-kernel@vger.kernel.org
    Cc: ryazanov.s.a@gmail.com
    Patchwork: https://patchwork.linux-mips.org/patch/8122/
    Signed-off-by: Ralf Baechle

    Stefan Hengelein
     

19 Aug, 2014

1 commit


24 May, 2014

1 commit

  • Nobody is maintaining SMTC anymore and there also seems to be no userbase.
    Which is a pity - the SMTC technology primarily developed by Kevin D.
    Kissell is an ingenious demonstration for the MT
    ASE's power and elegance.

    Based on Markos Chandras patch
    https://patchwork.linux-mips.org/patch/6719/ which while very similar did
    no longer apply cleanly when I tried to merge it plus some additional
    post-SMTC cleanup - SMTC was a feature as tricky to remove as it was to
    merge once upon a time.

    Signed-off-by: Ralf Baechle

    Ralf Baechle
     

23 May, 2014

2 commits

  • Since v2.6.39 there are checks for CONFIG_MSP_HAS_DUAL_USB and checks
    for CONFIG_MSP_HAS_TSMAC in the code. The related Kconfig symbols have
    never been added. These checks have evaluated to false for three years
    now. Remove them and the code they have been hiding.

    Signed-off-by: Paul Bolle
    Cc: Alan Stern
    Cc: Greg Kroah-Hartman
    Cc: linux-mips@linux-mips.org
    Cc: linux-usb@vger.kernel.org
    Cc: linux-kernel@vger.kernel.org
    Patchwork: https://patchwork.linux-mips.org/patch/6982/
    Signed-off-by: Ralf Baechle

    Paul Bolle
     
  • Commit 8b284dbc2200 ("MIPS: PNX Removing dead CONFIG_PMCTWILED") missed
    one reference to CONFIG_PMCTWILED in the code. It also missed one
    related reference to pmctwiled_setup(). Remove these references now.

    Signed-off-by: Paul Bolle
    Cc: linux-mips@linux-mips.org
    Cc: linux-kernel@vger.kernel.org
    Patchwork: https://patchwork.linux-mips.org/patch/6957/
    Signed-off-by: Ralf Baechle

    Paul Bolle
     

01 Apr, 2014

1 commit

  • With binutils 2.24 the attempt to switch with microMIPS mode to MIPS III
    mode through .set mips3 results in *lots* of warnings like

    {standard input}: Assembler messages:
    {standard input}:397: Warning: the 64-bit MIPS architecture does not support the `smartmips' extension

    during a kernel build. Fixed by using .set arch=r4000 instead.

    This breaks support for building the kernel with binutils 2.13 which
    was supported for 32 bit kernels only anyway and 2.14 which was a bad
    vintage for MIPS anyway.

    Signed-off-by: Ralf Baechle

    Ralf Baechle
     

25 Jan, 2014

1 commit

  • In order to avoid keeping an ever growing list of chips which need to
    select a specific MIPS_L1_CACHE_SHIFT value introduce multiple internal
    and non-exposed Kconfig symbols for the various MIPS_L1_CACHE_SHIFT
    values out there and update the relevant Kconfig symbols to select them.

    Signed-off-by: Florian Fainelli

    Florian Fainelli
     

15 Jul, 2013

1 commit

  • commit 3747069b25e419f6b51395f48127e9812abc3596 upstream.

    The __cpuinit type of throwaway sections might have made sense
    some time ago when RAM was more constrained, but now the savings
    do not offset the cost and complications. For example, the fix in
    commit 5e427ec2d0 ("x86: Fix bit corruption at CPU resume time")
    is a good example of the nasty type of bugs that can be created
    with improper use of the various __init prefixes.

    After a discussion on LKML[1] it was decided that cpuinit should go
    the way of devinit and be phased out. Once all the users are gone,
    we can then finally remove the macros themselves from linux/init.h.

    Note that some harmless section mismatch warnings may result, since
    notify_cpu_starting() and cpu_up() are arch independent (kernel/cpu.c)
    and are flagged as __cpuinit -- so if we remove the __cpuinit from
    the arch specific callers, we will also get section mismatch warnings.
    As an intermediate step, we intend to turn the linux/init.h cpuinit
    related content into no-ops as early as possible, since that will get
    rid of these warnings. In any case, they are temporary and harmless.

    Here, we remove all the MIPS __cpuinit from C code and __CPUINIT
    from asm files. MIPS is interesting in this respect, because there
    are also uasm users hiding behind their own renamed versions of the
    __cpuinit macros.

    [1] https://lkml.org/lkml/2013/5/20/589

    [ralf@linux-mips.org: Folded in Paul's followup fix.]

    Signed-off-by: Paul Gortmaker
    Cc: linux-mips@linux-mips.org
    Patchwork: https://patchwork.linux-mips.org/patch/5494/
    Patchwork: https://patchwork.linux-mips.org/patch/5495/
    Patchwork: https://patchwork.linux-mips.org/patch/5509/
    Signed-off-by: Ralf Baechle

    Paul Gortmaker
     

18 Jun, 2013

1 commit

  • The PMC MSP71XX gpio drivers were added in v2.6.28, see commit
    9fa32c6b02 ("MIPS: PMC MSP71XX gpio drivers"). They are only built if
    CONFIG_HAVE_GPIO_LIB is set.

    But the Kconfig symbol HAVE_GPIO_LIB was already removed in v2.6.27, see
    commit 7444a72eff ("gpiolib: allow user-selection"). So these drivers
    were never buildable. Perhaps no-one noticed because there are no in
    tree users of msp71xx_init_gpio() and msp71xx_init_gpio_extended().
    Anyhow, these drivers can safely be removed.

    Signed-off-by: Paul Bolle
    Cc: linux-mips@linux-mips.org
    Cc: linux-kernel@vger.kernel.org
    Patchwork: https://patchwork.linux-mips.org/patch/5345/
    Signed-off-by: Ralf Baechle

    Paul Bolle
     

22 May, 2013

1 commit


18 May, 2013

1 commit

  • EXPORT_SYMBOL and inline directives are contradictory to each other.
    The patch fixes this inconsistency.

    Found by Linux Driver Verification project (linuxtesting.org).

    Signed-off-by: Denis Efremov
    Cc: linux-mips@linux-mips.org
    Cc: linux-kernel@vger.kernel.org
    Cc: trivial@kernel.org
    Cc: ldv-project@linuxtesting.org
    Patchwork: https://patchwork.linux-mips.org/patch/5227/
    Signed-off-by: Ralf Baechle

    Denis Efremov
     

01 Feb, 2013

1 commit

  • Now that Yosemite's gone we can move the MSP71xx code one level up.

    Shane McDonald 's
    https://patchwork.linux-mips.org/patch/4736/ has been folded into this
    patch.

    Signed-off-by: Ralf Baechle

    Ralf Baechle