31 Oct, 2014

1 commit


01 Oct, 2014

1 commit


13 Aug, 2014

1 commit

  • We should prefer `struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to
    meet kernel coding style guidelines. This issue was reported by checkpatch.

    A simplified version of the semantic patch that makes this change is as
    follows (http://coccinelle.lip6.fr/):

    //

    @@
    identifier i;
    declarer name DEFINE_PCI_DEVICE_TABLE;
    initializer z;
    @@

    - DEFINE_PCI_DEVICE_TABLE(i)
    + const struct pci_device_id i[]
    = z;

    //

    [bhelgaas: add semantic patch]
    Signed-off-by: Benoit Taine
    Signed-off-by: Bjorn Helgaas

    Benoit Taine
     

20 May, 2014

1 commit

  • Unused as configure_filter takes care of setting/clearing RCR_AAP.

    In commit "rtlwifi: rtl8723be: rtl8723com: Remove unused
    allow_all_destaddr functions", Larry Finger removed allow_all_destaddr
    from the struct. This commit removes the related function too.

    Signed-off-by: Peter Wu
    Signed-off-by: John W. Linville

    Peter Wu
     

04 Oct, 2013

1 commit


02 Apr, 2013

2 commits


01 Dec, 2012

1 commit

  • rtlwifi only provides pm callbacks for functions covered by pm sleep
    and they are also just called if CONFIG_PM_SLEEP is set.

    Only add functions rtl_pci_suspend and rtl_pci_resume if
    CONFIG_PM_SLEEP is set and use SIMPLE_DEV_PM_OPS instead of
    manually filling struct dev_pm_ops.

    Signed-off-by: Hauke Mehrtens
    Signed-off-by: John W. Linville

    Hauke Mehrtens
     

31 Oct, 2012

1 commit

  • Realtek devices with designation RTL8188CE-VL have the so-called B-cut
    of the wireless chip. This patch adds the special programming needed by
    these devices. In addition, a variable that was static has been moved into
    the private data area as it is now needed in two different routines. This
    change also fixes a minor bug that would be present if a system had more
    than one RTL81{88,92}CE devices. Other drivers in the rtlwifi family had
    already made this change, thus the variable already exists in the private
    data structure.

    Signed-off-by: Larry Finger
    Cc: Anisse Astier
    Cc: Li Chaoming
    Signed-off-by: John W. Linville

    Larry Finger
     

29 Sep, 2012

1 commit

  • Conflicts:
    drivers/net/team/team.c
    drivers/net/usb/qmi_wwan.c
    net/batman-adv/bat_iv_ogm.c
    net/ipv4/fib_frontend.c
    net/ipv4/route.c
    net/l2tp/l2tp_netlink.c

    The team, fib_frontend, route, and l2tp_netlink conflicts were simply
    overlapping changes.

    qmi_wwan and bat_iv_ogm were of the "use HEAD" variety.

    With help from Antonio Quartulli.

    Signed-off-by: David S. Miller

    David S. Miller
     

13 Sep, 2012

1 commit

  • There are a number of problems that occur for the latest version
    of the Realtek RTL8188CE device with the in-kernel driver. These
    include selection of the wrong firmware, and system lockup. A full
    fix is known, but is too invasive for inclusion in stable. This patch
    fixes the problem with loading the wrong firmware, and logs a message
    that the device may not work for kernels 3.6 and older.

    Signed-off-by: Larry Finger
    Cc: Stable
    Cc: Anisse Astier
    Cc: Li Chaoming
    Tested-by: Anisse Astier
    Signed-off-by: John W. Linville

    Larry Finger
     

08 Sep, 2012

1 commit

  • The rtlwifi family of drivers has the following sparse errors:

    CHECK drivers/net/wireless/rtlwifi/usb.c
    drivers/net/wireless/rtlwifi/usb.c:122:17: warning: cast to restricted __le32
    CHECK drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
    drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c:1157:13: warning: context imbalance in 'rtl92c_dm_refresh_rate_adaptive_mask' - different lock contexts for basic block
    CHECK drivers/net/wireless/rtlwifi/rtl8192ce/hw.c
    drivers/net/wireless/rtlwifi/rtl8192ce/hw.c:1909:30: warning: cast to restricted __le32
    CHECK drivers/net/wireless/rtlwifi/rtl8192ce/sw.c
    drivers/net/wireless/rtlwifi/rtl8192ce/sw.c:345:1: warning: symbol 'rtl92ce_pci_ids' was not declared. Should it be static?
    CHECK drivers/net/wireless/rtlwifi/rtl8192cu/trx.c
    drivers/net/wireless/rtlwifi/rtl8192cu/trx.c:494:9: warning: cast from restricted __le16
    CHECK drivers/net/wireless/rtlwifi/rtl8192se/fw.c
    drivers/net/wireless/rtlwifi/rtl8192se/fw.c:490:17: warning: cast to restricted __le32
    drivers/net/wireless/rtlwifi/rtl8192se/fw.c:490:17: warning: cast to restricted __le32
    drivers/net/wireless/rtlwifi/rtl8192se/fw.c:494:17: warning: cast to restricted __le32
    drivers/net/wireless/rtlwifi/rtl8192se/fw.c:494:17: warning: cast to restricted __le32
    drivers/net/wireless/rtlwifi/rtl8192se/fw.c:499:17: warning: cast to restricted __le32
    drivers/net/wireless/rtlwifi/rtl8192se/fw.c:499:17: warning: cast to restricted __le32
    drivers/net/wireless/rtlwifi/rtl8192se/fw.c:510:25: warning: cast to restricted __le32
    drivers/net/wireless/rtlwifi/rtl8192se/fw.c:510:25: warning: cast to restricted __le32
    drivers/net/wireless/rtlwifi/rtl8192se/fw.c:607:9: warning: cast to restricted __le16
    drivers/net/wireless/rtlwifi/rtl8192se/fw.c:607:9: warning: cast to restricted __le16
    drivers/net/wireless/rtlwifi/rtl8192se/fw.c:650:9: warning: cast to restricted __le16
    drivers/net/wireless/rtlwifi/rtl8192se/fw.c:650:9: warning: cast to restricted __le16
    drivers/net/wireless/rtlwifi/rtl8192se/fw.c:652:9: warning: cast to restricted __le16
    drivers/net/wireless/rtlwifi/rtl8192se/fw.c:652:9: warning: cast to restricted __le16
    CHECK drivers/net/wireless/rtlwifi/rtl8192se/trx.c
    drivers/net/wireless/rtlwifi/rtl8192se/trx.c:758:9: warning: cast from restricted __le32
    drivers/net/wireless/rtlwifi/rtl8192se/trx.c:788:17: warning: cast from restricted __le32
    drivers/net/wireless/rtlwifi/rtl8192se/trx.c:804:17: warning: cast to restricted __le32
    drivers/net/wireless/rtlwifi/rtl8192se/trx.c:804:17: warning: cast to restricted __le32
    drivers/net/wireless/rtlwifi/rtl8192se/trx.c:807:17: warning: cast from restricted __le32

    Signed-off-by: Larry Finger
    Signed-off-by: John W. Linville

    Larry Finger
     

17 Apr, 2012

1 commit

  • This patch converts the drivers in drivers/net/wireless/* to use
    module_pci_driver() macro which makes the code smaller and a bit simpler.

    Signed-off-by: Axel Lin
    Cc: "John W. Linville"
    Cc: Jiri Slaby
    Cc: Nick Kossifidis
    Cc: "Luis R. Rodriguez"
    Cc: Simon Kelley
    Cc: Jouni Malinen
    Cc: Lennert Buytenhek
    Cc: Christian Lamparter
    Cc: Ivo van Doorn
    Cc: Larry Finger
    Cc: linux-wireless@vger.kernel.org
    Acked-by: Lennert Buytenhek
    Signed-off-by: John W. Linville

    Axel Lin
     

31 Jan, 2012

2 commits

  • This patch addresses a kernel bugzilla report and two recent mail threads.

    The kernel bugzilla report is https://bugzilla.kernel.org/show_bug.cgi?id=42632,
    which reports a udev timeout on boot.

    The first mail thread, which was on LKML (http://lkml.indiana.edu/hypermail/
    linux/kernel/1112.3/00965.html) was for a WARNING that occurs after a
    suspend/resume cycle for rtl8192cu.

    The scond mail thread (http://marc.info/?l=linux-wireless&m=132655490826766&w=2)
    concerned changes in udev that break drivers that delay while firmware is loaded
    on modprobe.

    This patch converts all rtlwifi-based drivers to use the asynchronous firmware
    loading mechanism. Drivers rtl8192ce, rtl8192cu and rtl8192de share a common
    callback routine. Driver rtl8192se needs different handling of the firmware,
    thus it has its own code.

    Signed-off-by: Larry Finger
    Cc: Stable
    Signed-off-by: John W. Linville

    Larry Finger
     
  • Although the rtlwifi family of devices contains 11 copies of the pr_fmt
    macro, the macro is not defined for all routines that need it. By moving
    the macro to wifi.h, a single copy is available for all routines.

    Signed-off-by: Larry Finger
    Signed-off-by: John W. Linville

    Larry Finger
     

25 Jan, 2012

3 commits

  • Signed-off-by: Larry Finger
    Signed-off-by: John W. Linville

    Larry Finger
     
  • Consolidate printks to avoid possible message interleaving
    and reduce the object size.

    Remove unnecessary RT_ASSERT parentheses.
    Align arguments.
    Coalesce formats.
    Remove unnecessary __func__ use as the macro uses it.

    $ size drivers/net/wireless/rtlwifi/built-in.o*
    text data bss dec hex filename
    588901 55333 127216 771450 bc57a drivers/net/wireless/rtlwifi/built-in.o.new
    590002 55333 127560 772895 bcb1f drivers/net/wireless/rtlwifi/built-in.o.old

    Signed-off-by: Joe Perches
    Acked-by: Larry Finger
    Signed-off-by: John W. Linville

    Joe Perches
     
  • Consolidate printks to avoid possible message interleaving
    and reduce the object size.

    Remove unnecessary RT_TRACE parentheses.

    Miscellaneous typo and grammar fixes.
    Add missing newlines to formats.
    Remove duplicate KERN_DEBUG prefixes.
    Coalesce formats.
    Align arguments.

    $ size drivers/net/wireless/rtlwifi/built-in.o*
    text data bss dec hex filename
    594841 55333 129680 779854 be64e drivers/net/wireless/rtlwifi/built-in.o.new
    607022 55333 138720 801075 c3933 drivers/net/wireless/rtlwifi/built-in.o.old

    Signed-off-by: Joe Perches
    Acked-by: Larry Finger
    Signed-off-by: John W. Linville

    Joe Perches
     

20 Dec, 2011

1 commit

  • DaveM said:
    Please, this kind of stuff rots forever and not using bool properly
    drives me crazy.

    Joe Perches gave me the spatch script:

    @@
    bool b;
    @@
    -b = 0
    +b = false
    @@
    bool b;
    @@
    -b = 1
    +b = true

    I merely installed coccinelle, read the documentation and took credit.

    Signed-off-by: Rusty Russell
    Signed-off-by: David S. Miller

    Rusty Russell
     

01 Nov, 2011

1 commit


15 Oct, 2011

2 commits


12 Oct, 2011

1 commit


21 Sep, 2011

1 commit


25 Aug, 2011

1 commit


17 May, 2011

1 commit

  • The changes that were made to rtl8192ce when rtl8192cu was added broke
    HT40. The errors included a typo in rtlwifi, a missing routine in
    rtl8192ce and a missing callback of that routine in rtl8192c-common.

    This patch fixes the regression reported in Bug #35082.

    Signed-off-by: Larry Finger
    Cc: stable@kernel.org
    Signed-off-by: John W. Linville

    Larry Finger
     

27 Apr, 2011

4 commits


13 Apr, 2011

1 commit


24 Feb, 2011

1 commit

  • As noted by Stephan Rothwell, an allyesconfig build fails since rtl8192cu
    was merged with failures such as:

    drivers/net/wireless/rtlwifi/rtl8192cu/built-in.o: In function `rtl92c_phy_sw_chnl':
    (.opd+0xf30): multiple definition of `rtl92c_phy_sw_chnl'
    drivers/net/wireless/rtlwifi/rtl8192ce/built-in.o:(.opd+0xb70): first defined here
    drivers/net/wireless/rtlwifi/rtl8192cu/built-in.o: In function `rtl92c_fill_h2c_cmd':
    (.opd+0x288): multiple definition of `rtl92c_fill_h2c_cmd'
    drivers/net/wireless/rtlwifi/rtl8192ce/built-in.o:(.opd+0x288): first defined here

    These are caused because the code shared between rtl8192ce and rtl8192cu
    is included in both drivers. This has been fixed by creating a new modue that
    contains the shared code.

    Signed-off-by: Larry Finger
    Signed-off-by: John W. Linville

    Larry Finger
     

22 Feb, 2011

2 commits


12 Feb, 2011

1 commit


21 Dec, 2010

1 commit