20 Mar, 2014
1 commit
-
udelay() does not work on some architectures for values above
2000, in particular on ARM:ERROR: "__bad_udelay" [drivers/scsi/bfa/bfa.ko] undefined!
Reported-by: Vagrant Cascadian
Signed-off-by: Ben Hutchings
Signed-off-by: James Bottomley
16 Mar, 2014
3 commits
-
For various error conditions the bfa driver just returns
'DID_ERROR', which carries no information at all about the
actual source of error.
This patch updates the error handling to return a correct
error code, depending on the type of error occurred.Signed-off-by: Hannes Reinecke
Acked-by: Vijaya Mohan Guvva
Signed-off-by: James Bottomley -
Fixed following smatch warnings in bfa.
drivers/scsi/bfa/bfa_ioc.c:3882 bfa_sfp_show_comp() error: memcpy()
'des' too small (64 vs 248)
drivers/scsi/bfa/bfa_ioc.c:6859 bfa_flash_status_read() warn: unsigned
'status' is never less than zero.
drivers/scsi/bfa/bfa_ioc.c:6881 bfa_flash_status_read() warn: unsigned
'status' is never less than zero.
drivers/scsi/bfa/bfa_ioc.c:6917 bfa_flash_read_start() warn: unsigned
'status' is never less than zero.
drivers/scsi/bfa/bfa_ioc.c:7043 bfa_flash_raw_read() warn: unsigned
'status' is never less than zero.Signed-off-by: Vijaya Mohan Guvva
Signed-off-by: James Bottomley -
Add the missing unlock before return from function bfad_iocmd_cfg_trunk()
in the error handling case.Signed-off-by: Wei Yongjun
Acked-by: Vijaya Mohan Guvva
Signed-off-by: James Bottomley
23 Jan, 2014
1 commit
19 Dec, 2013
8 commits
-
Patch includes changes to upgrade bfa driver version to 3.2.23.0 and use
firmware version 3.2.3.0Signed-off-by: Vijaya Mohan Guvva
Signed-off-by: James Bottomley -
As per the FCP specs, the timeout for issuing ABTS is 20 sec; not 21
sec. Hence setting the TOV to 20 sec.Signed-off-by: Vijaya Mohan Guvva
Signed-off-by: James Bottomley -
Observed Auto mode in the HBA side while doing manual D-Port test on the
switch side. Mode is not passed to BFA from firmware when the test is
triggered by switch side. BFA just blindly using Auto mode.Signed-off-by: Vijaya Mohan Guvva
Signed-off-by: James Bottomley -
This patch set fixes the issue of brocade management utility hang
(bcu/HCM) when faa attributes are queried from multiple application
threads. Hang was due to race between the threads and completion handler
corruption.Signed-off-by: Vijaya Mohan Guvva
Signed-off-by: James Bottomley -
In direct attach mode, if port features like QoS/Trunk/FEC/CR are
enabled, driver can receive PLOGI from the target before firmware
notifies lport online to the driver. In case the lport is not yet online
and a PLOGI is received, send a reject to the peer port, instead of
dropping it on the floor.Signed-off-by: Vijaya Mohan Guvva
Signed-off-by: James Bottomley -
This patch addresses the issue of port not being registered with SCSI
layer on bfa or firmware initialization failure and subsequently failure
in collecting driver traces for debugging port init failures. Also it
has minor changes related to bfad state machine clean up.Signed-off-by: Vijaya Mohan Guvva
Signed-off-by: James Bottomley -
This patch includes change to enable firmware patch simplication
feature. This feature is targeted to address the requirement to have
independent patch release for firmware. Prior to 3.2.3, releasing a
patch fix for firmware requires changes to bfa, to use new firmware
images. But with these changes, if the new firmware is flashed on to the
HBA with brocade adapter management utilites, driver uses the new
firmware after checking the patch release byte in the firmware version.Signed-off-by: Vijaya Mohan Guvva
Signed-off-by: James Bottomley -
Bfa driver crash is observed while pushing the firmware on to chinook
quad port card due to uninitialized bfi_image_ct2 access which gets
initialized only for CT2 ASIC based cards after request_firmware().
For quard port chinook (CT2 ASIC based), bfi_image_ct2 is not getting
initialized as there is no check for chinook PCI device ID before
request_firmware and instead bfi_image_cb is initialized as it is the
default case for card type check.This patch includes changes to read the right firmware for quad port chinook.
Signed-off-by: Vijaya Mohan Guvva
Cc: stable@vger.kernel.org
Signed-off-by: James Bottomley
03 Dec, 2013
1 commit
-
This patch fixes a crash when tried setting symbolic name for an offline
vport through sysfs. Crash is due to uninitialized pointer lport->ns,
which gets initialized only on linkup (port online).Signed-off-by: Vijaya Mohan Guvva
Cc: stable@vger.kernel.org
Signed-off-by: James Bottomley
16 Nov, 2013
1 commit
-
Pull trivial tree updates from Jiri Kosina:
"Usual earth-shaking, news-breaking, rocket science pile from
trivial.git"* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial: (23 commits)
doc: usb: Fix typo in Documentation/usb/gadget_configs.txt
doc: add missing files to timers/00-INDEX
timekeeping: Fix some trivial typos in comments
mm: Fix some trivial typos in comments
irq: Fix some trivial typos in comments
NUMA: fix typos in Kconfig help text
mm: update 00-INDEX
doc: Documentation/DMA-attributes.txt fix typo
DRM: comment: `halve' -> `half'
Docs: Kconfig: `devlopers' -> `developers'
doc: typo on word accounting in kprobes.c in mutliple architectures
treewide: fix "usefull" typo
treewide: fix "distingush" typo
mm/Kconfig: Grammar s/an/a/
kexec: Typo s/the/then/
Documentation/kvm: Update cpuid documentation for steal time and pv eoi
treewide: Fix common typo in "identify"
__page_to_pfn: Fix typo in comment
Correct some typos for word frequency
clk: fixed-factor: Fix a trivial typo
...
14 Oct, 2013
1 commit
-
Since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound),
the driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.Signed-off-by: Jingoo Han
Cc: James Bottomley
Signed-off-by: Jiri Kosina
24 Sep, 2013
1 commit
-
Use pcie_get_readrq()/pcie_set_readrq() to simplify code.
Jon Mason proposed a similar patch a couple years ago (see below).
[bhelgaas: validate pcie_max_read_reqsz, add pointer to Jon's patch]
Reference: http://lkml.kernel.org/r/1309191190-14670-1-git-send-email-jdmason@kudzu.us
Signed-off-by: Yijing Wang
Signed-off-by: Bjorn Helgaas
Cc: Jiang Liu
Cc: Anil Gurumurthy
Cc: Vijaya Mohan Guvva
Cc: "James E.J. Bottomley"
07 Sep, 2013
1 commit
-
Pull trivial tree from Jiri Kosina:
"The usual trivial updates all over the tree -- mostly typo fixes and
documentation updates"* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial: (52 commits)
doc: Documentation/cputopology.txt fix typo
treewide: Convert retrun typos to return
Fix comment typo for init_cma_reserved_pageblock
Documentation/trace: Correcting and extending tracepoint documentation
mm/hotplug: fix a typo in Documentation/memory-hotplug.txt
power: Documentation: Update s2ram link
doc: fix a typo in Documentation/00-INDEX
Documentation/printk-formats.txt: No casts needed for u64/s64
doc: Fix typo "is is" in Documentations
treewide: Fix printks with 0x%#
zram: doc fixes
Documentation/kmemcheck: update kmemcheck documentation
doc: documentation/hwspinlock.txt fix typo
PM / Hibernate: add section for resume options
doc: filesystems : Fix typo in Documentations/filesystems
scsi/megaraid fixed several typos in comments
ppc: init_32: Fix error typo "CONFIG_START_KERNEL"
treewide: Add __GFP_NOWARN to k.alloc calls with v.alloc fallbacks
page_isolation: Fix a comment typo in test_pages_isolated()
doc: fix a typo about irq affinity
...
04 Sep, 2013
1 commit
-
Tyops should be fixed.
Signed-off-by: Joe Perches
Signed-off-by: Jiri Kosina
03 Sep, 2013
1 commit
-
This patch updates the firmware to address the thermal notification issue
Signed-off-by: Rasesh Mody
Signed-off-by: James Bottomley
05 Jul, 2013
1 commit
-
Pull first round of SCSI updates from James Bottomley:
"The patch set is mostly driver updates (usf, zfcp, lpfc, mpt2sas,
megaraid_sas, bfa, ipr) and a few bug fixes. Also of note is that the
Buslogic driver has been rewritten to a better coding style and 64 bit
support added. We also removed the libsas limitation on 16 bytes for
the command size (currently no drivers make use of this)"* tag 'scsi-misc' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi: (101 commits)
[SCSI] megaraid: minor cut and paste error fixed.
[SCSI] ufshcd-pltfrm: remove unnecessary dma_set_coherent_mask() call
[SCSI] ufs: fix register address in UIC error interrupt handling
[SCSI] ufshcd-pltfrm: add missing empty slot in ufs_of_match[]
[SCSI] ufs: use devres functions for ufshcd
[SCSI] ufs: Fix the response UPIU length setting
[SCSI] ufs: rework link start-up process
[SCSI] ufs: remove version check before IS reg clear
[SCSI] ufs: amend interrupt configuration
[SCSI] ufs: wrap the i/o access operations
[SCSI] storvsc: Update the storage protocol to win8 level
[SCSI] storvsc: Increase the value of scsi timeout for storvsc devices
[SCSI] MAINTAINERS: Add myself as the maintainer for BusLogic SCSI driver
[SCSI] BusLogic: Port driver to 64-bit.
[SCSI] BusLogic: Fix style issues
[SCSI] libiscsi: Added new boot entries in the session sysfs
[SCSI] aacraid: Fix for arrays are going offline in the system. System hangs
[SCSI] ipr: IOA Status Code(IOASC) update
[SCSI] sd: Update WRITE SAME heuristics
[SCSI] fnic: potential dead lock in fnic_is_abts_pending()
...
29 Jun, 2013
1 commit
-
Signed-off-by: Al Viro
27 Jun, 2013
17 commits
-
Update bfa driver version to 3.2.21.1
Update bfa to use firmware image versions 3.2.1.0Signed-off-by: Vijaya Mohan Guvva
Signed-off-by: James Bottomley -
Disassoicate path_tov in the driver with the dev_loss_tmo set by the
application.Signed-off-by: Vijaya Mohan Guvva
Signed-off-by: James Bottomley -
This patch enables support for chinook quad port 16G FC card (falcon)
Signed-off-by: Vijaya Mohan Guvva
Signed-off-by: James Bottomley -
Fix endianess issue on Big-endian architecture for firmware statistics
Signed-off-by: Vijaya Mohan Guvva
Signed-off-by: James Bottomley -
Fix bug_on condition check in RPSC (Report Port Speed Capabilities)
response processing.Signed-off-by: Vijaya Mohan Guvva
Signed-off-by: James Bottomley -
Allow processing completions from firmware during IOC_DISABLE request is
being processed by the firmware, by setting the queue_process flag
appropriately.Signed-off-by: Vijaya Mohan Guvva
Signed-off-by: James Bottomley -
Get RDS drop interrupts and REC (Read Exchange Concise) related stats
from firmware.Signed-off-by: Vijaya Mohan Guvva
Signed-off-by: James Bottomley -
1. While FRU VPD data update, inform firmware to send a completion event
on I2C bus. Without this change, firmware used to send completion
message on I2C bus for every chunk of FRU VPD update.
2. Support for FRU VPN update on CHINOOK2 cards.
3. Append port count to the model name to differentiate between single
port and dual port model of 1860.
4. Update the size of the model name to 16bytesSigned-off-by: Vijaya Mohan Guvva
Signed-off-by: James Bottomley -
Replaced usage of void * with u64 in data structure shared between
brocade user space libraries and the bfa driver to address pointer
size changes across 32-bit vs 64-bit to have the compatibility between
32bit library and 64bit driver and vice versa.Signed-off-by: Vijaya Mohan Guvva
Signed-off-by: James Bottomley -
Root cause: When kernel crashes, On brocade 815/825 adapters,
bfa IOC state machine and FW doesn't get a notification and
hence are not cleanly shutdown. So registers holding driver/IOC
state information are not reset back to valid disabled/parking
values. This causes subsequent driver initialization to fail
during kdump kernel boot.Fix description: during the initialization of first PCI function, reset
corresponding register when unclean shutown is detect by reading chip
registers. This will make sure that ioc/fw gets clean re-initialization.Signed-off-by: Vijaya Mohan Guvva
Signed-off-by: James Bottomley -
Retry FDISC a max of 6 times. Introduce new events to handle vport
login fails due to max logins to fabric/switch.Signed-off-by: Anil Gurumurthy
Signed-off-by: Vijaya Mohan Guvva
Signed-off-by: James Bottomley -
On Xen kernels, if ATC (address translation cache) is enabled, the
first PCIe DMA read from the adapter fails with an error. This is due to
a bug ASIC, which leads to a failure of 1860 ports to be initialised.This patch includes the fix to disable Invalidated Tag Match Enable
capability by setting the bit 26 of CHIP_MISC_PRG to 0, by default it is
set to 1.Signed-off-by: Anil Gurumurthy
Signed-off-by: Vijaya Mohan Guvva
Signed-off-by: James Bottomley -
Update addl. fields in FDMI to confirm to FC-GS6 standard for RPA and
RHBA commands.Signed-off-by: Anil Gurumurthy
Signed-off-by: Vijaya Mohan Guvva
Signed-off-by: James Bottomley -
The WARN_ON condition check in IO completion path is wrong. IOtags
returned by the firmware is compared with driver/bfa iotag after masking
the retry count bits.Signed-off-by: Vijaya Mohan Guvva
Signed-off-by: James Bottomley -
D-Port is a new port type created with the intention of running link
level diagnostic tests like loopback, traffic test. In static D-port
mode, user configures the port to D-port mode and starts the test, but
in dynamic D-port, once the Brocade switch port is configured to
D-port, it will reject the regular FLOGI from HBA with reason that it is
in D-port mode. So based on the reason code HBA port will turn itself into
D-port and start diagnostic test.Signed-off-by: Sudarsana Reddy Kalluru
Signed-off-by: Vijaya Mohan Guvva
Signed-off-by: James Bottomley -
This patch includes changes to get FC HBA feature Forward Error
Correction (FEC) (enabled at 16Gig speed) status from firmware and to
return to brocade HBA management utility.Signed-off-by: Vijaya Mohan Guvva
Signed-off-by: James Bottomley -
This patch includes changes to 1) Enable/disable fc credit recovery on
Brocade FC adapter port operating at max supported speed. 2) Get credit
recovery status and stats related to credit loss and recovered creditsSigned-off-by: Vijaya Mohan Guvva
Signed-off-by: James Bottomley
26 Jun, 2013
1 commit
-
This patch fixes two cppcheck errors in drivers/scsi/bfa/bfad_im.c
[jejb: correct strlcpy fix]
Signed-off-by: Jakob Normark
Acked-by: Vijay Mohan Guvva
Signed-off-by: James Bottomley
