30 Jul, 2009
2 commits
-
I've been doing this for years, and akpm picked me up on it about 12
months ago. lguest partly serves as example code, so let's do it Right.Also, remove two unused fields in struct vblk_info in the example launcher.
Signed-off-by: Rusty Russell
Cc: Ingo Molnar -
I don't really notice it (except to begrudge the extra vertical
space), but Ingo does. And he pointed out that one excuse of lguest
is as a teaching tool, it should set a good example.Signed-off-by: Rusty Russell
Cc: Ingo Molnar
17 Jul, 2009
1 commit
-
While fixing lg.h to drop the fwd declaration, I noticed
there's another one ;)Signed-off-by: Rusty Russell
01 Jul, 2009
1 commit
-
Change the eventfd interface to de-couple the eventfd memory context, from
the file pointer instance.Without such change, there is no clean way to racely free handle the
POLLHUP event sent when the last instance of the file* goes away. Also,
now the internal eventfd APIs are using the eventfd context instead of the
file*.This patch is required by KVM's IRQfd code, which is still under
development.Signed-off-by: Davide Libenzi
Cc: Gregory Haskins
Cc: Rusty Russell
Cc: Benjamin LaHaise
Cc: Avi Kivity
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
12 Jun, 2009
8 commits
-
We no longer need an efficient mechanism to force the Guest back into
host userspace, as each device is serviced without bothering the main
Guest process (aka. the Launcher).Signed-off-by: Rusty Russell
-
Currently, when a Guest wants to perform I/O it calls LHCALL_NOTIFY with
an address: the main Launcher process returns with this address, and figures
out what device to run.A far nicer model is to let processes bind an eventfd to an address: if we
find one, we simply signal the eventfd.Signed-off-by: Rusty Russell
Cc: Davide Libenzi -
We currently only allow the Launcher process to send interrupts, but it
as we already send interrupts from the hrtimer, it's a simple matter of
extracting that code into a common set_interrupt routine.As we switch to a thread per virtqueue, this avoids a bottleneck through the
main Launcher process.Signed-off-by: Rusty Russell
-
This version requires that host and guest have the same PAE status.
NX cap is not offered to the guest, yet.Signed-off-by: Matias Zabaljauregui
Signed-off-by: Rusty Russell -
replace LHCALL_SET_PMD with LHCALL_SET_PGD hypercall name
(That's really what it is, and the confusion gets worse with PAE support)Signed-off-by: Matias Zabaljauregui
Signed-off-by: Rusty Russell
Reported-by: Jeremy Fitzhardinge -
If GDT_ENTRIES were every > 256, this could become a problem.
Signed-off-by: Matias Zabaljauregui
Signed-off-by: Rusty Russell -
lguest never checked for pending interrupts when enabling interrupts, and
things still worked. However, it makes a significant difference to TCP
performance, so it's time we fixed it by introducing a pending_irq flag
and checking it on irq_restore and irq_enable.These two routines are now too big to patch into the 8/10 bytes
patch space, so we drop that code.Note: The high latency on interrupt delivery had a very curious
effect: once everything else was optimized, networking without GSO was
faster than networking with GSO, since more interrupts were sent and
hence a greater chance of one getting through to the Guest!Note2: (Almost) Closing the same loophole for iret doesn't have any
measurable effect, so I'm leaving that patch for the moment.Before:
1GB tcpblast Guest->Host: 30.7 seconds
1GB tcpblast Guest->Host (no GSO): 76.0 secondsAfter:
1GB tcpblast Guest->Host: 6.8 seconds
1GB tcpblast Guest->Host (no GSO): 27.8 secondsSigned-off-by: Rusty Russell
-
When the Guest does the LHCALL_HALT hypercall, we go to sleep, expecting
that a timer or the Waker will wake_up_process() us.But we do it in a stupid way, leaving a classic missing wakeup race.
So split maybe_do_interrupt() into interrupt_pending() and
try_deliver_interrupt(), and check maybe_do_interrupt() and the
"break_out" flag before calling schedule.Signed-off-by: Rusty Russell
19 Apr, 2009
1 commit
-
Fixes guest crash 'lguest: bad read address 0x4800000 len 256'
The new per-cpu allocator ends up handing a non-linear address to
write_gdt_entry. We do __pa() on it, and hand it to the host, which
kills us.I've long wanted to make the hypercall "LOAD_GDT_ENTRY" to match the IDT
code, but had no pressing reason until now.Signed-off-by: Rusty Russell
Cc: lguest@ozlabs.org
30 Mar, 2009
1 commit
-
Impact: clean up
Rusty told me, some time ago, that he had become a fan of "bool".
So, here are some replacements.Signed-off-by: Matias Zabaljauregui
Signed-off-by: Rusty Russell
30 Dec, 2008
1 commit
-
This patch moves the initial guest page table creation code to the host,
so the launcher keeps working with PAE enabled configs.Signed-off-by: Matias Zabaljauregui
Signed-off-by: Rusty Russell
27 May, 2008
1 commit
-
Add pte_flags() to extract the flags from a pte. This is a special
case of pte_val() which is only guaranteed to return the pte's flags
correctly; the page number may be corrupted or missing.The intent is to allow paravirt implementations to return pte flags
without having to do any translation of the page number (most notably,
Xen).Signed-off-by: Jeremy Fitzhardinge
Signed-off-by: Thomas Gleixner
19 Apr, 2008
1 commit
-
None of these files use any of the functionality promised by
asm/semaphore.h. It's possible that they rely on it dragging in some
unrelated header file, but I can't build all these files, so we'll have
fix any build failures as they come up.Signed-off-by: Matthew Wilcox
30 Jan, 2008
16 commits
-
explicitly use ktime.h include
explicitly use hrtimer.h include
explicitly use sched.h includeThis patch adds headers explicitly to lguest sources file,
to avoid depending on them being included somewhere else.Signed-off-by: Glauber de Oliveira Costa
Signed-off-by: Rusty Russell -
We can save some lines of code by getting rid of
*lg = cpu... lines of code spread everywhere by now.Signed-off-by: Glauber de Oliveira Costa
Signed-off-by: Rusty Russell -
events represented in the 'changed' bitmap are per-cpu, not per-guest.
move it to the lg_cpu structureSigned-off-by: Glauber de Oliveira Costa
Signed-off-by: Rusty Russell -
in our new model, pages are assigned to a virtual cpu, not to a guest.
We move it to the lg_cpu structure.Signed-off-by: Glauber de Oliveira Costa
Signed-off-by: Rusty Russell -
this patch makes the pgdir management per-vcpu. The pgdirs pool
is still guest-wide (although it'll probably need to grow when we
are really executing more vcpus), but the pgdidx index is gone,
since it makes no sense anymore. Instead, we use a per-vcpu
index.Signed-off-by: Glauber de Oliveira Costa
Signed-off-by: Rusty Russell -
this patch makes the pending_notify field, used to control
pending notifications, per-vcpu, instead of per-guestSigned-off-by: Glauber de Oliveira Costa
Signed-off-by: Rusty Russell -
lguest struct have room for some fields, namely, cr2, ts, esp1
and ss1, that are not really guest-wide, but rather, vcpu-wide.This patch puts it in the vcpu struct
Signed-off-by: Glauber de Oliveira Costa
Signed-off-by: Rusty Russell -
lguest uses tasks to control its running behaviour (like sending
breaks, controlling halted state, etc). In a per-vcpu environment,
each vcpu will have its own underlying task. So this patch
makes the infrastructure for that possibleSigned-off-by: Glauber de Oliveira Costa
Signed-off-by: Rusty Russell -
The fields found in lguest_arch are not really per-guest,
but per-cpu (gdt, idt, etc). So this patch turns lguest_arch
into lg_cpu_arch.It makes sense to have a per-guest per-arch struct, but this
can be addressed later, when the need arrives.Signed-off-by: Glauber de Oliveira Costa
Signed-off-by: Rusty Russell -
This is the most obvious per-vcpu field: registers.
So this patch moves it from struct lguest to struct vcpu,
and patch the places in which they are used, accordinglySigned-off-by: Glauber de Oliveira Costa
Signed-off-by: Rusty Russell -
The switcher needs to be mapped per-vcpu, because different vcpus
will potentially have different page tables (they don't have to,
because threads will share the same).So our first step is the make the function receive a vcpu struct
Signed-off-by: Glauber de Oliveira Costa
Signed-off-by: Rusty Russell -
This patch adapts interrupt processing for using the vcpu struct.
Signed-off-by: Glauber de Oliveira Costa
Signed-off-by: Rusty Russell -
Here, I introduce per-vcpu timers. With this, we can have
local expiries, needed for accounting time in smp guestsSigned-off-by: Glauber de Oliveira Costa
Signed-off-by: Rusty Russell -
this patch changes do_hcall() and do_async_hcall() interfaces (and obviously their
callers) to get a vcpu struct. Again, a vcpu services the hypercall, not the whole
guestSigned-off-by: Glauber de Oliveira Costa
Signed-off-by: Rusty Russell -
This patch makes the run_guest() routine use the lg_cpu struct.
This is required since in a smp guest environment, there's no
more the notion of "running the guest", but rather, it is "running the vcpu"Signed-off-by: Glauber de Oliveira Costa
Signed-off-by: Rusty Russell -
this patch introduces a vcpu struct for lguest. In upcoming patches,
more and more fields will be moved from the lguest struct to the vcpuSigned-off-by: Glauber de Oliveira Costa
Signed-off-by: Rusty Russell
25 Oct, 2007
2 commits
-
Went through the documentation doing typo and content fixes. This
patch contains only comment and whitespace changes.Signed-off-by: Rusty Russell
-
Signed-off-by: Rusty Russell
23 Oct, 2007
5 commits
-
Jes complains that page table code still uses lgread_u32 even though
it now uses general kernel pte types. The best thing to do is to
generalize lgread_u32 and lgwrite_u32.This means we lose the efficiency of getuser(). We could potentially
regain it if we used __copy_from_user instead of copy_from_user, but
I'm not certain that our range check is equivalent to access_ok() on
all platforms.Signed-off-by: Rusty Russell
Acked-by: Jes Sorensen -
This patch gets rid of the old lguest host I/O infrastructure and
replaces it with a single hypercall "LHCALL_NOTIFY" which takes an
address.The main change is the removal of io.c: that mainly did inter-guest
I/O, which virtio doesn't yet support.Signed-off-by: Rusty Russell
-
1) This allows us to get alot closer to booting bzImages.
2) It means we don't have to know page_offset.
3) The Guest needs to modify the boot pagetables to create the
PAGE_OFFSET mapping before jumping to C code.4) guest_pa() walks the page tables rather than using page_offset.
5) We don't use page_offset to figure out whether to emulate: it was
always kinda quesationable, and won't work for instructions done
before remapping (bzImage unpacking in particular).6) We still want the kernel address for tlb flushing: have the initial
hypercall give us that, too.Signed-off-by: Rusty Russell
-
(Based on Ron Minnich's LGUEST_PLAN9_SYSCALL patch).
This patch allows Guests to specify what system call vector they want,
and we try to reserve it. We only allow one non-Linux system call
vector, to try to avoid DoS on the Host.Signed-off-by: Rusty Russell
-
Signed-off-by: Rusty Russell