24 Apr, 2008

3 commits

  • sound/pci/rme9652/hdspm.c has unusually large number of static inline
    functions - 22.

    I looked through them and some of them seem to be too big to warrant inlining.

    This patch removes "inline" from these static functions (regardless of number
    of callsites - gcc nowadays auto-inlines statics with one callsite).

    Size difference on 32bit x86:
    text data bss dec hex filename
    20437 2160 516 23113 5a49 linux-2.6-ALLYES/sound/pci/rme9652/hdspm.o
    18036 2160 516 20712 50e8 linux-2.6.inline-ALLYES/sound/pci/rme9652/hdspm.o

    [coding fix by Takashi Iwai ]

    Signed-off-by: Denys Vlasenko
    Signed-off-by: Takashi Iwai

    Denys Vlasenko
     
  • Just drop the returns.
    sound/pci/rme9652/hdspm.c:1031:3: warning: returning void-valued expression
    sound/pci/rme9652/hdspm.c:1033:3: warning: returning void-valued expression

    Signed-off-by: Harvey Harrison
    Signed-off-by: Takashi Iwai

    Harvey Harrison
     
  • The bits indicating SPDIF frequency in the status register are not the same for
    the 9632 than for the other cards, because it also supports 192kHz. A specific
    bitmask has thus been added (used in hdsp_spdif_sample_rate()).
    The 9632 does not seem to report external sample rates greater than 96kHz. In
    this case, the best seems to report spdif rate when autosync reference is
    spdif. This also required to move function hdsp_spdif_sample_rate().

    Signed-off-by: Remy Bruno
    Signed-off-by: Takashi Iwai

    Remy Bruno
     

23 Feb, 2008

1 commit


01 Feb, 2008

6 commits


16 Oct, 2007

6 commits


20 Jul, 2007

1 commit


11 May, 2007

4 commits


06 Mar, 2007

1 commit


09 Feb, 2007

4 commits


20 Dec, 2006

3 commits


05 Oct, 2006

1 commit

  • Maintain a per-CPU global "struct pt_regs *" variable which can be used instead
    of passing regs around manually through all ~1800 interrupt handlers in the
    Linux kernel.

    The regs pointer is used in few places, but it potentially costs both stack
    space and code to pass it around. On the FRV arch, removing the regs parameter
    from all the genirq function results in a 20% speed up of the IRQ exit path
    (ie: from leaving timer_interrupt() to leaving do_IRQ()).

    Where appropriate, an arch may override the generic storage facility and do
    something different with the variable. On FRV, for instance, the address is
    maintained in GR28 at all times inside the kernel as part of general exception
    handling.

    Having looked over the code, it appears that the parameter may be handed down
    through up to twenty or so layers of functions. Consider a USB character
    device attached to a USB hub, attached to a USB controller that posts its
    interrupts through a cascaded auxiliary interrupt controller. A character
    device driver may want to pass regs to the sysrq handler through the input
    layer which adds another few layers of parameter passing.

    I've build this code with allyesconfig for x86_64 and i386. I've runtested the
    main part of the code on FRV and i386, though I can't test most of the drivers.
    I've also done partial conversion for powerpc and MIPS - these at least compile
    with minimal configurations.

    This will affect all archs. Mostly the changes should be relatively easy.
    Take do_IRQ(), store the regs pointer at the beginning, saving the old one:

    struct pt_regs *old_regs = set_irq_regs(regs);

    And put the old one back at the end:

    set_irq_regs(old_regs);

    Don't pass regs through to generic_handle_irq() or __do_IRQ().

    In timer_interrupt(), this sort of change will be necessary:

    - update_process_times(user_mode(regs));
    - profile_tick(CPU_PROFILING, regs);
    + update_process_times(user_mode(get_irq_regs()));
    + profile_tick(CPU_PROFILING);

    I'd like to move update_process_times()'s use of get_irq_regs() into itself,
    except that i386, alone of the archs, uses something other than user_mode().

    Some notes on the interrupt handling in the drivers:

    (*) input_dev() is now gone entirely. The regs pointer is no longer stored in
    the input_dev struct.

    (*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking. It does
    something different depending on whether it's been supplied with a regs
    pointer or not.

    (*) Various IRQ handler function pointers have been moved to type
    irq_handler_t.

    Signed-Off-By: David Howells
    (cherry picked from 1b16e7ac850969f38b375e511e3fa2f474a33867 commit)

    David Howells
     

23 Sep, 2006

1 commit

  • Fixed the auto-updating of firmware if the breakout box was switched
    off/on. The firmware binary itself was already cached but it wasn't
    loaded properly. Also, request_firmware() is issued if the box was
    with firmware at module loading time but later it's erased.
    The auto-update is triggered at each PCM action (open, prepare, etc)
    and at opening proc files.

    Signed-off-by: Takashi Iwai
    Signed-off-by: Jaroslav Kysela

    Takashi Iwai
     

13 Jul, 2006

1 commit


03 Jul, 2006

1 commit


23 Jun, 2006

4 commits


28 Apr, 2006

1 commit


29 Mar, 2006

1 commit


22 Mar, 2006

1 commit