Eric Lee / smarc-ti-linux-kernel

02 Dec, 2014

1 commit

  • ea0403603   CodingStyle: add some more error handling guidelines ... Browse Code »

    I added a paragraph on choosing label names, and updated the example
    code to use a better label name. I also cleaned up the example code to
    more modern style by moving the allocation out of the initializer and
    changing the NULL check.

    Perhaps the most common type of error handling bug in the kernel is "one
    err bugs". CodingStyle already says that we should "avoid nesting" by
    using error labels and one err style error handling tends to have
    multiple indent levels, so this was already bad style. But I've added a
    new paragraph explaining how to avoid one err bugs by using multiple
    error labels which is, hopefully, more clear.

    Signed-off-by: Dan Carpenter
    Acked-by: Julia Lawall
    [jc: added GFP_KERNEL to kmalloc() call]
    Signed-off-by: Jonathan Corbet

    Dan Carpenter
     

04 Nov, 2014

1 commit

26 Aug, 2014

1 commit

05 Jun, 2014

1 commit

  • 6e099f557   Documentation: expand/clarify debug documentation ... Browse Code »

    The pr_debug() and related debug print macros all differ from the normal
    pr_XXX() macros, in that the normal ones print unconditionally, while
    the debug macros are compiled out unless DEBUG is defined or
    CONFIG_DYNAMIC_DEBUG is set. This isn't obvious, and the only way to
    find this out is either to review the actual printk.h code or to read
    CodingStyle, and the message there doesn't highlight the fact.

    Change Documentation/CodingStyle to clearly indicate that pr_debug() and
    related debug printing macros behave differently than all other pr_XXX()
    macros, and attempt to clarify when and where the different debug
    printing methods might be used.

    Add short comment to printk.h above the pr_XXX() macros indicating that
    while these macros print unconditionally, pr_debug() does not.

    Signed-off-by: Dan Streetman
    Cc: Joe Perches
    Cc: Fabian Frederick
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Dan Streetman
     

04 Jul, 2013

1 commit

  • b57a0505e   Documentation/CodingStyle: allow multiple return statements per function ... Browse Code »

    A surprising number of newbies interpret this section to mean that only
    one return statement is allowed per function. Part of the problem is that
    the "one return statement per function" rule is an actual style guideline
    that people are used to from other projects.

    Signed-off-by: Dan Carpenter
    Cc: Eduardo Valentin
    Cc: Rob Landley
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Dan Carpenter
     

12 Jan, 2013

1 commit

  • 0335cb469   Documentation: remove depends on CONFIG_EXPERIMENTAL ... Browse Code »

    The CONFIG_EXPERIMENTAL config item has not carried much meaning for a
    while now and is almost always enabled by default. As agreed during the
    Linux kernel summit, remove it from any "depends on" lines in Kconfigs.

    CC: Rob Landley
    CC: Jiri Kosina
    CC: Masanari Iida
    CC: Jason Wessel
    CC: Richard L Maliszewski
    CC: Gang Wei
    CC: Shane Wang
    CC: Harry Wei
    Signed-off-by: Kees Cook
    Acked-by: Jason Wessel

    Kees Cook
     

06 Oct, 2012

1 commit

01 Jun, 2012

1 commit

31 Mar, 2012

1 commit

05 Nov, 2011

1 commit

  • b218ab0a5   Documentation: update CodingStyle use of braces ... Browse Code »

    After commit 38829dc9d7b4 ("Documentation/CodingStyle: flesh out if-else
    examples") highlight that if _only_one_ branch of a conditional
    statement is a single statement, then braces are to be used on both
    branches.

    Signed-off-by: Antonio Ospite
    Signed-off-by: Randy Dunlap
    Signed-off-by: Linus Torvalds

    Antonio Ospite
     

07 Aug, 2011

1 commit

07 Jul, 2011

1 commit

23 Mar, 2011

1 commit

  • 38829dc9d   Documentation/CodingStyle: flesh out if-else examples ... Browse Code »

    There is a missing case for "Chapter 3: Placing Braces and Spaces". We
    often know we should not use braces where a single statement. The first
    case is:

    if (condition)
    action();

    Another case is:

    if (condition)
    do_this();
    else
    do_that();

    However, I can not find a description of the second case.

    Signed-off-by: Harry Wei
    Cc: Randy Dunlap
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Harry Wei
     

17 Mar, 2011

1 commit

13 Jun, 2009

1 commit

30 Jan, 2009

2 commits

  • 70221395b   fix emacs indenting howto filename expansion ... Browse Code »

    I don't think emacs understands tilde expansion, so use
    "expand-file-name" to do that.

    Signed-off-by: Dan Carpenter
    Signed-off-by: Randy Dunlap
    Signed-off-by: Linus Torvalds

    Dan Carpenter
     
  • 0acbc6c65   Documentation: update CodingStyle tips for Emacs users ... Browse Code »

    With the previous Emacs tips example the kernel style was made available
    for files in the kernel-tree only. This patch updates the tip to add a
    separate cc-mode indent style ("linux-tabs-only"). This makes it easy to
    switch between different indent styles and also makes the kernel style
    easily available for any filetype mode (c++, awk, ...) that is managed
    by the Emacs cc-mode.

    Signed-off-by: Teemu Likonen
    Signed-off-by: Randy Dunlap
    Signed-off-by: Linus Torvalds

    Teemu Likonen
     

26 Jul, 2008

1 commit

17 Oct, 2007

1 commit

  • dff4982f5   CodingStyle: relax the 80-cole rule ... Browse Code »

    I would suggest this change to make CodingStyle properly reflect the style
    used by the kernel, rather than the current wording which is wishful
    thinking and misleading, and comes from the same school of thought that
    gets off on prescriptive grammar, latin and comp.std.c

    Signed-off-by: Alan Cox
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Alan Cox
     

19 Jul, 2007

1 commit

  • 6b09448ab   dev_vdbg() documentation ... Browse Code »

    Update CodingStyle to talk about "-DDEBUG" message conventions and the
    new "-DVERBOSE_DEBUG" convention.

    Signed-off-by: David Brownell
    Signed-off-by: Andrew Morton
    Signed-off-by: Greg Kroah-Hartman

    David Brownell
     

17 Jul, 2007

2 commits

24 May, 2007

1 commit

09 May, 2007

2 commits

23 Dec, 2006

1 commit

11 Dec, 2006

1 commit

  • b3fc9941f   [PATCH] CodingStyle updates ... Browse Code »

    Add some kernel coding style comments, mostly pulled from emails
    by Andrew Morton, Jesper Juhl, and Randy Dunlap.

    - add paragraph on switch/case indentation (with fixes)
    - add paragraph on multiple-assignments
    - add more on Braces
    - add section on Spaces; add typeof, alignof, & __attribute__ with sizeof;
    add more on postfix/prefix increment/decrement operators
    - add paragraph on function breaks in source files; add info on
    function prototype parameter names
    - add paragraph on EXPORT_SYMBOL placement
    - add section on /*-comment style, long-comment style, and data
    declarations and comments
    - correct some chapter number references that were missed when
    chapters were renumbered

    Signed-off-by: Randy Dunlap
    Acked-by: Jesper Juhl
    Acked-by: Jan Engelhardt
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Randy Dunlap
     

30 Sep, 2006

1 commit

  • c16a02d6f   [PATCH] Add section on function return values to CodingStyle ... Browse Code »

    This patch (as776) adds a new chapter to Documentation/CodingStyle,
    explaining the circumstances under which a function should return 0 for
    failure and non-zero for success as opposed to a negative error code for
    failure and 0 for success.

    Signed-off-by: Alan Stern
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Alan Stern
     

23 Jun, 2006

1 commit

11 Jan, 2006

1 commit

09 Jan, 2006

2 commits

18 Sep, 2005

1 commit

11 Sep, 2005

1 commit

17 Apr, 2005

1 commit

  • 1da177e4c   Linux-2.6.12-rc2 ... Browse Code »
    212

    Initial git repository build. I'm not bothering with the full history,
    even though we have it. We can create a separate "historical" git
    archive of that later if we want to, and in the meantime it's about
    3.2GB when imported into git - space that would just make the early
    git days unnecessarily complicated, when we don't have a lot of good
    infrastructure for it.

    Let it rip!

    Linus Torvalds