03 Oct, 2014

1 commit

• dab5aeebd   staging: vt6655: Fixed C99 // comment errors in wpactl.c ... Browse Code »

  The following patch fixes the checkpatch.pl warning:
  ERROR: do not use C99 // comments

  Signed-off-by: Esra Altintas
  Signed-off-by: Greg Kroah-Hartman

  Esra Altintas

  2014-10-03 01:11:26 +0800  

29 Sep, 2014

4 commits

• fd7dcd399   staging: vt6655: Merge three lines into one ... Browse Code »

  This patch merges three lines into one, removing unecessary
  if check.

  Signed-off-by: Tapasweni Pathak
  Reviewed-by: Himangi Saraogi
  Signed-off-by: Greg Kroah-Hartman

  Tapasweni Pathak

  2014-09-29 11:22:21 +0800  
• a793b2d81   staging: vt6655: Type conversion was made. ... Browse Code »

  This patch fixes this sparse warning:
  drivers/staging/vt6655/device_main.c:385:40: warning: mixing different enum types
  drivers/staging/vt6655/device_main.c:385:40: int enum _VIA_BB_TYPE versus
  drivers/staging/vt6655/device_main.c:385:40: int enum _VIA_PKT_TYPE

  Signed-off-by: Gulsah Kose
  Acked-by: Julia Lawall
  Signed-off-by: Greg Kroah-Hartman

  Gulsah Kose

  2014-09-29 11:22:21 +0800  
• 9e23c1b8c   Staging: vt6655: Add require space before that '(' ... Browse Code »

  This patch fixes checkpatch.pl error in file device_main.c
  ERROR: space required before the open parenthesis '('

  Signed-off-by: Aybuke Ozdemir
  Signed-off-by: Greg Kroah-Hartman

  Aybuke Ozdemir

  2014-09-29 11:22:21 +0800  
• 6e61b441c   Staging: vt6655: Add require space after that ',' ... Browse Code »

  This patch fixes checkpatch.pl error in file device_main.c
  ERROR: space required after that ';' (ctx:VxV)

  Signed-off-by: Aybuke Ozdemir
  Signed-off-by: Greg Kroah-Hartman

  Aybuke Ozdemir

  2014-09-29 11:22:21 +0800  

24 Sep, 2014

5 commits

• 46fa0ec0f   staging: vt6655: device_get_options remove unused variable devname ... Browse Code »

  Signed-off-by: Malcolm Priestley
  Signed-off-by: Greg Kroah-Hartman

  Malcolm Priestley

  2014-09-24 14:45:41 +0800  
• 42f709eff   staging: vt6655: pr_err remove string to net device name ... Browse Code »

  Just print driver name with dev_err removing the string formatting.

  Signed-off-by: Malcolm Priestley
  Signed-off-by: Greg Kroah-Hartman

  Malcolm Priestley

  2014-09-24 14:45:41 +0800  
• 78fc84848   staging: vt6655: shift open brace '{' to previous line ... Browse Code »

  This patch fixes checkpatch.pl error in baseband.c file
  ERROR : that open brace { should be on the previous line

  Signed-off-by: Tapasweni Pathak
  Signed-off-by: Greg Kroah-Hartman

  Tapasweni Pathak

  2014-09-24 04:41:15 +0800  
• cf329e54b   staging: vt6655: remove unnecessary else after return ... Browse Code »

  This patch fixes checkpatch.pl warning in aes_ccmp.c file
  WARNING : else is not generally useful after a break or return

  Signed-off-by: Tapasweni Pathak
  Signed-off-by: Greg Kroah-Hartman

  Tapasweni Pathak

  2014-09-24 04:41:15 +0800  
• fdeef1fe4   Staging: vt6655: Fix C99 style commenting. ... Browse Code »

  This patch fixes these error messages found by checkpatch.pl:
  ERROR: do not use C99 // comments

  Signed-off-by: Aybuke Ozdemir
  Signed-off-by: Greg Kroah-Hartman

  Aybuke Ozdemir

  2014-09-24 04:40:17 +0800  

22 Sep, 2014

1 commit

• d84a2b0d6   Merge 3.17-rc6 into staging-next. ... Browse Code »

  We want the fixes in there, and it resolves a merge issue with
  drivers/iio/accel/bma180.c

  Signed-off-by: Greg Kroah-Hartman

  Greg Kroah-Hartman

  2014-09-22 22:30:03 +0800  

20 Sep, 2014

3 commits

• 4309635f6   Staging: vt6655: Break 80 character long line to remove checkpatch error ... Browse Code »

  This removes checkpatch.pl warning
  WARNING: line over 80 characters

  Signed-off-by: Rajbinder Brar
  Signed-off-by: Greg Kroah-Hartman

  Rajbinder Brar

  2014-09-20 08:01:22 +0800  
• dbc6ee63d   Staging: vt6655: Fix C99 style commenting. ... Browse Code »

  This patch fixes these error messages found by checkpatch.pl:
  ERROR: do not use C99 // comments

  Signed-off-by: Aybuke Ozdemir
  Signed-off-by: Greg Kroah-Hartman

  Aybuke Ozdemir

  2014-09-20 08:01:22 +0800  
• ed87c2b2e   staging: vt6655: buffer overflow in ioctl ... Browse Code »

  ->u.generic_elem.len is a user controlled number between 0-255. We
  should limit it to avoid memory corruption.

  Signed-off-by: Dan Carpenter
  Signed-off-by: Greg Kroah-Hartman

  Dan Carpenter

  2014-09-20 06:32:20 +0800  

12 Sep, 2014

3 commits

• b4a814d4a   staging: vt6655: Remove unnecessary condition around include ... Browse Code »

  ethtool (and SIOCETHTOOL in particular) is part of Linux since the
  pre-git era, it thus makes no sense no sense to make the include of
  linux/ethtool.h conditional. Also remove the unused define
  DEVICE_ETHTOOL_IOCTL_SUPPORT.

  Signed-off-by: Tobias Klauser
  Signed-off-by: Greg Kroah-Hartman

  Tobias Klauser

  2014-09-12 05:59:18 +0800  
• 22981e0e5   staging: vt6655: Use net_device_stats from struct net_device ... Browse Code »

  Instead of using an own copy of struct net_device_stats in struct
  vnt_private, use stats from struct net_device. Also remove the thus
  unnecessary device_get_stats(), as it would now just return
  netdev->stats, which is the default in dev_get_stats().

  Signed-off-by: Tobias Klauser
  Signed-off-by: Greg Kroah-Hartman

  Tobias Klauser

  2014-09-12 05:59:18 +0800  
• 46ef6886a   staging: vt6655: Remove unused member from struct vnt_private ... Browse Code »

  The pci_state member of struct vnt_private is used nowhere in the code,
  so remove it. Supposedly it was used to save the PCI configuration space
  which is now done using pci_save_state().

  Signed-off-by: Tobias Klauser
  Signed-off-by: Greg Kroah-Hartman

  Tobias Klauser

  2014-09-12 05:56:51 +0800  

09 Sep, 2014

1 commit

• c72f65ccc   staging: vt6655: device_free_info() warn: variable dereferenced before check ... Browse Code »

  pDevice is never NULL when this function is called remove the check.

  This fixes smatch warning
  drivers/staging/vt6655/device_main.c:1023 device_free_info() warn: variable dereferenced
  before check 'pDevice' (see line 1021)

  Reported-by: Dan Carpenter
  Cc: kbuild@01.org
  Signed-off-by: Malcolm Priestley
  Signed-off-by: Greg Kroah-Hartman

  Malcolm Priestley

  2014-09-09 05:01:17 +0800  

31 Aug, 2014

22 commits

• a98736734   staging: vt6655: Replace typedef enum _CARD_OP_MODE eOPMode with enum nl80211_iftype op_mode. ... Browse Code »

  Using the nl80211 header.

  Using enum changes
  OP_MODE_ADHOC -> NL80211_IFTYPE_ADHOC
  OP_MODE_AP -> NL80211_IFTYPE_AP
  OP_MODE_INFRASTRUCTURE -> NL80211_IFTYPE_STATION
  OP_MODE_UNKNOWN -> NL80211_IFTYPE_UNSPECIFIED

  Signed-off-by: Malcolm Priestley
  Signed-off-by: Greg Kroah-Hartman

  Malcolm Priestley

  2014-08-31 06:19:17 +0800  
• 96372bd9b   staging: vt6655: s_uGetRTSCTSDuration always return __le16 ... Browse Code »

  This function should always return __le16, move all endian
  correction to here.

  Signed-off-by: Malcolm Priestley
  Signed-off-by: Greg Kroah-Hartman

  Malcolm Priestley

  2014-08-31 06:19:17 +0800  
• 933202589   stgaing: vt6655: remove unused variable wCTSDuration ... Browse Code »

  wCTSDuration is always set to 0.

  Signed-off-by: Malcolm Priestley
  Signed-off-by: Greg Kroah-Hartman

  Malcolm Priestley

  2014-08-31 06:19:17 +0800  
• db1afd18e   staging: vt6655: replace typedef struct tagSCTS_FB with struct vnt_cts_fb ... Browse Code »

  Replacing members
  b, wDuration_ba, wReserved, wCTSDuration_ba_f0, wCTSDuration_ba_f1, data and
  reserved2.

  With
  b, duration_ba, reserved, cts_duration_ba_f0, cts_duration_ba_f1, data and
  reserved2

  unsigned short is replaced with u16 or __le16 where necessary.

  cast void pointer to pvCTS

  Creating the new structure in rxtx.h

  Signed-off-by: Malcolm Priestley
  Signed-off-by: Greg Kroah-Hartman

  Malcolm Priestley

  2014-08-31 06:19:17 +0800  
• f5172b0ed   staging: vt6655: replace typedef struct tagSCTS with struct vnt_cts ... Browse Code »

  Replacing members
  b, wDuration_ba, wReserved, data and reserved2
  with
  b, duration_ba, reserved, data and reserved2

  unsigned short is replaced with u16 or __le16 where necessary.

  cast void pointer to pvCTS

  Creating the new structure in rxtx.h

  Signed-off-by: Malcolm Priestley
  Signed-off-by: Greg Kroah-Hartman

  Malcolm Priestley

  2014-08-31 06:19:16 +0800  
• 8e44804e7   staging: vt6655: replace typedef struct tagSRTS_a_FB with struct vnt_rts_a_fb ... Browse Code »

  Replacing members
  a, wDuration, wReserved, wRTSDuration_f0, wRTSDuration_f1 and data
  with
  a, duration, reserved, rts_duration_f0, rts_duration_f1 and data

  unsigned short is replaced with u16 or __le16 where necessary.

  cast void pointer to pvRTS

  Creating the new structure in rxtx.h

  Signed-off-by: Malcolm Priestley
  Signed-off-by: Greg Kroah-Hartman

  Malcolm Priestley

  2014-08-31 06:19:16 +0800  
• e21eb1c8d   staging: vt6655: replace typedef struct tagSRTS_ab with struct vnt_rts_ab ... Browse Code »

  Replacing members
  ab, wDuration, wReserved and data

  with

  ab, duration, reserved and data

  replacing unsigned short with u16 and __le16 where necessary.

  pvRTS is void pointer.

  Creating the new structure in rxtx.h

  Signed-off-by: Malcolm Priestley
  Signed-off-by: Greg Kroah-Hartman

  Malcolm Priestley

  2014-08-31 06:19:16 +0800  
• 9587b0920   staging: vt6655: replace typedef struct tagSRTS_g_FB with struct vnt_rts_g_fb ... Browse Code »

  Replacing members
  b, a, wDuration_ba, wDuration_aa, wDuration_bb, wReserved, wRTSDuration_ba_f0,
  wRTSDuration_aa_f0, wRTSDuration_ba_f1, wRTSDuration_aa_f1 and data

  with

  b, a, duration_ba, duration_aa, duration_bb, wReserved, rts_duration_ba_f0,
  rts_duration_aa_f0, rts_duration_ba_f1, rts_duration_aa_f1 and data

  replacing unsigned short with u16 or __le16 where endian correction is necessary.

  Creating the new structure in rxtx.h

  Signed-off-by: Malcolm Priestley
  Signed-off-by: Greg Kroah-Hartman

  Malcolm Priestley

  2014-08-31 06:19:16 +0800  
• 17434f094   staging: vt6655: replace typedef struct tagSRTS_g with struct vnt_rts_g ... Browse Code »

  Replacing members
  b, a, wDuration_ba, wDuration_aa, wDuration_bb, wReserved and data
  with
  b, a,duration_ba, duration_aa, duration_bb, reserved and data

  replacing unsigned short with u16 or __le16 where endian correction is necessary.

  Creating the new structure in rxtx.h

  Signed-off-by: Malcolm Priestley
  Signed-off-by: Greg Kroah-Hartman

  Malcolm Priestley

  2014-08-31 06:19:16 +0800  
• 0864db15a   staging: vt6655: Replace typedef struct tagSCTSData with ieee80211_cts data ... Browse Code »

  ieee80211_cts data needs extra padding with reserved2 set to 0

  use IEEE80211_FTYPE_CTL | IEEE80211_STYPE_CTS to set frame_control

  Signed-off-by: Malcolm Priestley
  Signed-off-by: Greg Kroah-Hartman

  Malcolm Priestley

  2014-08-31 06:19:16 +0800  
• 52c4130bd   staging: vt6655: Replace typedef struct tagSRTSData with ieee80211_rts data ... Browse Code »

  Replacing SRTSData Data with struct ieee80211_rts data

  Signed-off-by: Malcolm Priestley
  Signed-off-by: Greg Kroah-Hartman

  Malcolm Priestley

  2014-08-31 06:19:16 +0800  
• a479ffc38   staging: vt6655: Fix *Duration s_uFillDataHead to return to __le16 ... Browse Code »

  All callers should be __le16.

  Fix vGenerateMACHeader duration to __le16 and reverse the endian
  conversion.

  Signed-off-by: Malcolm Priestley
  Signed-off-by: Greg Kroah-Hartman

  Malcolm Priestley

  2014-08-31 06:19:16 +0800  
• 9c62c7abf   staging: vt6655: replace -typedef struct tagSTxDataHead_a_FB with struct vnt_tx_datahead_a_fb ... Browse Code »

  Replace members
  a, wDuration, wTimeStampOff, wDuration_f0, and wDuration_f1;
  with
  a, duration, time_stamp_off, duration_f0, duration_f1

  All unsigned short members should be __le16

  Creating the new structure in rxtx.h.

  Signed-off-by: Malcolm Priestley
  Signed-off-by: Greg Kroah-Hartman

  Malcolm Priestley

  2014-08-31 06:19:16 +0800  
• 9ce842ab3   staging: vt6655: replace typedef struct tagSTxDataHead_ab with struct vnt_tx_datahead_ab ... Browse Code »

  Replacing members
  ab, wDuration and wTimeStampOff

  with
  ab, duration and time_stamp_off

  All unsigned short should be __le16

  Structure is moved to rxtx.h

  Signed-off-by: Malcolm Priestley
  Signed-off-by: Greg Kroah-Hartman

  Malcolm Priestley

  2014-08-31 06:19:16 +0800  
• 2dd76679c   staging: vt6655: replace typedef struct tagSTxDataHead_g_FB with struct vnt_tx_datahead_g_fb ... Browse Code »

  Replacing members
  b, a, wDuration_b, wDuration_a, wDuration_a_f0, wDuration_a_f1, wTimeStampOff_b and wTimeStampOff_a
  with
  b, a, duration_b, duration_a, duration_a_f0, duration_a_f1, time_stamp_off_b and time_stamp_off_a

  All unsigned short need to be __le16 type.

  Creating the new structure in rxtx.h

  Signed-off-by: Malcolm Priestley
  Signed-off-by: Greg Kroah-Hartman

  Malcolm Priestley

  2014-08-31 06:19:16 +0800  
• 72edb7ed1   staging: vt6655: replace typedef struct tagSTxDataHead_g with struct vnt_tx_datahead_g ... Browse Code »

  Replace members
  b, a, wDuration_b, wDuration_a, wTimeStampOff_b and wTimeStampOff_a
  with
  b, a, duration_b, duration_a, time_stamp_off_b and time_stamp_off_a

  Using __le16 endian type for unsigned short.

  Creating the new structure in rxtx.h

  Signed-off-by: Malcolm Priestley
  Signed-off-by: Greg Kroah-Hartman

  Malcolm Priestley

  2014-08-31 06:19:16 +0800  
• d6b95c065   staging: vt6655: rxtx.c create function to return __le16 wTimeStampOff ... Browse Code »

  wTimeStampOff always needs to be endian corrected.

  Create vnt_time_stamp_off to return this value.

  Signed-off-by: Malcolm Priestley
  Signed-off-by: Greg Kroah-Hartman

  Malcolm Priestley

  2014-08-31 06:19:16 +0800  
• c00a378bf   staging: vt6655: s_vGenerateTxParameter removed nested pvRrvTime NULL check ... Browse Code »

  Just do single NULL check on pvRrvTime and return.

  If pvRrvTime is NULL none of the if statements are valid.

  Signed-off-by: Malcolm Priestley
  Signed-off-by: Greg Kroah-Hartman

  Malcolm Priestley

  2014-08-31 06:19:15 +0800  
• 853532d3b   staging: vt6655: rxtx change s_uGetRTSCTSRsvTime to always return __le16 ... Browse Code »

  s_uGetRTSCTSRsvTime always needs to return little endian __le16

  Signed-off-by: Malcolm Priestley
  Signed-off-by: Greg Kroah-Hartman

  Malcolm Priestley

  2014-08-31 06:19:15 +0800  
• e7a3481b7   staging: vt6655: create vnt_rxtx_rsvtime_le16 to return s_uGetTxRsvTime endian corrected. ... Browse Code »

  Replace s_uGetTxRsvTime where endian correction is needed.

  Signed-off-by: Malcolm Priestley
  Signed-off-by: Greg Kroah-Hartman

  Malcolm Priestley

  2014-08-31 06:19:15 +0800  
• f6a634c3d   staging: vt6655: rxtx replace typedef struct tagSRrvTime_ab with struct vnt_rrv_time_ab ... Browse Code »

  Replacing members
  wRTSTxRrvTime and wTxRrvTime
  with
  rts_rrv_time and rrv_time

  using __le16 type

  Moving structure to rxtx.h

  pvRrvTime is a void pointer

  Signed-off-by: Malcolm Priestley
  Signed-off-by: Greg Kroah-Hartman

  Malcolm Priestley

  2014-08-31 06:19:15 +0800  
• d66a5a746   staging: vt6655: rxtx replace typedef struct tagSRrvTime_gCTS with struct vnt_rrv_time_cts ... Browse Code »

  replacing members
  wCTSTxRrvTime_ba, wReserved, wTxRrvTime_b and wTxRrvTime_a
  with
  cts_rrv_time_ba, reserved, rrv_time_b and rrv_time_a;

  Creating the new structure in rxtx.h and Using __le16 where necessary

  pvRrvTime is a void pointer

  Signed-off-by: Malcolm Priestley
  Signed-off-by: Greg Kroah-Hartman

  Malcolm Priestley

  2014-08-31 06:19:15 +0800