27 Aug, 2014

1 commit


04 Mar, 2014

1 commit

  • Convert 1 char * array to 2 char arrays to reduce size.
    Use static const to avoid array reloads on function entry.
    Fix asymmetric typo.

    $ size drivers/usb/misc/sisusbvga/sisusb.o*
    text data bss dec hex filename
    29971 4841 9180 43992 abd8 drivers/usb/misc/sisusbvga/sisusb.o.new
    30083 4841 9180 44104 ac48 drivers/usb/misc/sisusbvga/sisusb.o.old

    Signed-off-by: Joe Perches
    Signed-off-by: Greg Kroah-Hartman

    Joe Perches
     

09 Jan, 2014

1 commit


23 Jul, 2013

1 commit


04 Jul, 2013

1 commit

  • Pull "exotic" arch fixes from Geert Uytterhoeven:
    "This is a collection of several exotic architecture fixes, and a few
    other fixes for issues that were detected while doing the former"

    * 'exotic-arch-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/geert/linux-m68k: (35 commits)
    lib: Move fonts from drivers/video/console/ to lib/fonts/
    console/font: Refactor font support code selection logic
    Revert "staging/solo6x10: depend on CONFIG_FONTS"
    input: cros_ec_keyb_clear_keyboard() depends on CONFIG_PM_SLEEP
    score: Wire up asm-generic/xor.h
    score: Remove unneeded
    openrisc: Wire up asm-generic/xor.h
    h8300/boot: Use POSIX "$((..))" instead of bashism "$[...]"
    h8300: Mark H83002 and H83048 CPU support broken
    h8300: Switch h8300 to drivers/Kconfig
    h8300: Limit timer channel ranges in Kconfig
    h8300: Wire up asm-generic/xor.h
    h8300: Fill the system call table using a CALL() macro
    h8300: Fix
    h8300: Hardcode symbol prefixes in asm sources
    h8300: add missing definition for read_barries_depends()
    frv: head.S - Remove commented-out initialization code
    cris: Wire up asm-generic/vga.h
    parport: disable PC-style parallel port support on cris
    console: Disable VGA text console support on cris
    ...

    Linus Torvalds
     

23 Jun, 2013

1 commit

  • The current Makefile rules to build font support are messy and buggy.
    Replace them by Kconfig rules:
    - Introduce CONFIG_FONT_SUPPORT, which controls the building of all font
    code,
    - Select CONFIG_FONT_SUPPORT for all drivers that use fonts,
    - Select CONFIG_FONT_8x16 for all drivers that default to the VGA8x16
    font,
    - Drop the bogus console dependency for CONFIG_VIDEO_VIVI,
    - Always process drivers/video/console/Makefile, as some drivers need
    fonts even if CONFIG_VT is not set.

    This fixes (if CONFIG_SOLO6X10=y and there are no built-in console
    drivers):

    drivers/built-in.o: In function `solo_osd_print':
    drivers/staging/media/solo6x10/solo6x10-enc.c:144: undefined reference to `.find_font'

    This fixes (if CONFIG_VT=n):

    drivers/built-in.o: In function `vivi_init':
    vivi.c:(.init.text+0x1a3da): undefined reference to `find_font'

    Signed-off-by: Geert Uytterhoeven
    Acked-by: Hans Verkuil [original part]
    Acked-by: Randy Dunlap [drivers/video/Makefile]

    Geert Uytterhoeven
     

21 May, 2013

1 commit

  • Impact:
    1:convert all remain take_over_console to do_take_over_console
    2:update take_over_console to do_take_over_console in comment

    Commit dc9641895abb ("vt: delete unneeded functions
    register_con_driver|take_over_console") delete take_over_console,
    but forget to convert remain take_over_console's users to new API
    do_take_over_console, this patch fix it.

    Reported-by: Stephen Rothwell
    Signed-off-by: Wang YanQing
    Signed-off-by: Greg Kroah-Hartman

    Wang YanQing
     

10 Apr, 2013

1 commit

  • This patch removes the depends on USB from all config symbols in
    drivers/usb/host/Kconfig and replace that with an if USB / endif block
    as suggested by Alan Stern. Some source ... Kconfig lines have been
    shuffled around to permit a better regroupment of the Kconfig files
    depending on "config USB" item. No functionnal change is introduced.

    Acked-by: Alan Stern
    Signed-off-by: Florian Fainelli
    Signed-off-by: Greg Kroah-Hartman

    Florian Fainelli
     

16 Mar, 2013

1 commit

  • A failed kzalloc() is reported with a dev_err that dereferences the null
    sisusb, this will cause a NULL pointer deference error.

    Instead, pass dev->dev to the dev_err() rather than &sisusb->sisusb_dev->dev

    Smatch analysis:

    drivers/usb/misc/sisusbvga/sisusb.c:3087 sisusb_probe() error: potential null
    dereference 'sisusb'. (kzalloc returns null)

    Signed-off-by: Colin Ian King
    Signed-off-by: Greg Kroah-Hartman

    Colin Ian King
     

11 Nov, 2010

1 commit


23 Oct, 2010

1 commit

  • For all modules, change -objs to -y; remove
    if-statements and replace with lists using the kbuild idiom; move
    flags to the top of the file; and fix alignment while trying to
    maintain the original scheme in each file.

    None of the dependencies are modified.

    Signed-off-by: matt mooney
    Acked-by: Sam Ravnborg
    Acked-by: Felipe Balbi
    Signed-off-by: Greg Kroah-Hartman

    matt mooney
     

11 Aug, 2010

1 commit


27 Jul, 2010

1 commit


21 May, 2010

3 commits


30 Mar, 2010

1 commit

  • …it slab.h inclusion from percpu.h

    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files. percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.

    percpu.h -> slab.h dependency is about to be removed. Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability. As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.

    http://userweb.kernel.org/~tj/misc/slabh-sweep.py

    The script does the followings.

    * Scan files for gfp and slab usages and update includes such that
    only the necessary includes are there. ie. if only gfp is used,
    gfp.h, if slab is used, slab.h.

    * When the script inserts a new include, it looks at the include
    blocks and try to put the new include such that its order conforms
    to its surrounding. It's put in the include block which contains
    core kernel includes, in the same order that the rest are ordered -
    alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
    doesn't seem to be any matching order.

    * If the script can't find a place to put a new include (mostly
    because the file doesn't have fitting include block), it prints out
    an error message indicating which .h file needs to be added to the
    file.

    The conversion was done in the following steps.

    1. The initial automatic conversion of all .c files updated slightly
    over 4000 files, deleting around 700 includes and adding ~480 gfp.h
    and ~3000 slab.h inclusions. The script emitted errors for ~400
    files.

    2. Each error was manually checked. Some didn't need the inclusion,
    some needed manual addition while adding it to implementation .h or
    embedding .c file was more appropriate for others. This step added
    inclusions to around 150 files.

    3. The script was run again and the output was compared to the edits
    from #2 to make sure no file was left behind.

    4. Several build tests were done and a couple of problems were fixed.
    e.g. lib/decompress_*.c used malloc/free() wrappers around slab
    APIs requiring slab.h to be added manually.

    5. The script was run on all .h files but without automatically
    editing them as sprinkling gfp.h and slab.h inclusions around .h
    files could easily lead to inclusion dependency hell. Most gfp.h
    inclusion directives were ignored as stuff from gfp.h was usually
    wildly available and often used in preprocessor macros. Each
    slab.h inclusion directive was examined and added manually as
    necessary.

    6. percpu.h was updated not to include slab.h.

    7. Build test were done on the following configurations and failures
    were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
    distributed build env didn't work with gcov compiles) and a few
    more options had to be turned off depending on archs to make things
    build (like ipr on powerpc/64 which failed due to missing writeq).

    * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
    * powerpc and powerpc64 SMP allmodconfig
    * sparc and sparc64 SMP allmodconfig
    * ia64 SMP allmodconfig
    * s390 SMP allmodconfig
    * alpha SMP allmodconfig
    * um on x86_64 SMP allmodconfig

    8. percpu.h modifications were reverted so that it could be applied as
    a separate patch and serve as bisection point.

    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>

    Tejun Heo
     

03 Mar, 2010

3 commits

  • If a driver can wait on an event, it can also use GFP_KERNEL.

    Signed-off-by: Oliver Neukum
    Signed-off-by: Greg Kroah-Hartman

    Oliver Neukum
     
  • Straightforward push into the drivers to allow
    auditing individual drivers separately

    Signed-off-by: Oliver Neukum
    Acked-by: Mauro Carvalho Chehab
    Cc: Jiri Kosina
    Signed-off-by: Greg Kroah-Hartman

    Oliver Neukum
     
  • The id_table field of the struct usb_device_id is constant in
    so it is worth to make the initialization data also constant.

    The semantic match that finds this kind of pattern is as follows:
    (http://coccinelle.lip6.fr/)

    //
    @r@
    disable decl_init,const_decl_init;
    identifier I1, I2, x;
    @@
    struct I1 {
    ...
    const struct I2 *x;
    ...
    };
    @s@
    identifier r.I1, y;
    identifier r.x, E;
    @@
    struct I1 y = {
    .x = E,
    };
    @c@
    identifier r.I2;
    identifier s.E;
    @@
    const struct I2 E[] = ... ;
    @depends on !c@
    identifier r.I2;
    identifier s.E;
    @@
    + const
    struct I2 E[] = ...;
    //

    Signed-off-by: Németh Márton
    Cc: Julia Lawall
    Cc: cocci@diku.dk
    Signed-off-by: Greg Kroah-Hartman

    Németh Márton
     

17 Feb, 2010

1 commit


27 Sep, 2009

1 commit

  • * remove asm/atomic.h inclusion from kref.h -- not needed, linux/types.h
    is enough for atomic_t
    * remove linux/kref.h inclusion from files which do not need it.

    Signed-off-by: Alexey Dobriyan
    Signed-off-by: Linus Torvalds

    Alexey Dobriyan
     

23 Sep, 2009

1 commit

  • This patch falls out of my work to fix usbmon so it uses virtual addresses.
    It is not necessary, the "new" usbmon should work just fine with sisusbvga.
    However, it seems ridiculous that anyone would use uncached memory to
    transfer bulk data. Dropping the unnecessary use of usb_buffer_alloc
    should be beneficial here, in case anyone ever uses the dongle on
    anything beyond x86.

    I had no success in raising the author of the driver by e-mail, so
    the patch is not actually tested.

    Signed-off-by: Pete Zaitcev
    Signed-off-by: Greg Kroah-Hartman

    Pete Zaitcev
     

16 Jun, 2009

1 commit


14 Nov, 2008

1 commit


22 Aug, 2008

1 commit

  • sisusbvga: add USB ID for 0711:0918 Magic Control Technology Corp.

    usb 1-2: new high speed USB device using ehci_hcd and address 4
    usb 1-2: configuration #1 chosen from 1 choice
    usb 1-2: USB2VGA dongle found at address 4
    usb 1-2: Allocated 8 output buffers
    usb 1-2: 8MB 1 ch/1 r SDR SDRAM, bus width 32
    usb 1-2: New USB device found, idVendor=0711, idProduct=0918
    usb 1-2: New USB device strings: Mfr=0, Product=0, SerialNumber=0

    Signed-off-by: Stefan Lippers-Hollmann
    Signed-off-by: Greg Kroah-Hartman

    Stefan Lippers-Hollmann
     

22 Jul, 2008

1 commit


04 Jul, 2008

1 commit

  • Remove dev_info call on disconnect. The sisusb_dev pointer may have been
    set to zero by sisusb_delete at this point causing an oops.

    The message does not provide any extra information over the standard USB
    subsystem output so removing it does not affect functionality.

    Signed-off-by: Will Newton
    Signed-off-by: Greg Kroah-Hartman

    Will Newton
     

02 Feb, 2008

2 commits


17 Oct, 2007

1 commit

  • Various console drivers are able to resize the screen via the con_resize()
    hook. This hook is also visible in userspace via the TIOCWINSZ, VT_RESIZE and
    VT_RESIZEX ioctl's. One particular utility, SVGATextMode, expects that
    con_resize() of the VGA console will always return success even if the
    resulting screen is not compatible with the hardware. However, this
    particular behavior of the VGA console, as reported in Kernel Bugzilla Bug
    7513, can cause undefined behavior if the user starts with a console size
    larger than 80x25.

    To work around this problem, add an extra parameter to con_resize(). This
    parameter is ignored by drivers except for vgacon. If this parameter is
    non-zero, then the resize request came from a VT_RESIZE or VT_RESIZEX ioctl
    and vgacon will always return success. If this parameter is zero, vgacon will
    return -EINVAL if the requested size is not compatible with the hardware. The
    latter is the more correct behavior.

    With this change, SVGATextMode should still work correctly while in-kernel and
    stty resize calls can expect correct behavior from vgacon.

    Signed-off-by: Antonino Daplas
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Antonino A. Daplas
     

13 Oct, 2007

9 commits