09 Jan, 2014
1 commit
-
None of these files are actually using any __init type directives
and hence don't need to include . Most are just a
left over from __devinit and __cpuinit removal, or simply due to
code getting copied from one driver to the next.Signed-off-by: Paul Gortmaker
Signed-off-by: Greg Kroah-Hartman
04 Jan, 2014
2 commits
-
Remove redundant error messages on allocation failures, which have
already been logged.Cc: Joe Perches
Signed-off-by: Johan Hovold
Signed-off-by: Greg Kroah-Hartman -
Declare device-id tables as const where possible.
Signed-off-by: Johan Hovold
Signed-off-by: Greg Kroah-Hartman
29 May, 2013
2 commits
-
Fix regression introduced by commit 214916f2e ("USB: visor: reimplement
using generic framework") which broke initialisation of Treo/Kyocera
devices that re-mapped bulk-in endpoints.Cc: stable@vger.kernel.org
Signed-off-by: Johan Hovold
Signed-off-by: Greg Kroah-Hartman -
The first and second interrupt-in urbs are swapped for some Treo/Kyocera
devices, but the urb context was never updated with the new port.Cc: stable@vger.kernel.org
Signed-off-by: Johan Hovold
Signed-off-by: Greg Kroah-Hartman
26 Mar, 2013
1 commit
-
Always try to disable the uart on close.
Since the switch to tty ports, close will be called as part of shutdown
before disconnect returns. Hence there is no need to check the
disconnected flag, and we can put devices in disabled states also on
driver unbind.Signed-off-by: Johan Hovold
Signed-off-by: Greg Kroah-Hartman
18 Sep, 2012
2 commits
-
Now that all usb-serial modules are only using dev_dbg()
the debug module parameter does not do anything at all, so
remove it to reduce any confusion if someone were to try to
use it.CC: Rusty Russell
CC: Alan Stern
CC: Mauro Carvalho Chehab
Signed-off-by: Greg Kroah-Hartman -
We should use dev_dbg() for usb_serial_debug_data() like all of the rest
of the usb-serial drivers use, so remove the debug parameter as it's not
needed.Signed-off-by: Greg Kroah-Hartman
09 May, 2012
1 commit
-
This reworks the usb_serial_register_drivers() and
usb_serial_deregister_drivers() to not need a pointer to a struct
usb_driver anymore. The usb_driver structure is now created dynamically
and registered and unregistered as needed.This saves lines of code in each usb-serial driver. All in-kernel users
of these functions were also fixed up at this time. The pl2303 driver
was tested that everything worked properly.Thanks for the idea to do this from Alan Stern.
Cc: Adhir Ramjiawan
Cc: Alan Stern
Cc: Al Borchers
Cc: Aleksey Babahin
Cc: Andrew Morton
Cc: Andrew Worsley
Cc: Bart Hartgers
Cc: Bill Pemberton
Cc: Dan Carpenter
Cc: Dan Williams
Cc: Donald Lee
Cc: Eric Dumazet
Cc: "Eric W. Biederman"
Cc: Felipe Balbi
Cc: Gary Brubaker
Cc: Jesper Juhl
Cc: Jiri Kosina
Cc: Johan Hovold
Cc: Julia Lawall
Cc: Kautuk Consul
Cc: Kuninori Morimoto
Cc: Lonnie Mendez
Cc: Matthias Bruestle and Harald Welte
Cc: Matthias Urlichs
Cc: Mauro Carvalho Chehab
Cc: Michal Sroczynski
Cc: "Michał Wróbel"
Cc: Oliver Neukum
Cc: Paul Gortmaker
Cc: Peter Berger
Cc: Preston Fick
Cc: "Rafael J. Wysocki"
Cc: Rigbert Hamisch
Cc: Rusty Russell
Cc: Simon Arlott
Cc: Support Department
Cc: Thomas Tuttle
Cc: Uwe Bonnes
Cc: Wang YanQing
Cc: William Greathouse
Signed-off-by: Greg Kroah-Hartman
08 May, 2012
2 commits
-
This is now set by the usb-serial core, no need for the driver to
individually set it.Thanks to Alan Stern for the idea to get rid of it.
Cc: William Greathouse
Cc: Matthias Bruestle and Harald Welte
Cc: Lonnie Mendez
Cc: Peter Berger
Cc: Al Borchers
Cc: Gary Brubaker
Cc: Oliver Neukum
Cc: Matthias Urlichs
Cc: Support Department
Cc: Rusty Russell
Cc: Alan Stern
Cc: Mauro Carvalho Chehab
Cc: Kautuk Consul
Cc: Bill Pemberton
Cc: Paul Gortmaker
Cc: Bart Hartgers
Cc: Johan Hovold
Cc: Preston Fick
Cc: Uwe Bonnes
Cc: Simon Arlott
Cc: Andrew Worsley
Cc: "Michał Wróbel"
Cc: Andrew Morton
Cc: Eric Dumazet
Cc: "Eric W. Biederman"
Cc: Felipe Balbi
Cc: Aleksey Babahin
Cc: Dan Carpenter
Cc: Jiri Kosina
Cc: Donald Lee
Cc: Julia Lawall
Cc: Michal Sroczynski
Cc: Wang YanQing
Cc: Dan Williams
Cc: Thomas Tuttle
Cc: Rigbert Hamisch
Cc: "Rafael J. Wysocki"
Cc: Kuninori Morimoto
Cc: Jesper Juhl
Cc: Adhir Ramjiawan
Signed-off-by: Greg Kroah-Hartman -
This is now set by the usb-serial core, no need for the driver to
individually set it.Thanks to Alan Stern for the idea to get rid of it.
Cc: William Greathouse
Cc: Matthias Bruestle and Harald Welte
Cc: Lonnie Mendez
Cc: Peter Berger
Cc: Al Borchers
Cc: Gary Brubaker
Cc: Oliver Neukum
Cc: Matthias Urlichs
Cc: Support Department
Cc: Rusty Russell
Cc: Alan Stern
Cc: Mauro Carvalho Chehab
Cc: Kautuk Consul
Cc: Bill Pemberton
Cc: Paul Gortmaker
Cc: Bart Hartgers
Cc: Johan Hovold
Cc: Preston Fick
Cc: Uwe Bonnes
Cc: Simon Arlott
Cc: Andrew Worsley
Cc: "Michał Wróbel"
Cc: Andrew Morton
Cc: Eric Dumazet
Cc: "Eric W. Biederman"
Cc: Felipe Balbi
Cc: Aleksey Babahin
Cc: Dan Carpenter
Cc: Jiri Kosina
Cc: Donald Lee
Cc: Julia Lawall
Cc: Michal Sroczynski
Cc: Wang YanQing
Cc: Dan Williams
Cc: Thomas Tuttle
Cc: Rigbert Hamisch
Cc: "Rafael J. Wysocki"
Cc: Kuninori Morimoto
Cc: Jesper Juhl
Cc: Adhir Ramjiawan
Signed-off-by: Greg Kroah-Hartman
04 May, 2012
1 commit
-
This removes most of the dbg() calls, as they were just tracing calls,
and converts the remaining ones to dev_dbg().Signed-off-by: Greg Kroah-Hartman
20 Apr, 2012
1 commit
-
This driver is for devices that are no longer being made, so the ability
to add new device ids when loading the module is not a feature that
anyone uses anymore. So remove it, which simplifies the startup code a
lot, and saves space.If you still need to dynamically load device ids, that can be done
through sysfs.Signed-off-by: Greg Kroah-Hartman
25 Feb, 2012
1 commit
-
This patch (as1529) modifies the following usb-serial drivers to
utilize the new usb_serial_{de}register_drivers() routines:ti_usb_3410_5052, usb_debug, visor, vivopay-serial,
whiteheat, and zio.Signed-off-by: Alan Stern
Signed-off-by: Greg Kroah-Hartman
13 Jan, 2012
1 commit
-
module_param(bool) used to counter-intuitively take an int. In
fddd5201 (mid-2009) we allowed bool or int/unsigned int using a messy
trick.It's time to remove the int/unsigned int option. For this version
it'll simply give a warning, but it'll break next kernel version.Acked-by: Mauro Carvalho Chehab
Signed-off-by: Rusty Russell
18 Feb, 2011
1 commit
-
[USB]Add Samsung SGH-I500/Android modem ID switch to visor driver
Samsung decided to reuse USB ID of its old CDMA phone SGH-I500 for the
modem part of some of their Android phones. At least Galaxy Spica
is affected.This modem needs ACM driver and does not work with visor driver which
binds the conflicting ID for SGH-I500.
Because SGH-I500 is pretty an old hardware its best to add switch to
visor
driver in cause somebody still wants to use that phone with Linux.Note that this is needed only when using the Android phone as modem,
not in USB storage or ADB mode.Signed-off-by: Maciej Szmigiero
Cc: stable
Signed-off-by: Greg Kroah-Hartman
23 Oct, 2010
1 commit
-
Fix regression introduced by commit
214916f2ec6701e1c9972f26c60b3dc37d3153c6 (USB: visor: reimplement using
generic framework) which broke initialisation of UX50/TH55 devices that
used re-mapped bulk-out endpoint addresses.Reported-by: Robert Gadsdon
Tested-by: Robert Gadsdon
Cc: stable
Signed-off-by: Johan Hovold
Signed-off-by: Greg Kroah-Hartman
21 May, 2010
3 commits
-
Increase the bulk-out buffer size to avoid any regression in throughput
after replacing the old writing scheme which used dynamic buffers (e.g.
up to 2k).256b has been determined to be a good choice for several drivers
including ftdi_sio which used to have a more or less identical write
implementation.Signed-off-by: Johan Hovold
Signed-off-by: Greg Kroah-Hartman -
Kill custom read and write implementations (dynamically allocated write
urbs).Note that I chose to remove the stat module parameter which was supposed
to keep count of the amount of data sent and received, but which has
been broken for three years (since b308e74d9c708ee2a9af14fbe235e0a41216f4ed
"USB: visor driver adapted to new tty buffering" -- bytes_in was
incorrectly updated and was thus always reported as 0).Compile-only tested.
Signed-off-by: Johan Hovold
Signed-off-by: Greg Kroah-Hartman -
Fix memory leak for some devices (Sony Clie 3.5) due to port private
data not being freed on release.Cc: stable
Signed-off-by: Johan Hovold
Signed-off-by: Greg Kroah-Hartman
03 Mar, 2010
3 commits
-
We have lots of callers that do not need to do this in the first place.
Remove the calls as they both cost CPU and for big buffers can mess up the
multi-page allocation avoidance.Signed-off-by: Alan Cox
Signed-off-by: Greg Kroah-Hartman -
#define dbg adds the newline, messages shouldn't.
Converted dbg("%s", "some string") to dbg("some string")Signed-off-by: Joe Perches
Signed-off-by: Greg Kroah-Hartman -
Signed-off-by: Johan Hovold
Signed-off-by: Greg Kroah-Hartman
10 Oct, 2009
3 commits
-
usb:usbserial:visor: fix race between unthrottle and completion handler
visor_unthrottle() mustn't resubmit the URB unconditionally
as the URB may still be running.the same bug as opticon.
Signed-off-by: Oliver Neukum
Signed-off-by: Greg Kroah-Hartman -
many serial subdrivers are clearly written as if throttle/unthrottle
cannot sleep. This leads to unneeded atomic submissions. This
patch converts affected drivers in a way to makes very clear that
throttle/unthrottle can sleep. Thus future misdesigns can be avoided
and efficiency and reliability improved.This removes any such assumption using GFP_KERNEL and spin_lock_irq()
Signed-off-by: Oliver Neukum
Signed-off-by: Greg Kroah-Hartman -
usb:usbserial:visor: fix accounting in error case
data not pushed to the tty layer due to an error mustn't be counted
Signed-off-by: Oliver Neukum
Signed-off-by: Greg Kroah-Hartman
20 Sep, 2009
1 commit
-
And indeed none of them use it. Clean this up as it will make moving to a
standard open method rather easier.Signed-off-by: Alan Cox
Signed-off-by: Greg Kroah-Hartman
16 Jun, 2009
1 commit
-
This patch (as1254) splits up the shutdown method of usb_serial_driver
into a disconnect and a release method.The problem is that the usb-serial core was calling shutdown during
disconnect handling, but drivers didn't expect it to be called until
after all the open file references had been closed. The result was an
oops when the close method tried to use memory that had been
deallocated by shutdown.Signed-off-by: Alan Stern
Signed-off-by: Greg Kroah-Hartman
11 Jun, 2009
1 commit
-
This allows us to clean stuff up, but is probably also going to cause
some app breakage with buggy apps as we now implement proper POSIX behaviour
for USB ports matching all the other ports. This does also mean other apps
that break on USB will now work properly.Signed-off-by: Alan Cox
Signed-off-by: Linus Torvalds
24 Apr, 2009
1 commit
-
This removes tty->low_latency from all USB serial drivers that push
data into the tty layer at hard interrupt context. It's no longer needed
and actually harmful.Signed-off-by: Oliver Neukum
Cc: Alan Cox
Signed-off-by: Greg Kroah-Hartman
18 Oct, 2008
2 commits
-
err() is going away, so switch to dev_err() or printk() if it's really
needed.Signed-off-by: Greg Kroah-Hartman
-
USB should not be having it's own printk macros, so remove info() and
use the system-wide standard of dev_info() wherever possible.Signed-off-by: Greg Kroah-Hartman
14 Oct, 2008
1 commit
-
Use kref in the USB serial drivers so that we don't free tty structures
from under the URB receive handlers as has historically been the case if
you were unlucky. This also gives us a framework for general tty drivers to
use tty_port objects and refcount.Contains two err->dev_err changes merged together to fix clashes in the
-next tree.Signed-off-by: Alan Cox
Signed-off-by: Linus Torvalds
23 Jul, 2008
2 commits
-
Signed-off-by: Alan Cox
Signed-off-by: Greg Kroah-Hartman
Signed-off-by: Linus Torvalds -
USB serial likes to use port->tty back pointers for the real work it does and
to do so without any actual locking. Unfortunately when you consider hangup
events, hangup/parallel reopen or even worse hangup followed by parallel close
events the tty->port and port->tty pointers are not guaranteed to be the same
as port->tty is the active tty while tty->port is the port the tty may or
may not still be attached to.So rework the entire API to pass the tty struct. For console cases we need
to pass both for now. This shows up multiple drivers that immediately crash
with USB console some of which have been fixed in the process.Longer term we need a proper tty as console abstraction
Signed-off-by: Alan Cox
Signed-off-by: Greg Kroah-Hartman
Signed-off-by: Linus Torvalds
25 Apr, 2008
4 commits
-
urb->context code cleanup
Signed-off-by: Ming Lei
Signed-off-by: Greg Kroah-Hartman -
- If a termios change fails due to lack of memory we should copy the
old settings back over as the device has not changed
- Note various locking problems
- kl5kusb105 had various remaining tty flag handling problems
- Make safe_serial use tty_insert_flip_string not open coded loops
- set termios speed properly in usb_serialSigned-off-by: Alan Cox
Signed-off-by: Greg Kroah-Hartman -
__FUNCTION__ is gcc-specific, use __func__
Signed-off-by: Harvey Harrison
Signed-off-by: Greg Kroah-Hartman -
The usb-serial core no longer checks these fields so remove them from
all of the individual drivers. They will be removed from the usb-serial
core in a patch later in the series.Signed-off-by: Greg Kroah-Hartman
03 Apr, 2008
1 commit
-
Fixes a bug/inconsistency revealed by the additional sanity checking in
commit 063a2da8f01806906f7d7b1a1424b9afddebc443
introduced in the original 2.6.24 branch.The Handspring Visor / PalmOS 4 device structure defines .num_bulk_out=2
but the usb-serial probe returns num_bulk_out=3, triggering the check in
the above commit and forcing a bail out when the device (a Garmin iQue in
my case) attempts to connect. The patch bumps the expected number of
endpoints to 3.FWIW, this patch will probably solve the following kernel bug report for
Treo users (identical symptoms, different model PalmOS units):
Signed-off-by: Brad Sawatzky
Cc: stable
Signed-off-by: Greg Kroah-Hartman
