Eric Lee / smarc-ti-linux-kernel

27 Sep, 2013

2 commits

04 Sep, 2013

1 commit

  • 1205e1fa6   netfilter: xt_TCPMSS: correct return value in tcpmss_mangle_packet ... Browse Code »

    In commit b396966c4 (netfilter: xt_TCPMSS: Fix missing fragmentation handling),
    I attempted to add safe fragment handling to xt_TCPMSS. However, Andy Padavan
    of Project N56U correctly points out that returning XT_CONTINUE in this
    function does not work. The callers (tcpmss_tg[46]) expect to receive a value
    of 0 in order to return XT_CONTINUE.

    Signed-off-by: Phil Oester
    Signed-off-by: Pablo Neira Ayuso

    Phil Oester
     

01 Aug, 2013

1 commit

12 Jun, 2013

2 commits

  • b396966c4   netfilter: xt_TCPMSS: Fix missing fragmentation handling ... Browse Code »

    Similar to commit bc6bcb59 ("netfilter: xt_TCPOPTSTRIP: fix
    possible mangling beyond packet boundary"), add safe fragment
    handling to xt_TCPMSS.

    Signed-off-by: Phil Oester
    Signed-off-by: Pablo Neira Ayuso

    Phil Oester
     
  • 70d19f805   netfilter: xt_TCPMSS: Fix IPv6 default MSS too ... Browse Code »

    As a followup to commit 409b545a ("netfilter: xt_TCPMSS: Fix violation
    of RFC879 in absence of MSS option"), John Heffner points out that IPv6
    has a higher MTU than IPv4, and thus a higher minimum MSS. Update TCPMSS
    target to account for this, and update RFC comment.

    While at it, point to more recent reference RFC1122 instead of RFC879.

    Signed-off-by: Phil Oester
    Signed-off-by: Pablo Neira Ayuso

    Phil Oester
     

05 Jun, 2013

1 commit

  • 409b545ac   netfilter: xt_TCPMSS: Fix violation of RFC879 in absence of MSS option ... Browse Code »

    The clamp-mss-to-pmtu option of the xt_TCPMSS target can cause issues
    connecting to websites if there was no MSS option present in the
    original SYN packet from the client. In these cases, it may add a
    MSS higher than the default specified in RFC879. Fix this by never
    setting a value > 536 if no MSS option was specified by the client.

    This closes netfilter's bugzilla #662.

    Signed-off-by: Phil Oester
    Signed-off-by: Pablo Neira Ayuso

    Phil Oester
     

19 Apr, 2013

1 commit

  • f229f6ce4   netfilter: add my copyright statements ... Browse Code »

    Add copyright statements to all netfilter files which have had significant
    changes done by myself in the past.

    Some notes:

    - nf_conntrack_ecache.c was incorrectly attributed to Rusty and Netfilter
    Core Team when it got split out of nf_conntrack_core.c. The copyrights
    even state a date which lies six years before it was written. It was
    written in 2005 by Harald and myself.

    - net/ipv{4,6}/netfilter.c, net/netfitler/nf_queue.c were missing copyright
    statements. I've added the copyright statement from net/netfilter/core.c,
    where this code originated

    - for nf_conntrack_proto_tcp.c I've also added Jozsef, since I didn't want
    it to give the wrong impression

    Signed-off-by: Patrick McHardy
    Signed-off-by: Pablo Neira Ayuso

    Patrick McHardy
     

16 May, 2012

1 commit

17 Dec, 2011

1 commit

04 Dec, 2011

1 commit

  • 75f2811c6   ipv6: Add fragment reporting to ipv6_skip_exthdr(). ... Browse Code »

    While parsing through IPv6 extension headers, fragment headers are
    skipped making them invisible to the caller. This reports the
    fragment offset of the last header in order to make it possible to
    determine whether the packet is fragmented and, if so whether it is
    a first or last fragment.

    Signed-off-by: Jesse Gross

    Jesse Gross
     

23 Nov, 2011

1 commit

04 Apr, 2011

2 commits

  • 0fae2e774   netfilter: af_info: add 'strict' parameter to limit lookup to .oif ... Browse Code »

    ipv6 fib lookup can set RT6_LOOKUP_F_IFACE flag to restrict search
    to an interface, but this flag cannot be set via struct flowi.

    Also, it cannot be set via ip6_route_output: this function uses the
    passed sock struct to determine if this flag is required
    (by testing for nonzero sk_bound_dev_if).

    Work around this by passing in an artificial struct sk in case
    'strict' argument is true.

    This is required to replace the rt6_lookup call in xt_addrtype.c with
    nf_afinfo->route().

    Signed-off-by: Florian Westphal
    Acked-by: David S. Miller
    Signed-off-by: Patrick McHardy

    Florian Westphal
     
  • 31ad3dd64   netfilter: af_info: add network namespace parameter to route hook ... Browse Code »

    This is required to eventually replace the rt6_lookup call in
    xt_addrtype.c with nf_afinfo->route().

    Signed-off-by: Florian Westphal
    Acked-by: David S. Miller
    Signed-off-by: Patrick McHardy

    Florian Westphal
     

13 Mar, 2011

1 commit

16 Jun, 2010

1 commit

  • a3433f35a   tcp: unify tcp flag macros ... Browse Code »

    unify tcp flag macros: TCPHDR_FIN, TCPHDR_SYN, TCPHDR_RST, TCPHDR_PSH,
    TCPHDR_ACK, TCPHDR_URG, TCPHDR_ECE and TCPHDR_CWR. TCBCB_FLAG_* are replaced
    with the corresponding TCPHDR_*.

    Signed-off-by: Changli Gao
    ----
    include/net/tcp.h | 24 ++++++-------
    net/ipv4/tcp.c | 8 ++--
    net/ipv4/tcp_input.c | 2 -
    net/ipv4/tcp_output.c | 59 ++++++++++++++++-----------------
    net/netfilter/nf_conntrack_proto_tcp.c | 32 ++++++-----------
    net/netfilter/xt_TCPMSS.c | 4 --
    6 files changed, 58 insertions(+), 71 deletions(-)
    Signed-off-by: David S. Miller

    Changli Gao
     

11 Jun, 2010

1 commit

12 May, 2010

1 commit

20 Apr, 2010

1 commit

30 Mar, 2010

1 commit

  • 5a0e3ad6a   include cleanup: Update gfp.h and slab.h includes to prepare for breaking implic… ... Browse Code »

    …it slab.h inclusion from percpu.h

    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files. percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.

    percpu.h -> slab.h dependency is about to be removed. Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability. As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.

    http://userweb.kernel.org/~tj/misc/slabh-sweep.py

    The script does the followings.

    * Scan files for gfp and slab usages and update includes such that
    only the necessary includes are there. ie. if only gfp is used,
    gfp.h, if slab is used, slab.h.

    * When the script inserts a new include, it looks at the include
    blocks and try to put the new include such that its order conforms
    to its surrounding. It's put in the include block which contains
    core kernel includes, in the same order that the rest are ordered -
    alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
    doesn't seem to be any matching order.

    * If the script can't find a place to put a new include (mostly
    because the file doesn't have fitting include block), it prints out
    an error message indicating which .h file needs to be added to the
    file.

    The conversion was done in the following steps.

    1. The initial automatic conversion of all .c files updated slightly
    over 4000 files, deleting around 700 includes and adding ~480 gfp.h
    and ~3000 slab.h inclusions. The script emitted errors for ~400
    files.

    2. Each error was manually checked. Some didn't need the inclusion,
    some needed manual addition while adding it to implementation .h or
    embedding .c file was more appropriate for others. This step added
    inclusions to around 150 files.

    3. The script was run again and the output was compared to the edits
    from #2 to make sure no file was left behind.

    4. Several build tests were done and a couple of problems were fixed.
    e.g. lib/decompress_*.c used malloc/free() wrappers around slab
    APIs requiring slab.h to be added manually.

    5. The script was run on all .h files but without automatically
    editing them as sprinkling gfp.h and slab.h inclusions around .h
    files could easily lead to inclusion dependency hell. Most gfp.h
    inclusion directives were ignored as stuff from gfp.h was usually
    wildly available and often used in preprocessor macros. Each
    slab.h inclusion directive was examined and added manually as
    necessary.

    6. percpu.h was updated not to include slab.h.

    7. Build test were done on the following configurations and failures
    were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
    distributed build env didn't work with gcov compiles) and a few
    more options had to be turned off depending on archs to make things
    build (like ipr on powerpc/64 which failed due to missing writeq).

    * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
    * powerpc and powerpc64 SMP allmodconfig
    * sparc and sparc64 SMP allmodconfig
    * ia64 SMP allmodconfig
    * s390 SMP allmodconfig
    * alpha SMP allmodconfig
    * um on x86_64 SMP allmodconfig

    8. percpu.h modifications were reverted so that it could be applied as
    a separate patch and serve as bisection point.

    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>

    Tejun Heo
     

25 Mar, 2010

3 commits

  • d6b00a534   netfilter: xtables: change targets to return error code ... Browse Code »

    Part of the transition of done by this semantic patch:
    //
    @ rule1 @
    struct xt_target ops;
    identifier check;
    @@
    ops.checkentry = check;

    @@
    identifier rule1.check;
    @@
    check(...) { }

    @@
    identifier rule1.check;
    @@
    check(...) { }
    //

    Signed-off-by: Jan Engelhardt

    Jan Engelhardt
     
  • 135367b8f   netfilter: xtables: change xt_target.checkentry return type ... Browse Code »
    5

    Restore function signatures from bool to int so that we can report
    memory allocation failures or similar using -ENOMEM rather than
    always having to pass -EINVAL back.

    //
    @@
    type bool;
    identifier check, par;
    @@
    -bool check
    +int check
    (struct xt_tgchk_param *par) { ... }
    //

    Minus the change it does to xt_ct_find_proto.

    Signed-off-by: Jan Engelhardt

    Jan Engelhardt
     
  • ff67e4e42   netfilter: xt extensions: use pr_<level> (2) ... Browse Code »

    Supplement to 1159683ef48469de71dc26f0ee1a9c30d131cf89.

    Downgrade the log level to INFO for most checkentry messages as they
    are, IMO, just an extra information to the -EINVAL code that is
    returned as part of a parameter "constraint violation". Leave errors
    to real errors, such as being unable to create a LED trigger.

    Signed-off-by: Jan Engelhardt

    Jan Engelhardt
     

18 Mar, 2010

1 commit

25 Feb, 2010

1 commit

02 Feb, 2010

1 commit

  • 10a199394   netfilter: xt_TCPMSS: SYN packets are allowed to contain data ... Browse Code »

    The TCPMSS target is dropping SYN packets where:
    1) There is data, or
    2) The data offset makes the TCP header larger than the packet.

    Both of these result in an error level printk. This printk has been
    removed.

    This change avoids dropping SYN packets containing data. If there
    is also no MSS option (as well as data), one will not be added
    because of possible complications due to the increased packet size.

    Signed-off-by: Simon Arlott
    Signed-off-by: Patrick McHardy

    Simon Arlott
     

03 Jun, 2009

1 commit

  • adf30907d   net: skb->dst accessors ... Browse Code »

    Define three accessors to get/set dst attached to a skb

    struct dst_entry *skb_dst(const struct sk_buff *skb)

    void skb_dst_set(struct sk_buff *skb, struct dst_entry *dst)

    void skb_dst_drop(struct sk_buff *skb)
    This one should replace occurrences of :
    dst_release(skb->dst)
    skb->dst = NULL;

    Delete skb->dst field

    Signed-off-by: Eric Dumazet
    Signed-off-by: David S. Miller

    Eric Dumazet
     

08 Oct, 2008

3 commits

22 Jul, 2008

1 commit

01 Feb, 2008

1 commit

29 Jan, 2008

5 commits

  • 2ae15b64e   [NETFILTER]: Update modules' descriptions ... Browse Code »

    Updates the MODULE_DESCRIPTION() tags for all Netfilter modules,
    actually describing what the module does and not just
    "netfilter XYZ target".

    Signed-off-by: Jan Engelhardt
    Signed-off-by: Patrick McHardy
    Signed-off-by: David S. Miller

    Jan Engelhardt
     
  • 170080645   [NETFILTER]: xt_TCPMSS: don't allow netfilter --setmss to increase mss ... Browse Code »

    When terminating DSL connections for an assortment of random customers, I've
    found it necessary to use iptables to clamp the MSS used for connections to
    work around the various ICMP blackholes in the greater net. Unfortunately,
    the current behaviour in Linux is imperfect and actually make things worse,
    so I'm proposing the following: increasing the MSS in a packet can never be
    a good thing, so make --set-mss only lower the MSS in a packet.

    Yes, I am aware of --clamp-mss-to-pmtu, but it doesn't work for outgoing
    connections from clients (ie web traffic), as it only looks at the PMTU on
    the destination route, not the source of the packet (the DSL interfaces in
    question have a 1442 byte MTU while the destination ethernet interface is
    1500 -- there are problematic hosts which use a 1300 byte MTU). Reworking
    that is probably a good idea at some point, but it's more work than this is.

    Signed-off-by: Benjamin LaHaise
    Signed-off-by: Patrick McHardy
    Signed-off-by: David S. Miller

    Benjamin LaHaise
     
  • d3c5ee6d5   [NETFILTER]: x_tables: consistent and unique symbol names ... Browse Code »

    Give all Netfilter modules consistent and unique symbol names.

    Signed-off-by: Jan Engelhardt
    Signed-off-by: Patrick McHardy
    Signed-off-by: David S. Miller

    Jan Engelhardt
     
  • be0ea7d5d   [NETFILTER]: Convert old checksum helper names ... Browse Code »

    Kill the defines again, convert to the new checksum helper names and
    remove the dependency of NET_ACT_NAT on NETFILTER.

    Signed-off-by: Patrick McHardy
    Signed-off-by: Herbert Xu
    Signed-off-by: David S. Miller

    Patrick McHardy
     
  • 6e23ae2a4   [NETFILTER]: Introduce NF_INET_ hook values ... Browse Code »

    The IPv4 and IPv6 hook values are identical, yet some code tries to figure
    out the "correct" value by looking at the address family. Introduce NF_INET_*
    values for both IPv4 and IPv6. The old values are kept in a #ifndef __KERNEL__
    section for userspace compatibility.

    Signed-off-by: Patrick McHardy
    Acked-by: Herbert Xu
    Signed-off-by: David S. Miller

    Patrick McHardy
     

30 Nov, 2007

1 commit

16 Oct, 2007

2 commits