07 Feb, 2012
8 commits
-
This patch removes the CONFIG_NFS_USE_NEW_IDMAPPER compile option.
First, the idmapper will attempt to map the id using /sbin/request-key
and nfsidmap. If this fails (if /etc/request-key.conf is not configured
properly) then the idmapper will call the legacy code to perform the
mapping. I left a comment stating where the legacy code begins to make
it easier for somebody to remove in the future.Signed-off-by: Bryan Schumaker
Signed-off-by: Trond Myklebust -
data_server_cache entries should only be treated as the same if the address
list hasn't changed.A new entry will be made when an MDS changes an address list (as seen by
GETDEVINFO). The old entry will be freed once all references are gone.Signed-off-by: Weston Andros Adamson
Signed-off-by: Trond Myklebust -
This patch addresses printks that have some context to show that they are
from fs/nfs/, but for the sake of consistency now start with NFS:Signed-off-by: Weston Andros Adamson
Signed-off-by: Trond Myklebust -
Messages like "Got error -10052 from the server on DESTROY_SESSION. Session
has been destroyed regardless" can be confusing to users who aren't very
familiar with NFS.NOTE: This patch ignores any printks() that start by printing __func__ - that
will be in a separate patch.Signed-off-by: Weston Andros Adamson
Signed-off-by: Trond Myklebust -
We check "task->tk_rqstp" and then we dereference it without checking on
the next line. The only caller is call_connect() and that has a check
which prevents it from calling xprt_connect() with a NULL.if (task->tk_status < 0)
return;If "task->tk_rqstp" were NULL then "tk_status" would be -EAGAIN.
Signed-off-by: Dan Carpenter
Signed-off-by: Trond Myklebust -
I noticed that test_stateid() was always using the same stateid for open
and lock recovery. After poking around a bit, I discovered that it was
always testing with a delegation stateid (even if there was no
delegation present). I figured this wasn't correct, so now delegation
and open stateids are tested during open_expired() and lock stateids are
tested during lock_expired().Signed-off-by: Bryan Schumaker
Signed-off-by: Trond Myklebust -
This takes the guesswork out of what stateid to use. The caller is
expected to figure this out and pass in the correct one.Signed-off-by: Bryan Schumaker
Signed-off-by: Trond Myklebust -
Since the scheme of limiting the number of TCP slots to whatever will
fit in the current TCP window seems to be working well (Andy reports
getting within 20% of the 'iperf' send performance on a 10GigE link)
we should just let that be the default mode of operation.Users may still set their own limits using the tcp_max_slot_table_entries
parameter if they need to.Signed-off-by: Trond Myklebust
06 Feb, 2012
2 commits
-
This patch adds three trace points to the status routines
in the sunrpc state machine.The goal of these trace points is to give an Admin
the ability to check on binding status or connection
status to see if there is a potential problem.Signed-off-by: Steve Dickson
Signed-off-by: Trond Myklebust -
The reporting of the RPC queue name needs to use the __string()
event interface.Reported-by: Neil Horman
Signed-off-by: Trond Myklebust
01 Feb, 2012
30 commits
-
We only really need to check the change attribute, so let's just use the
server->cache_consistency_bitmask.Signed-off-by: Trond Myklebust
-
Currently, the server can potentially cause us to Oops by returning an
fs_locations request that we didn't actually request.Signed-off-by: Trond Myklebust
-
"data" is never NULL here.
Reported-by: Eric Paris
Signed-off-by: Jeff Layton
Signed-off-by: Trond Myklebust -
Fixes this build error when CONFIG_NET_NS is not set:
net/sunrpc/svcsock.c: In function 'svc_setup_socket':
net/sunrpc/svcsock.c:1412:40: error: 'struct sock_common' has no member named 'skc_net'Reported-by: Stephen Rothwell
Signed-off-by: Trond Myklebust -
Fixes the following compiler warning:
fs/nfs/callback_proc.c: In function 'do_callback_layoutrecall':
fs/nfs/callback_proc.c:115:26: warning: 'lo' may be used uninitialized in this functionReported-by: Jim Rees
Signed-off-by: Benny Halevy
Signed-off-by: Trond Myklebust -
Signed-off-by: Trond Myklebust
-
Store a pointer to the rpc_task in struct nfs_seqid so that we can wake up
only that request that is able to grab the lock after we've released it.Signed-off-by: Trond Myklebust
-
Add declarations to allow tracing of RPC call creation, running, sleeping,
and destruction.Signed-off-by: Trond Myklebust
-
Signed-off-by: Trond Myklebust
-
Signed-off-by: Trond Myklebust
-
...and get rid of the superfluous cl_inline_name.
Signed-off-by: Trond Myklebust
-
Service transports are parametrized by network namespace. And thus lookup of
transport instance have to take network namespace into account.Signed-off-by: Stanislav Kinsbursky
Signed-off-by: Trond Myklebust
Acked-by: J. Bruce Fields -
Looks like this function survived after some cleanup patch without a reason.
Now it's not called or referenced and I believe, that it can be simply removed.Signed-off-by: Stanislav Kinsbursky
Signed-off-by: Trond Myklebust -
This patch makes it possible to create NFSd program entry ("/proc/net/rpc/nfsd")
in passed network namespace context instead of hard-coded "init_net".Signed-off-by: Stanislav Kinsbursky
Signed-off-by: Trond Myklebust -
Fix build errors in linux/sunrpc/stats.h when CONFIG_PROC_FS
is not enabled:
- add parameter names to inline functions
- fix placement of '(' in rpc_proc_unregister()Fixes these errors:
include/linux/sunrpc/stats.h:72:63: error: parameter name omitted
include/linux/sunrpc/stats.h:73:46: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'net'Signed-off-by: Randy Dunlap
Signed-off-by: Trond Myklebust -
This patch makes it possible to create NFS program entry ("/proc/net/rpc/nfs")
in passed network namespace context instead of hard-coded "init_net".Signed-off-by: Stanislav Kinsbursky
Signed-off-by: Trond Myklebust -
This patch replaces "init_net" with NFS client's owner net in rpc_pton() call
in decode_ds_addr().Signed-off-by: Stanislav Kinsbursky
Signed-off-by: Trond Myklebust -
This patch replaces "init_net" with cache's owner net in rpc_pton() call.
Signed-off-by: Stanislav Kinsbursky
Signed-off-by: Trond Myklebust -
All cache users now uses network-namespace-aware routines, so generic ones
are obsolete.Signed-off-by: Stanislav Kinsbursky
Signed-off-by: Trond Myklebust
Acked-by: J. Bruce Fields -
This patch converts ip_map_cache per network namespace implemenetation to the
same view, as other caches done in the series.
Besides generalization, code becomes shorter with this patch.Signed-off-by: Stanislav Kinsbursky
Signed-off-by: Trond Myklebust
Acked-by: J. Bruce Fields -
This patch makes GSS auth cache details allocated and registered per network
namespace context.
Thus with this patch rsi_cache and rsc_cache contents for network namespace "X"
are controlled from proc file system mount for the same network namespace "X".Signed-off-by: Stanislav Kinsbursky
Signed-off-by: Trond Myklebust
Acked-by: J. Bruce Fields -
v2:
1) fixed silly usage of template cache as a real one (this code left from
static global cache for all)This patch makes unix_gid_cache cache detail allocated and registered per
network namespace context.
Thus with this patch unix_gid_cache contents for network namespace "X" are
controlled from proc file system mount for the same network namespace "X".Signed-off-by: Stanislav Kinsbursky
Signed-off-by: Trond Myklebust
Acked-by: J. Bruce Fields -
This patch prepares infrastructure for network namespace aware cache detail
allocation.
One note about adding network namespace link to cache structure. It's going to
be used later in NFS DNS cache parsing routine (nfs_dns_parse for rpc_pton()
call).Signed-off-by: Stanislav Kinsbursky
Signed-off-by: Trond Myklebust
Acked-by: J. Bruce Fields -
On service shutdown we can be sure, that no more users of it left except
current. Thus it looks like using current network namespace context is safe in
this case.Signed-off-by: Stanislav Kinsbursky
Signed-off-by: Trond Myklebust -
Service, using rpcbind (Lockd, NFSd) are starting from userspace call and thus
we can use current network namespace.
There could be a problem with NFSd service, because it's creation can be called
through NFSd fs from different network namespace. But this is a part of "NFSd
per net ns" task and will be fixed in future.Signed-off-by: Stanislav Kinsbursky
Signed-off-by: Trond Myklebust -
Lockd and NFSd services will handle requests from and to many network
nsamespaces. And thus have to be registered and unregistered per network
namespace.Signed-off-by: Stanislav Kinsbursky
Signed-off-by: Trond Myklebust -
Pass request socket network namespace to rpc_uaddr2sockaddr() instead of
hardcoded "init_net", when decoding address in RPCBPROC_GETADDR procedure.Signed-off-by: Stanislav Kinsbursky
Signed-off-by: Trond Myklebust -
Parametrize rpc_uaddr2sockaddr() by network context and thus force it's callers to pass
in network context instead of using hard-coded "init_net".Signed-off-by: Stanislav Kinsbursky
Signed-off-by: Trond Myklebust -
Parametrize rpc_pton() by network context and thus force it's callers to pass
in network context instead of using hard-coded "init_net".Signed-off-by: Stanislav Kinsbursky
Signed-off-by: Trond Myklebust -
Parametrize rpc_pton6() by network context and thus force it's caller
to pass in network context instead of using hard-coded "init_net".Signed-off-by: Stanislav Kinsbursky
Signed-off-by: Trond Myklebust
