Eric Lee / smarc-ti-linux-kernel

01 Jul, 2014

1 commit

  • d8fae2f64   tracing: Change trace event sample to use strlcpy instead of strncpy ... Browse Code »

    Strings should be copied with strlcpy instead of strncpy when they will
    later be printed via %s. This guarantees that they terminate with a
    NUL '\0' character and do not run pass the end of the allocated string.

    This is only for sample code, but it should stil represent a good
    role model.

    Link: http://lkml.kernel.org/p/51C2E204.1080501@huawei.com

    Signed-off-by: Zhao Hongjiang
    Signed-off-by: Steven Rostedt

    Zhao Hongjiang
     

21 Jun, 2014

1 commit

  • 4d4c9cc83   tracing: Add __field_struct macro for TRACE_EVENT() ... Browse Code »

    Currently the __field() macro in TRACE_EVENT is only good for primitive
    values, such as integers and pointers, but it fails on complex data types
    such as structures or unions. This is because the __field() macro
    determines if the variable is signed or not with the test of:

    (((type)(-1)) < (type)1)

    Unfortunately, that fails when type is a structure.

    Since trace events should support structures as fields a new macro
    is created for such a case called __field_struct() which acts exactly
    the same as __field() does but it does not do the signed type check
    and just uses a constant false for that answer.

    Cc: Tony Luck
    Signed-off-by: Steven Rostedt

    Steven Rostedt
     

16 Sep, 2009

1 commit

13 Jul, 2009

1 commit

  • d0b6e04a4   tracing/events: Move TRACE_SYSTEM outside of include guard ... Browse Code »

    If TRACE_INCLDUE_FILE is defined,
    will be included and compiled, otherwise it will be

    So TRACE_SYSTEM should be defined outside of #if proctection,
    just like TRACE_INCLUDE_FILE.

    Imaging this scenario:

    #include
    -> TRACE_SYSTEM == foo
    ...
    #include
    -> TRACE_SYSTEM == bar
    ...
    #define CREATE_TRACE_POINTS
    #include
    -> TRACE_SYSTEM == bar !!!

    and then bar.h will be included and compiled.

    Signed-off-by: Li Zefan
    Cc: Steven Rostedt
    Cc: Frederic Weisbecker
    LKML-Reference:
    Signed-off-by: Ingo Molnar

    Li Zefan
     

17 Jun, 2009

1 commit

07 May, 2009

1 commit

  • 71e1c8ac4   tracing: update sample with TRACE_INCLUDE_FILE ... Browse Code »

    When creating trace events for ftrace, the header file with the TRACE_EVENT
    macros must also have a macro called TRACE_SYSTEM. This macro describes
    the name of the system the TRACE_EVENTS are defined for. It also doubles
    as a way for the define_trace.h file to include the file that included
    it.

    For example:

    in irq.h

    #define TRACE_SYSTEM irq

    [...]

    #include

    The define_trace will use TRACE_SYSTEM to include irq.h. But if the name
    of the trace system does not match the name of the trace header file,
    one can override it with:

    Which will change define_trace.h to inclued foo_trace.h instead of foo.h

    The sample comments this, but people that use the sample code will more
    likely use the code and not read the comments. This patch changes the
    sample code to use the TRACE_INCLUDE_FILE to better show developers how to
    use it.

    [ Impact: make sample less confusing to developers ]

    Reported-by: Christoph Hellwig
    Signed-off-by: Steven Rostedt

    Steven Rostedt
     

06 May, 2009

2 commits

15 Apr, 2009

1 commit