Eric Lee / smarc-ti-linux-kernel

25 Apr, 2014

1 commit

  • 7d8d9f670   drm/msm/mdp4: cure for the cursor blues (v2) ... Browse Code »

    The hw cursor is relatively adept at triggering underflows, which
    manifest as a "blue flash" (since blue is configured as the underflow
    color). Juggle a few things around to tighten up the timing for setting
    cursor registers in DONE irq.

    And most importantly, don't ever disable the hw cursor. Instead flip it
    to a blank/empty cursor. This seems far more reliable, as even simply
    clearing the cursor-enable bit (with no other updates in previous/
    following frames) can in some cases cause underflow.

    v1: original
    v2: add missing locking spotted by Micah

    Cc: Micah Richert
    Signed-off-by: Rob Clark

    Rob Clark
     

02 Apr, 2014

2 commits

  • f4510a275   drm: Replace crtc fb with primary plane fb (v3) ... Browse Code »
    5

    Now that CRTC's have a primary plane, there's no need to track the
    framebuffer in the CRTC. Replace all references to the CRTC fb with the
    primary plane's fb.

    This patch was generated by the Coccinelle semantic patching tool using
    the following rules:

    @@ struct drm_crtc C; @@
    - (C).fb
    + C.primary->fb

    @@ struct drm_crtc *C; @@
    - (C)->fb
    + C->primary->fb

    v3: Generate patch via coccinelle. Actual removal of crtc->fb has been
    moved to a subsequent patch.

    v2: Fixup several lingering crtc->fb instances that were missed in the
    first patch iteration. [Rob Clark]

    Signed-off-by: Matt Roper
    Reviewed-by: Rob Clark

    Matt Roper
     
  • 2d82d188b   drm/msm: Switch to universal plane API's ... Browse Code »

    Use drm_universal_plane_init() and drm_crtc_init_with_planes() rather
    than the legacy drm_plane_init() / drm_crtc_init(). This will ensure
    that the proper primary plane is registered with the DRM (and eventually
    exposed to userspace in future patches).

    Cc: Rob Clark
    Signed-off-by: Matt Roper
    Signed-off-by: Rob Clark

    Matt Roper
     

06 Feb, 2014

2 commits

  • aa1b0e59d   drm/msm/mdp4: cursor fixes ... Browse Code »

    It seems we need to update all cursor registers from vblank. This
    appears to be the cause of intermittent underflows when enabling/
    disabling cursor.

    Signed-off-by: Rob Clark

    Rob Clark
     
  • b69720c0f   drm/msm/mdp4: pageflip fixes ... Browse Code »

    Backport a few fixes found in the course of getting mdp5 working.
    There is a window of time after pageflip is requested, before we
    start scanning out the new fb (ie. while we are waiting for gpu).
    During that time we need to continue holding a reference to the
    still-current scanout fb, to avoid the backing gem bo's from being
    destroyed.

    Possibly a common mdp_crtc parent class could be useful to share
    some of this logic between mdp4_crtc and mdp5_crtc. OTOH, this
    all can be removed from the driver once atomic is in place, as
    plane/crtc updates get deferred until all fb's are ready before
    calling in to .page_flip(), etc.

    Signed-off-by: Rob Clark

    Rob Clark
     

10 Jan, 2014

4 commits