Doug / smarc-fsl-linux-kernel

Download as
Browse Code ยป

Commit 6b101116ae445311031f3e9f91d3010d444b9845

Authored by Guenter Roeck
Committed by Jean Delvare
1 parent 2fe28ab51d
Exists in master and in 6 other branches imx_3.10.17_1.0.1_ga, imx_3.10.53_1.1.0_ga, imx_3.14.28_1.0.0_ga, smarc-imx_3.10.53_1.1.0_ga, smarc-imx_3.14.28_1.0.0_ga, smarc-l5.0.0_1.0.0-ga

hwmon: (lm90) Add range check to set_update_interval 

When writing the update_interval attribute, the parameter value was
not range checked, which could cause an integer overflow and result
in an arbitrary update interval. Fix by limiting the value range to
<0, 100000>.

Reported-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Jean Delvare <khali@linux-fr.org>

Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff

drivers/hwmon/lm90.c
Diff comments   View file @ 6b10111
... ... @@ -917,7 +917,7 @@
917 917 return err;
918 918  
919 919 mutex_lock(&data->update_lock);
920   - lm90_set_convrate(client, data, val);
  920 + lm90_set_convrate(client, data, SENSORS_LIMIT(val, 0, 100000));
921 921 mutex_unlock(&data->update_lock);
922 922  
923 923 return count;