30 Nov, 2012
7 commits
-
The 'io_mutex' is not used anywhere.
The regmap API supports the mutex internally, so no additional mutex
is required.And 'domain' private data is unnecessary because the irq domain is
already registered by using regmap_add_irq_chip().Signed-off-by: Milo(Woogyom) Kim
Acked-by: Laxman Dewangan
Signed-off-by: Samuel Ortiz -
Since the very first patch, stmpe core driver is using irq_invert_polarity as
part of platform data. But, nobody is actually using it in kernel till now.Also, this is not something part of hardware specs, but is included to cater
some board mistakes or quirks.So, better get rid of it. This is earlier discussed here:
https://lkml.org/lkml/2012/11/27/636
Signed-off-by: Viresh Kumar
Acked-by: Lee Jones
Signed-off-by: Samuel Ortiz -
The objects allocated by devm_* APIs are managed by devres and are
freed when the device is detached. Hence there is no need to remove
them explicitly in remove function.Signed-off-by: Tushar Behera
Acked-by: Linus Walleij
Signed-off-by: Samuel Ortiz -
We can cache some of them but this is simpler for now.
Signed-off-by: Mark Brown
Signed-off-by: Samuel Ortiz -
Signed-off-by: Mark Brown
Signed-off-by: Samuel Ortiz -
Both WM5102 and WM5110 support haptics, register the device.
Signed-off-by: Mark Brown
Signed-off-by: Samuel Ortiz -
As the wm8994 series of devices are now very mature make the current
behaviour of the devices the default behaviour, any future revisions are
likely to have only minor updates.Signed-off-by: Mark Brown
Signed-off-by: Samuel Ortiz
27 Nov, 2012
2 commits
-
This fixes below build error:
drivers/built-in.o: In function `tps65090_i2c_probe':
drivers/mfd/tps65090.c:180: undefined reference to `regmap_add_irq_chip'
drivers/mfd/tps65090.c:190: undefined reference to `regmap_irq_chip_get_base'
drivers/mfd/tps65090.c:203: undefined reference to `regmap_del_irq_chip'
drivers/built-in.o: In function `tps65090_i2c_remove':
drivers/mfd/tps65090.c:213: undefined reference to `regmap_del_irq_chip'
make: *** [vmlinux] Error 1Signed-off-by: Axel Lin
Signed-off-by: Samuel Ortiz -
Fix build errors when CONFIG_OF is not enabled by including
(needs to be added in any case).
An alternative fix could be to make the driver depend on OF.drivers/mfd/stmpe.c:1025:2: error: implicit declaration of function 'of_property_read_u32'
drivers/mfd/stmpe.c:1030:2: error: implicit declaration of function 'for_each_child_of_node'
drivers/mfd/stmpe.c:1030:36: error: expected ';' before '{' tokenSigned-off-by: Randy Dunlap
Acked-by: Linus Walleij
Signed-off-by: Samuel Ortiz
26 Nov, 2012
7 commits
-
Use devm_kzalloc and remove the error path free'ing and unload free'ing
as the devm resource functions free them.Signed-off-by: Devendra Naga
Signed-off-by: Samuel Ortiz -
Currently, few fields in stmpe_i2c_driver are initialized as:
.driver.owner = THIS_MODULE,Group them under {}, like:
.driver = {
.owner = THIS_MODULE,
...
},Signed-off-by: Viresh Kumar
Signed-off-by: Samuel Ortiz -
Historically, a driver would have to decide whether it required
a Linear or Legacy IRQ domain when registering one. This can end
up as quite a lot of code. A new Simple call now exists which
simplifies this process. Let's make use of it here.Reviewed-by: Viresh Kumar
Signed-off-by: Lee Jones
Signed-off-by: Samuel Ortiz -
I got below build warning while compiling this driver.
It's obviously RC5T583_MAX_INTERRUPT_MASK_REGS is 9 but irq_en_add
array only has 8 elements.CC drivers/mfd/rc5t583-irq.o
drivers/mfd/rc5t583-irq.c: In function 'rc5t583_irq_sync_unlock':
drivers/mfd/rc5t583-irq.c:227: warning: array subscript is above array bounds
drivers/mfd/rc5t583-irq.c: In function 'rc5t583_irq_init':
drivers/mfd/rc5t583-irq.c:349: warning: array subscript is above array boundsSince the number of interrupt enable registers is 8, this patch adds
define for RC5T583_MAX_INTERRUPT_EN_REGS to fix this bug.Signed-off-by: Axel Lin
Acked-by: Laxman Dewangan
Signed-off-by: Samuel Ortiz -
The query for the viperboard version was done with memory buffer
on the stack but usb transfers need dma capable memory buffer.
This is fixed now.Signed-off-by: Lars Poeschel
Signed-off-by: Samuel Ortiz -
Pass on the correct error message from platform_get_irq()
instead of hard coding it to "EINVAL".Also change label from "err" to "ret" for better
readability and update the same in error path.Signed-off-by: Patil, Rachna
Signed-off-by: Samuel Ortiz -
reg_offset is offset of the status/mask registers. Now, since status_base
and mask_base are pointing to corresponding first registers, reg_offset
should start from 0 otheriwse regmap_add_irq_chip will fail during probe.Signed-off-by: Inderpal Singh
Signed-off-by: Samuel Ortiz
23 Nov, 2012
4 commits
-
This is supported identically to the previous revisions.
Signed-off-by: Mark Brown
Cc: stable@vger.kernel.org
Signed-off-by: Samuel Ortiz -
Hierarchically, the abx500-clk shall be considered as a child of the
ab8500 core. The abx500-clk is intiated at arch init and thus the clks
will be available when clients needs them.Cc: Samuel Ortiz
Signed-off-by: Ulf Hansson
Signed-off-by: Samuel Ortiz -
AS3711 is a PMIC with multiple DCDC and LDO power supplies, GPIOs, an RTC,
a battery charger and a general purpose ADC. This patch adds support for
the MFD with support for a regulator driver and a backlight driver.Signed-off-by: Guennadi Liakhovetski
Signed-off-by: Samuel Ortiz -
This patch frees stmpe driver from tension of freeing resources.
devm_* derivatives of multiple routines are used while allocating resources,
which would be freed automatically by kernel.Signed-off-by: Viresh Kumar
Acked-by: Lee Jones
Signed-off-by: Samuel Ortiz
22 Nov, 2012
2 commits
-
At every boot of an (outdated) laptop lpc_ich prints an error:
lpc_ich 0000:00:1f.0: I/O space for GPIO uninitializedBut if one looks at lpc_ich's probe function one notices that the code
only cares if both lpc_ich_init_wdt() and lpc_ich_init_gpio() fail to
add any cells. So stop treating the failure to add a single cell as an
error. Those messages can be printed at notice level. And then only warn
if no cells were added.Signed-off-by: Paul Bolle
Signed-off-by: Samuel Ortiz -
The older southbridges supported by the lpc_ich driver do not
provide memory-mapped space of the root complex. The driver
correctly avoids computing the iomem address in this case, yet
submits a zeroed resource request anyway (via mfd_add_devices()).Remove the iomem resource from the resource array submitted to the
mfd core for the older southbridges.Acked-by: Aaron Sierra
Cc: Peter Tyser
Signed-off-by: Peter Hurley
Signed-off-by: Samuel Ortiz
21 Nov, 2012
18 commits
-
To facilitate upcoming cleanup in twl stack.
No functional changes.Acked-by: Tero Kristo
Signed-off-by: Peter Ujfalusi
Signed-off-by: Samuel Ortiz -
To facilitate upcoming cleanup in twl stack.
No functional changes.Acked-by: Tero Kristo
Signed-off-by: Peter Ujfalusi
Signed-off-by: Samuel Ortiz -
To facilitate upcoming cleanup in twl stack.
No functional changes.Acked-by: Tero Kristo
Signed-off-by: Peter Ujfalusi
Signed-off-by: Samuel Ortiz -
To facilitate upcoming cleanup in twl stack.
No functional changes.Acked-by: Tero Kristo
Signed-off-by: Peter Ujfalusi
Signed-off-by: Samuel Ortiz -
Group the twl_mapping table in 5 lines chunks so it is more easier to find
the row we are looking for (if we need to).Acked-by: Tero Kristo
Signed-off-by: Peter Ujfalusi
Signed-off-by: Samuel Ortiz -
Use enum list for the module definitions (TWL4030_MODULE_*) which will ease
up future work with the IDs.
At the same time group the IDs in block of five so it is easier to find the
ID we are looking for (to count the number they stand for).At the same time define TWL_MODULE_LED so client drivers can switch to use
it as soon as it is possible.Acked-by: Tero Kristo
Signed-off-by: Peter Ujfalusi
Signed-off-by: Samuel Ortiz -
Make the twl child registration calls a bit more uniform by always using the
SUB_CHIP_ID* define instead of the mixed use of the define and magic number.At the same time correct the following devices so they are registered for the
correct parent device (i2c slave):
twl4030_wdt is accessible on 0x4b address and not 0x48
twl4030_pwrbutton is accessible on 0x4b address and not 0x49
twl4030-audio is on 0x49 all the timeAcked-by: Tero Kristo
Signed-off-by: Peter Ujfalusi
Signed-off-by: Samuel Ortiz -
Since the twl-core has been converted to use regmap it is no longer needed
to allocate bigger buffer for data when writing to twl.CC: Grant Likely
CC: Alessandro Zummo
Acked-by: Linus Walleij
Acked-by: Tero Kristo
Signed-off-by: Peter Ujfalusi
Signed-off-by: Samuel Ortiz -
Remove the custom code to do I/O and replace it with standard regmap calls.
Reviewed-by: Mark Brown
Acked-by: Tero Kristo
Signed-off-by: Peter Ujfalusi
Signed-off-by: Samuel Ortiz -
The twl6030-pwm driver is going to be deleted since it was only able to
control the Charging indicator LED on the twl6030 PMIC.
The new set of drivers are going to provide support for both PWMs and PWM
driven LED outputs on TWL4030 and TWL6030 PMICs.
The twl-pwm driver will handle the PWMs (2 instance) while the twl-pwmled
driver is to control the two LED instance on TWL4030 and to charging
indicator LED (1 instance) on TWL6030.Acked-by: Tero Kristo
Signed-off-by: Peter Ujfalusi
Signed-off-by: Samuel Ortiz -
twl4030-madc driver can only handle twl4030 class MADC. The newer revisions
of twl does not have MADC, instead they have different IP called GPADC which
is not backward compatible.Acked-by: Tero Kristo
Signed-off-by: Peter Ujfalusi
Signed-off-by: Samuel Ortiz -
Retu is a multi-function device found on Nokia Internet Tablets
implementing at least watchdog, RTC, headset detection and power button
functionality.This patch implements minimum functionality providing register access,
IRQ handling and power off functions.Acked-by: Felipe Balbi
Acked-by: Tony Lindgren
Signed-off-by: Aaro Koskinen
Signed-off-by: Samuel Ortiz -
linux/err.h was included twice.
Signed-off-by: Sachin Kamat
Signed-off-by: Samuel Ortiz -
They contain documented status readback fields.
Signed-off-by: Mark Brown
Signed-off-by: Samuel Ortiz -
Set tps65217 PMIC status to OFF if power enable toggle is supported.
By setting this bit to 1 to enter PMIC to OFF state when PWR_EN pin
is pulled low. Also adds a DT flag to specify that device pmic
supports shutdown control or not.Signed-off-by: Colin Foe-Parker
[anilkumar@ti.com: move the additions to tps65217 MFD driver]
Signed-off-by: AnilKumar Ch
Signed-off-by: Samuel Ortiz -
This fixes the following build error on some architectures (parisc at least):
drivers/mmc/host/rtsx_pci_sdmmc.c: In function 'sd_normal_rw':
drivers/mmc/host/rtsx_pci_sdmmc.c:448:2: error: implicit
declaration of function 'kzalloc'
[-Werror=implicit-function-declaration]
drivers/mmc/host/rtsx_pci_sdmmc.c:448:6: warning: assignment
makes pointer from integer without a cast [enabled by default]
drivers/mmc/host/rtsx_pci_sdmmc.c:472:2: error: implicit
declaration of function 'kfree'
[-Werror=implicit-function-declaration]Signed-off-by: Wei WANG
Acked-by: Chris Ball
Signed-off-by: Samuel Ortiz -
For Realtek card reader, internal regsiter SD_CFG2 should be configured
before transferring data.
The default value of SD_CFG2 is proper for writing data. But for reading
sequence, the timing is not good enough. So in some extreme circumstance,
card reader may sample the response data from the card as good even if
the data is wrong. And this will cause the bad consequence.
In the prior version, the value of this register has been calculated,
but forgotten to write back to the internal register.Signed-off-by: Wei WANG
Acked-by: Chris Ball
Signed-off-by: Samuel Ortiz -
Use the regmap irq framework for implementing TPS65090 interrupt
support in place of implementing it locally.Signed-off-by: Laxman Dewangan
Signed-off-by: Samuel Ortiz
