10 Sep, 2013
2 commits
-
Casting the return value which is a void pointer is redundant.
The conversion from void pointer to any other pointer type is
guaranteed by the C programming language.Signed-off-by: Jingoo Han
Acked-by: Jean Delvare
Signed-off-by: Guenter Roeck -
This gets rid of this warning:
drivers/hwmon/hwmon-vid.c: In function 'get_via_model_d_vrm':
drivers/hwmon/hwmon-vid.c:249:27: warning: variable 'dummy' set but not used
[-Wunused-but-set-variable]Signed-off-by: Guenter Roeck
Reviewed-by: Jean Delvare
08 Sep, 2013
1 commit
-
Pull hwmon fixes from Jean Delvare.
* 'hwmon-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jdelvare/staging:
hwmon: (emc6w201) Do not declare enum variable
hwmon: (w83792d) Update module author
06 Sep, 2013
2 commits
-
Fix the following smatch warning:
emc6w201.c:52:26: warning: symbol 'subfeature' was not declared.
Should it be static?'enum { } subtype' declares an enum as (global) variable which we don't want.
Signed-off-by: Guenter Roeck
Signed-off-by: Jean Delvare -
w83792d was written by me in 2004, I'd like to update my first name
into my current one to keep consistent, and delete invalid address.Signed-off-by: Shane Huang
Signed-off-by: Jean Delvare
04 Sep, 2013
1 commit
-
Pull hwmon updates from Guenter Roeck:
- new driver for HTU21D (humidity sensor)
- add support for Fam16h (Kabini) to k10temp
- add support for NCT6102D/6106D and NCT6791D to nct6775 driver
- add support for ADS1115 to ads1015 driver
- add support for hibernate to w83627ehf and nct6775 drivers
- some minor cleanups* tag 'hwmon-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging:
hwmon: (htu21) Add Measurement Specialties HTU21D support
hwmon: Change my email address.
hwmon: (k10temp) Add support for Fam16h (Kabini)
hwmon: (adt7462) ADT7462_REG_VOLT_MAX() should return 0
hwmon: (ads1015) Add support for ADS1115
hwmon: (w83627ehf) Add support for hibernate
hwmon: (nct6775) Add support for hibernate
hwmon: use dev_get_platdata()
hwmon: (nct6775) Fix size of data->temp array
hwmon: (nct6775) Avoid using device platform data outside probe function
hwmon: (nct6775) Add support for NCT6791D
hwmon: (nct6775) Add support for beep attributes
hwmon: (nct6775) Add support for critical low/high temperature limits on NCT6106
hwmon: (nct6775) Add support for NCT6102D/6106D
hwmon: (nct6775) Support two SuperIO chips in the same system
hwmon: (nct6775) Allocate attributes dynamically from templates
hwmon: (coretemp) Atom CPUs don't support TjMax; no warning needed
01 Sep, 2013
1 commit
30 Aug, 2013
1 commit
-
Signed-off-by: William Markezana
[Guenter Roeck - minor formatting changes]
Signed-off-by: Guenter Roeck
27 Aug, 2013
3 commits
-
I've changed employers, so change the email addresses to match.
Signed-off-by: Darrick J. Wong
Signed-off-by: Guenter Roeck -
The temperature reporting interface stays the same, so we just
add the PCI-ID to the list.Verified on AMD Olive Hill.
Signed-off-by: Wei Hu
Acked-by: Clemens Ladisch
Cc: stable@vger.kernel.org # 3.10+
Signed-off-by: Guenter Roeck -
The callers never check for negative but they sometimes check for zero
returns:int reg = ADT7462_REG_VOLT_MAX(data, i);
data->volt_max[i] =
(reg ? i2c_smbus_read_byte_data(client, reg) : 0);Signed-off-by: Dan Carpenter
Signed-off-by: Guenter Roeck
19 Aug, 2013
1 commit
-
Since the sht15 driver supports operation without an external vref
regulator the driver should use the new devm_regulator_get_optional() to
indicate that a stub regulator should not be provided.Signed-off-by: Mark Brown
Acked-by: Guenter Roeck
12 Aug, 2013
13 commits
-
This patch adds support for ads1115 device to ads1015 driver.
Based on work of Emiliano Carnati .
Tested on ARM CPU based board.Signed-off-by: Evgeniy A. Dushistov
Signed-off-by: Guenter Roeck -
Hibernation uses its own set of callback functions, even if the code
is the same as the code used for suspend/restore.Signed-off-by: Harald Judt
Signed-off-by: Guenter Roeck -
Hibernation uses its own set of callback functions, even if the code
is the same as the code used for suspend/restore.Signed-off-by: Harald Judt
Signed-off-by: Guenter Roeck -
Use the wrapper function for retrieving the platform data instead of
accessing dev->platform_data directly.Signed-off-by: Jingoo Han
Signed-off-by: Guenter Roeck -
Smatch complains that we have a array overflow:
drivers/hwmon/nct6775.c:1456 nct6775_update_device()
error: buffer overflow 'data->temp' 4
Signed-off-by: Guenter Roeck -
Plan going forward is to attach all device attributes to the hwmon device and no
longer to the platform device. With that change, accessing platform data outside
the probe function will be more difficult. To avoid the problem, change code
to no longer rely on it.Signed-off-by: Guenter Roeck
-
Signed-off-by: David Bartley
Signed-off-by: Guenter Roeck -
Signed-off-by: Guenter Roeck
-
Signed-off-by: Guenter Roeck
-
Signed-off-by: Guenter Roeck
-
Signed-off-by: Guenter Roeck
-
Static attribute allocation is large and very repetitive.
Allocate attributes and attribute groups dynamically instead.
This reduces the size of the driver source by more than 600 lines,
and object size by more than 20k (more than 30%).Signed-off-by: Guenter Roeck
-
Display warning "Unable to read TjMax from CPU x" only if the CPU
is supposed to support it. This is not the case for the various Atom CPUs.Signed-off-by: Guenter Roeck
09 Aug, 2013
1 commit
-
In adt7470_write_word_data(), which writes two bytes using
i2c_smbus_write_byte_data(), the return codes are incorrectly AND-ed
together when they should be OR-ed together.The return code of i2c_smbus_write_byte_data() is zero for success.
The upshot is only the first byte was ever written to the hardware.
The 2nd byte was never written out.I noticed that trying to set the fan speed limits was not working
correctly on my system. Setting the fan speed limits is the only
code that uses adt7470_write_word_data(). After making the change
the limit settings work and the alarms work also.Signed-off-by: Curt Brune
Cc: stable@vger.kernel.org
Signed-off-by: Guenter Roeck
03 Aug, 2013
1 commit
-
Without this patch, the values for ideality (register 0x4b) and ideality
selection mask (register 0x4c) are inverted.Signed-off-by: Vivien Didelot
Cc: stable@vger.kernel.org # 3.9+
Signed-off-by: Guenter Roeck
19 Jul, 2013
1 commit
-
Pull hwmon fix from Guenter Roeck:
"Single patch to staticize a local variable"* tag 'hwmon-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging:
hwmon: (abx500) Staticize abx500_temp_attributes
15 Jul, 2013
2 commits
-
The __cpuinit type of throwaway sections might have made sense
some time ago when RAM was more constrained, but now the savings
do not offset the cost and complications. For example, the fix in
commit 5e427ec2d0 ("x86: Fix bit corruption at CPU resume time")
is a good example of the nasty type of bugs that can be created
with improper use of the various __init prefixes.After a discussion on LKML[1] it was decided that cpuinit should go
the way of devinit and be phased out. Once all the users are gone,
we can then finally remove the macros themselves from linux/init.h.This removes all the drivers/hwmon uses of the __cpuinit macros
from all C files.[1] https://lkml.org/lkml/2013/5/20/589
Cc: Fenghua Yu
Cc: lm-sensors@lm-sensors.org
Acked-by: Guenter Roeck
Signed-off-by: Paul Gortmaker -
abx500_temp_attributes is used only in this file. Make it static.
Signed-off-by: Sachin Kamat
Signed-off-by: Guenter Roeck
08 Jul, 2013
2 commits
-
time_after (as opposed to time_after_equal) already ensures that the
cache lifetime is at least as much as requested. There is no point in
manually adding another jiffy to that value, and this can confuse the
reader into wrong interpretation.Signed-off-by: Jean Delvare
Cc: Imre Deak -
time_after (as opposed to time_after_equal) already ensures that the
cache lifetime is at least as much as requested. There is no point in
manually adding another jiffy to that value, and this can confuse the
reader into wrong interpretation.Signed-off-by: Jean Delvare
Cc: Imre Deak
04 Jul, 2013
2 commits
-
Pull hwmon updates from Guenter Roeck:
- new driver to support GMT G762/G763 pwm fan controllers
- add support for DS1631, DS1721, and DS1731 to ds1621 driver
- remove detect function from ds1621 driver as unreliable
- bug fixes in nct6775, iio_hwmon, and adm1021 drivers
- remove redundant platform_set_drvdata in various drivers
- add device tree support to ina2xx driver* tag 'hwmon-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging:
hwmon: (ds1621) Fix temperature rounding operations
hwmon: (nct6775) Drop unsupported fan alarm attributes for NCT6775
hwmon: (nct6775) Fix temperature alarm attributes
Add support for GMT G762/G763 PWM fan controllers
hwmon: (ina2xx) Add device tree support to pass the shunt resistor
hwmon: (ds1621) Update documentation
hwmon: (ds1621) Add DS1731 chip support to ds1621 driver
hwmon: (iio_hwmon) add alias table
hwmon: (adm1021) Do not create min sysfs attributes for LM84
hwmon: (ds1621) Remove detect function
hwmon: (ds1621) Add ds1631 chip support to ds1621 driver and documentation
hwmon: (ds1621) Add ds1721 update interval sysfs attribute
hwmon: (ds1621) Add ds1721 chip support
hwmon: (w83627ehf) Remove redundant platform_set_drvdata()
hwmon: (ntc_thermistor) Remove redundant platform_set_drvdata()
hwmon: (i5k_amb) Remove redundant platform_set_drvdata()
hwmon: (coretemp) Remove redundant platform_set_drvdata()
hwmon: (abituguru3) Remove redundant platform_set_drvdata() -
Calling kthread_run with a single name parameter causes it to be handled
as a format string. Many callers are passing potentially dynamic string
content, so use "%s" in those cases to avoid any potential accidents.Signed-off-by: Kees Cook
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
28 Jun, 2013
6 commits
-
Commit "hwmon: (ds1621) Add ds1721 chip support" broke rounding
for chips or configurations with less than 12 bit resolution.Tested-by: Jean Delvare
Acked-by: Jean Delvare
Signed-off-by: Guenter Roeck -
NCT6775 does not support alarms for fans 4 and 5. Drop the attributes.
cc: stable@vger.kernel.org # 3.10+
Signed-off-by: Guenter Roeck -
Driver displays wrong alarms for temperature attributes.
Turns out that temperature alarm bits are not fixed, but determined
by temperature source mapping. To fix the problem, walk through
the temperature sources to determine the correct alarm bit associated
with a given attribute.Cc: stable@vger.kernel.org # 3.10+
Signed-off-by: Guenter Roeck -
GMT G762/763 fan speed PWM controller is connected directly to a fan
and performs closed-loop or open-loop control of the fan speed. Two
modes - PWM or DC - are supported by the chip. Introduced driver
provides various knobs to control the operations of the chip (via
sysfs interface). Specific characteristics of the system can be passed
either using board init code or via DT. Documentation for both the
driver and DT bindings are also provided.Signed-off-by: Arnaud Ebalard
Tested-by: Simon Guinot
Signed-off-by: Guenter Roeck -
Adding another way that is device tree to pass the shunt resistor
value to driver except for platform data.Signed-off-by: Tang Yuantian
[Guenter Roeck: Added missing of.h include]
Signed-off-by: Guenter Roeck -
These changes add DS1731 chip support to the ds1621 driver,
Kconfig, and documentation.Signed-off-by: Robert Coulson
Signed-off-by: Guenter Roeck
