Commit 0000b862027d624ac564609b87c1aa4d14dd1e46
Committed by
Joel Becker
Joel Becker
1 parent
4a452de4fd
Exists in
master
and in
4 other branches
ocfs2: Sync inode flags with ext2.
We sync our inode flags with ext2 and define them by hex values. But actually in commit 3669567(4 years ago), all these values are moved to include/linux/fs.h. So we'd better also use them as what ext2 did. So sync our inode flags with ext2 by using FS_*. Signed-off-by: Tao Ma <tao.ma@oracle.com> Signed-off-by: Joel Becker <joel.becker@oracle.com>
Showing 2 changed files with 29 additions and 16 deletions Side-by-side Diff
fs/ocfs2/ocfs2_fs.h
| ... | ... | @@ -235,18 +235,31 @@ |
| 235 | 235 | #define OCFS2_HAS_REFCOUNT_FL (0x0010) |
| 236 | 236 | |
| 237 | 237 | /* Inode attributes, keep in sync with EXT2 */ |
| 238 | -#define OCFS2_SECRM_FL (0x00000001) /* Secure deletion */ | |
| 239 | -#define OCFS2_UNRM_FL (0x00000002) /* Undelete */ | |
| 240 | -#define OCFS2_COMPR_FL (0x00000004) /* Compress file */ | |
| 241 | -#define OCFS2_SYNC_FL (0x00000008) /* Synchronous updates */ | |
| 242 | -#define OCFS2_IMMUTABLE_FL (0x00000010) /* Immutable file */ | |
| 243 | -#define OCFS2_APPEND_FL (0x00000020) /* writes to file may only append */ | |
| 244 | -#define OCFS2_NODUMP_FL (0x00000040) /* do not dump file */ | |
| 245 | -#define OCFS2_NOATIME_FL (0x00000080) /* do not update atime */ | |
| 246 | -#define OCFS2_DIRSYNC_FL (0x00010000) /* dirsync behaviour (directories only) */ | |
| 238 | +#define OCFS2_SECRM_FL FS_SECRM_FL /* Secure deletion */ | |
| 239 | +#define OCFS2_UNRM_FL FS_UNRM_FL /* Undelete */ | |
| 240 | +#define OCFS2_COMPR_FL FS_COMPR_FL /* Compress file */ | |
| 241 | +#define OCFS2_SYNC_FL FS_SYNC_FL /* Synchronous updates */ | |
| 242 | +#define OCFS2_IMMUTABLE_FL FS_IMMUTABLE_FL /* Immutable file */ | |
| 243 | +#define OCFS2_APPEND_FL FS_APPEND_FL /* writes to file may only append */ | |
| 244 | +#define OCFS2_NODUMP_FL FS_NODUMP_FL /* do not dump file */ | |
| 245 | +#define OCFS2_NOATIME_FL FS_NOATIME_FL /* do not update atime */ | |
| 246 | +/* Reserved for compression usage... */ | |
| 247 | +#define OCFS2_DIRTY_FL FS_DIRTY_FL | |
| 248 | +#define OCFS2_COMPRBLK_FL FS_COMPRBLK_FL /* One or more compressed clusters */ | |
| 249 | +#define OCFS2_NOCOMP_FL FS_NOCOMP_FL /* Don't compress */ | |
| 250 | +#define OCFS2_ECOMPR_FL FS_ECOMPR_FL /* Compression error */ | |
| 251 | +/* End compression flags --- maybe not all used */ | |
| 252 | +#define OCFS2_BTREE_FL FS_BTREE_FL /* btree format dir */ | |
| 253 | +#define OCFS2_INDEX_FL FS_INDEX_FL /* hash-indexed directory */ | |
| 254 | +#define OCFS2_IMAGIC_FL FS_IMAGIC_FL /* AFS directory */ | |
| 255 | +#define OCFS2_JOURNAL_DATA_FL FS_JOURNAL_DATA_FL /* Reserved for ext3 */ | |
| 256 | +#define OCFS2_NOTAIL_FL FS_NOTAIL_FL /* file tail should not be merged */ | |
| 257 | +#define OCFS2_DIRSYNC_FL FS_DIRSYNC_FL /* dirsync behaviour (directories only) */ | |
| 258 | +#define OCFS2_TOPDIR_FL FS_TOPDIR_FL /* Top of directory hierarchies*/ | |
| 259 | +#define OCFS2_RESERVED_FL FS_RESERVED_FL /* reserved for ext2 lib */ | |
| 247 | 260 | |
| 248 | -#define OCFS2_FL_VISIBLE (0x000100FF) /* User visible flags */ | |
| 249 | -#define OCFS2_FL_MODIFIABLE (0x000100FF) /* User modifiable flags */ | |
| 261 | +#define OCFS2_FL_VISIBLE FS_FL_USER_VISIBLE /* User visible flags */ | |
| 262 | +#define OCFS2_FL_MODIFIABLE FS_FL_USER_MODIFIABLE /* User modifiable flags */ | |
| 250 | 263 | |
| 251 | 264 | /* |
| 252 | 265 | * Extent record flags (e_node.leaf.flags) |
fs/ocfs2/ocfs2_ioctl.h
| ... | ... | @@ -23,10 +23,10 @@ |
| 23 | 23 | /* |
| 24 | 24 | * ioctl commands |
| 25 | 25 | */ |
| 26 | -#define OCFS2_IOC_GETFLAGS _IOR('f', 1, long) | |
| 27 | -#define OCFS2_IOC_SETFLAGS _IOW('f', 2, long) | |
| 28 | -#define OCFS2_IOC32_GETFLAGS _IOR('f', 1, int) | |
| 29 | -#define OCFS2_IOC32_SETFLAGS _IOW('f', 2, int) | |
| 26 | +#define OCFS2_IOC_GETFLAGS FS_IOC_GETFLAGS | |
| 27 | +#define OCFS2_IOC_SETFLAGS FS_IOC_SETFLAGS | |
| 28 | +#define OCFS2_IOC32_GETFLAGS FS_IOC32_GETFLAGS | |
| 29 | +#define OCFS2_IOC32_SETFLAGS FS_IOC32_SETFLAGS | |
| 30 | 30 | |
| 31 | 31 | /* |
| 32 | 32 | * Space reservation / allocation / free ioctls and argument structure |