Eric Lee / linux-smarc-t335x-v3.2

Download as
Browse Code ยป

Commit 0986f25fbba8827762b35222bb45d2fbb2d72fa4

Authored by Dan Carpenter
Committed by Matthew Garrett
1 parent 2783658477
Exists in master and in 4 other branches v3.2_AM335xPSP_04.06.00.11, v3.2_NEWT335xPSP_04.06.00.11, v3.2_SBC_SMARTMEN, v3.2_SMARCT335xPSP_04.06.00.11

asus-wmi: signedness bug in read_brightness() 

"err" needs to be signed for the error handling to work.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Matthew Garrett <mjg@redhat.com>

Showing 1 changed file with 2 additions and 1 deletions Side-by-side Diff

drivers/platform/x86/asus-wmi.c
Diff comments   View file @ 0986f25
... ... @@ -946,7 +946,8 @@
946 946 static int read_brightness(struct backlight_device *bd)
947 947 {
948 948 struct asus_wmi *asus = bl_get_data(bd);
949   - u32 retval, err;
  949 + u32 retval;
  950 + int err;
950 951  
951 952 err = asus_wmi_get_devstate(asus, ASUS_WMI_DEVID_BRIGHTNESS, &retval);
952 953