Eric Lee / linux-smarc-t335x-v3.2

Download as
Browse Code ยป

Commit 160e7f671344e40b86663a8913e175a3bb5d7f84

Authored by Tomohiro Kusumi
Committed by James Bottomley
1 parent 8637ac3340
Exists in master and in 4 other branches v3.2_AM335xPSP_04.06.00.11, v3.2_NEWT335xPSP_04.06.00.11, v3.2_SBC_SMARTMEN, v3.2_SMARCT335xPSP_04.06.00.11

[SCSI] fix sdev_rw_attr macro for scsi device sysfs entries 

This patch fixes sdev_rw_attr() macro for scsi device sysfs entries.
It seems there is no such function snscanf in the current linux kernel,
so it fails to compile scsi driver when someone try to add a new rw entry.
This has been unfixed for a long time probably because current scsi device
has no rw entries.

# grep snscanf . -rn
./drivers/scsi/scsi_sysfs.c:489:        snscanf (buf, 20, format_string, &sdev->field);                 \

Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@jp.fujitsu.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>

Showing 1 changed file with 2 additions and 2 deletions Side-by-side Diff

drivers/scsi/scsi_sysfs.c
Diff comments   View file @ 160e7f6
... ... @@ -474,7 +474,7 @@
474 474  
475 475  
476 476 /*
477   - * sdev_rd_attr: create a function and attribute variable for a
  477 + * sdev_rw_attr: create a function and attribute variable for a
478 478 * read/write field.
479 479 */
480 480 #define sdev_rw_attr(field, format_string) \
... ... @@ -486,7 +486,7 @@
486 486 { \
487 487 struct scsi_device *sdev; \
488 488 sdev = to_scsi_device(dev); \
489   - snscanf (buf, 20, format_string, &sdev->field); \
  489 + sscanf (buf, format_string, &sdev->field); \
490 490 return count; \
491 491 } \
492 492 static DEVICE_ATTR(field, S_IRUGO | S_IWUSR, sdev_show_##field, sdev_store_##field);