Commit 18e6bfa96d4d810ad9a69e17f08e0d0089379f22

Authored by Al Viro
Committed by Linus Torvalds
1 parent c52c2ddc1d

alpha: __get_user/__put_user results need to be checked...

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

Showing 1 changed file with 4 additions and 4 deletions Side-by-side Diff

arch/alpha/kernel/signal.c
... ... @@ -68,9 +68,9 @@
68 68 old_sigset_t mask;
69 69 if (!access_ok(VERIFY_READ, act, sizeof(*act)) ||
70 70 __get_user(new_ka.sa.sa_handler, &act->sa_handler) ||
71   - __get_user(new_ka.sa.sa_flags, &act->sa_flags))
  71 + __get_user(new_ka.sa.sa_flags, &act->sa_flags) ||
  72 + __get_user(mask, &act->sa_mask))
72 73 return -EFAULT;
73   - __get_user(mask, &act->sa_mask);
74 74 siginitset(&new_ka.sa.sa_mask, mask);
75 75 new_ka.ka_restorer = NULL;
76 76 }
77 77  
... ... @@ -80,9 +80,9 @@
80 80 if (!ret && oact) {
81 81 if (!access_ok(VERIFY_WRITE, oact, sizeof(*oact)) ||
82 82 __put_user(old_ka.sa.sa_handler, &oact->sa_handler) ||
83   - __put_user(old_ka.sa.sa_flags, &oact->sa_flags))
  83 + __put_user(old_ka.sa.sa_flags, &oact->sa_flags) ||
  84 + __put_user(old_ka.sa.sa_mask.sig[0], &oact->sa_mask))
84 85 return -EFAULT;
85   - __put_user(old_ka.sa.sa_mask.sig[0], &oact->sa_mask);
86 86 }
87 87  
88 88 return ret;