Eric Lee / linux-smarc-t335x-v3.2

Download as
Browse Code ยป

Commit 1d7b33f77b2d8b0b1ee767e6f8f05cbd9d72cb7c

Authored by Inaky Perez-Gonzalez
Committed by David S. Miller
1 parent df0bca049d
Exists in master and in 4 other branches v3.2_AM335xPSP_04.06.00.11, v3.2_NEWT335xPSP_04.06.00.11, v3.2_SBC_SMARTMEN, v3.2_SMARCT335xPSP_04.06.00.11

wimax: fix oops in wimax_dev_get_by_genl_info() when looking up non-wimax iface 

When a non-wimax interface is looked up by the stack, a bad pointer is
returned when the looked-up interface is not found in the list (of
registered WiMAX interfaces). This causes an oops in the caller when
trying to use the pointer.

Fix by properly setting the pointer to NULL if we don't exit from the
list_for_each() with a found entry.

Signed-off-by: Inaky Perez-Gonzalez <inaky@linux.intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

Showing 1 changed file with 5 additions and 4 deletions Side-by-side Diff

net/wimax/id-table.c
Diff comments   View file @ 1d7b33f
... ... @@ -94,12 +94,13 @@
94 94 list_for_each_entry(wimax_dev, &wimax_id_table, id_table_node) {
95 95 if (wimax_dev->net_dev->ifindex == ifindex) {
96 96 dev_hold(wimax_dev->net_dev);
97   - break;
  97 + goto found;
98 98 }
99 99 }
100   - if (wimax_dev == NULL)
101   - d_printf(1, NULL, "wimax: no devices found with ifindex %d\n",
102   - ifindex);
  100 + wimax_dev = NULL;
  101 + d_printf(1, NULL, "wimax: no devices found with ifindex %d\n",
  102 + ifindex);
  103 +found:
103 104 spin_unlock(&wimax_id_table_lock);
104 105 d_fnend(3, NULL, "(info %p ifindex %d) = %p\n",
105 106 info, ifindex, wimax_dev);