Eric Lee / linux-smarc-t335x-v3.2

Download as
Browse Code ยป

Commit 272b62c1f0f6f742046e45b50b6fec98860208a0

Authored by Goldwyn Rodrigues
Committed by Joel Becker
1 parent 99bdc3880c
Exists in master and in 4 other branches v3.2_AM335xPSP_04.06.00.11, v3.2_NEWT335xPSP_04.06.00.11, v3.2_SBC_SMARTMEN, v3.2_SMARCT335xPSP_04.06.00.11

Treat writes as new when holes span across page boundaries 

When a hole spans across page boundaries, the next write forces
a read of the block. This could end up reading existing garbage
data from the disk in ocfs2_map_page_blocks. This leads to
non-zero holes. In order to avoid this, mark the writes as new
when the holes span across page boundaries.

Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.de>
Signed-off-by: jlbec <jlbec@evilplan.org>

Showing 1 changed file with 6 additions and 0 deletions Side-by-side Diff

... ... @@ -1015,6 +1015,12 @@
1015 1015 ocfs2_figure_cluster_boundaries(OCFS2_SB(inode->i_sb), cpos,
1016 1016 &cluster_start, &cluster_end);
1017 1017  
  1018 + /* treat the write as new if the a hole/lseek spanned across
  1019 + * the page boundary.
  1020 + */
  1021 + new = new | ((i_size_read(inode) <= page_offset(page)) &&
  1022 + (page_offset(page) <= user_pos));
  1023 +
1018 1024 if (page == wc->w_target_page) {
1019 1025 map_from = user_pos & (PAGE_CACHE_SIZE - 1);
1020 1026 map_to = map_from + user_len;