Eric Lee / linux-smarc-t335x-v3.2

Download as
Browse Code ยป

Commit 2b6db5cb65cb1276a7aa363a6e7335b0a8a68393

Authored by Andy Whitcroft
Committed by Linus Torvalds
1 parent b53c8e104e
Exists in master and in 4 other branches v3.2_AM335xPSP_04.06.00.11, v3.2_NEWT335xPSP_04.06.00.11, v3.2_SBC_SMARTMEN, v3.2_SMARCT335xPSP_04.06.00.11

checkpatch: struct file_operations should normally be const 

In the general use case struct file_operations should be a const object.
Check for and warn where it is not.  As suggested by Steven and Ingo.

Acked-by: Steven Rostedt <rostedt@goodmis.org>
Cc: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Andy Whitcroft <apw@canonical.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

Showing 1 changed file with 5 additions and 0 deletions Side-by-side Diff

scripts/checkpatch.pl
Diff comments   View file @ 2b6db5c
... ... @@ -2509,6 +2509,11 @@
2509 2509 if ($line =~ /^.\s*__initcall\s*\(/) {
2510 2510 WARN("please use device_initcall() instead of __initcall()\n" . $herecurr);
2511 2511 }
  2512 +# check for struct file_operations, ensure they are const.
  2513 + if ($line =~ /\bstruct\s+file_operations\b/ &&
  2514 + $line !~ /\bconst\b/) {
  2515 + WARN("struct file_operations should normally be const\n" . $herecurr);
  2516 + }
2512 2517  
2513 2518 # use of NR_CPUS is usually wrong
2514 2519 # ignore definitions of NR_CPUS and usage to define arrays as likely right