Commit 2f84dd70916ccadd25e94d28363182a978f569b6

Authored by Linus Torvalds
1 parent c3ad996246

autofs4: fix debug printk warning uncovered by cleanup

The previous comit made the autofs4 debug printouts check types against
the printout format, and uncovered this bug:

  fs/autofs4/waitq.c:106:2: warning: format ‘%08lx’ expects type ‘long unsigned int’, but argument 4 has type ‘autofs_wqt_t’

which is due to the insane type for wait_queue_token.  That thing should
be some fixed well-defined size (preferably just 'unsigned int' or
'u32') but for unexplained reasons it is randomly either 'unsigned long'
or 'unsigned int' depending on the architecture.

For now, cast it to 'unsigned long' for printing, the way we do
elsewhere.  Somebody else can try to explain the typedef mess.

(There's a reason we don't support excessive use of typedefs in the
kernel: it's usually just a good way of confusing yourself).

Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff

... ... @@ -104,7 +104,7 @@
104 104 size_t pktsz;
105 105  
106 106 DPRINTK("wait id = 0x%08lx, name = %.*s, type=%d",
107   - wq->wait_queue_token, wq->name.len, wq->name.name, type);
  107 + (unsigned long) wq->wait_queue_token, wq->name.len, wq->name.name, type);
108 108  
109 109 memset(&pkt,0,sizeof pkt); /* For security reasons */
110 110