[PATCH] IPMI: use schedule in kthread

Corey Minyard <minyard@acm.org> The kthread used to speed up polling for IPMI was using udelay in its busy-wait polling loop when the lower-level state machine told it to do a short delay. This just used CPU and didn't help scheduling, thus causing bad problems with other tasks. Call schedule() instead. Signed-off-by: Corey Minyard <minyard@acm.org> Acked-by: Matt Domsch <Matt_Domsch@dell.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>

[PATCH] IPMI: use schedule in kthread
Corey Minyard <minyard@acm.org> The kthread used to speed up polling for IPMI was using udelay in its busy-wait polling loop when the lower-level state machine told it to do a short delay. This just used CPU and didn't help scheduling, thus causing bad problems with other tasks. Call schedule() instead. Signed-off-by: Corey Minyard <minyard@acm.org> Acked-by: Matt Domsch <Matt_Domsch@dell.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
akpm@osdl.org · Linus Torvalds
1 parent c32e066057
Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff
drivers/char/ipmi/ipmi_si_intf.c
@@ -809,7 +809,7 @@
 			/* do nothing */
 		}
 		else if (smi_result == SI_SM_CALL_WITH_DELAY)
-			udelay(1);
+			schedule();
 		else
 			schedule_timeout_interruptible(1);
 	}
...	...	@@ -809,7 +809,7 @@
809	809	/* do nothing */
810	810	}
811	811	else if (smi_result == SI_SM_CALL_WITH_DELAY)
812		- udelay(1);
	812	+ schedule();
813	813	else
814	814	schedule_timeout_interruptible(1);
815	815	}