Commit 35d40952dba7b0689a16bd1463fb7698f8dbe639

Authored by FUJITA Tomonori
Committed by Ingo Molnar
1 parent 84be58d460

dma-debug: warn of unmapping an invalid dma address

Impact: extend DMA-debug checks

Calling dma_unmap families against an invalid dma address should be a
bug.

Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: Joerg Roedel <joerg.roedel@amd.com>
LKML-Reference: <20090319103743N.fujita.tomonori@lab.ntt.co.jp>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

Showing 1 changed file with 4 additions and 1 deletions Side-by-side Diff

... ... @@ -531,8 +531,11 @@
531 531 struct hash_bucket *bucket;
532 532 unsigned long flags;
533 533  
534   - if (dma_mapping_error(ref->dev, ref->dev_addr))
  534 + if (dma_mapping_error(ref->dev, ref->dev_addr)) {
  535 + err_printk(ref->dev, NULL, "DMA-API: device driver tries "
  536 + "to free an invalid DMA memory address\n");
535 537 return;
  538 + }
536 539  
537 540 bucket = get_hash_bucket(ref, &flags);
538 541 entry = hash_bucket_find(bucket, ref);