Commit 363da4022c2753bf4b4b54a1bb9e4527fdcb9d5d
Committed by
Linus Torvalds
1 parent
c70a626d3e
Exists in
master
and in
4 other branches
call_usermodehelper: no need to unblock signals
____call_usermodehelper() correctly calls flush_signal_handlers() to set SIG_DFL, but sigemptyset(->blocked) and recalc_sigpending() are not needed. This kthread was forked by workqueue thread, all signals must be unblocked and ignored, no pending signal is possible. Signed-off-by: Oleg Nesterov <oleg@redhat.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Showing 1 changed file with 0 additions and 3 deletions Side-by-side Diff
kernel/kmod.c
... | ... | @@ -134,11 +134,8 @@ |
134 | 134 | struct subprocess_info *sub_info = data; |
135 | 135 | int retval; |
136 | 136 | |
137 | - /* Unblock all signals */ | |
138 | 137 | spin_lock_irq(¤t->sighand->siglock); |
139 | 138 | flush_signal_handlers(current, 1); |
140 | - sigemptyset(¤t->blocked); | |
141 | - recalc_sigpending(); | |
142 | 139 | spin_unlock_irq(¤t->sighand->siglock); |
143 | 140 | |
144 | 141 | /* We can run anywhere, unlike our parent keventd(). */ |