Eric Lee / linux-smarc-t335x-v3.2

Download as
Browse Code ยป

Commit 3677209239ed71d2654e73eecfab1dbec2af11a9

Authored by Paolo 'Blaisorblade' Giarrusso
Committed by Linus Torvalds
1 parent 291c4a75ce
Exists in master and in 4 other branches v3.2_AM335xPSP_04.06.00.11, v3.2_NEWT335xPSP_04.06.00.11, v3.2_SBC_SMARTMEN, v3.2_SMARCT335xPSP_04.06.00.11

[PATCH] comments on locking of task->comm 

Add some comments about task->comm, to explain what it is near its definition
and provide some important pointers to its uses.

Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

Showing 2 changed files with 8 additions and 3 deletions Side-by-side Diff

... ... @@ -869,9 +869,11 @@
869 869 if (current->euid == current->uid && current->egid == current->gid)
870 870 current->mm->dumpable = 1;
871 871 name = bprm->filename;
  872 +
  873 + /* Copies the binary name from after last slash */
872 874 for (i=0; (ch = *(name++)) != '\0';) {
873 875 if (ch == '/')
874   - i = 0;
  876 + i = 0; /* overwrite what we wrote */
875 877 else
876 878 if (i < (sizeof(tcomm) - 1))
877 879 tcomm[i++] = ch;
include/linux/sched.h
Diff comments   View file @ 3677209
... ... @@ -578,7 +578,7 @@
578 578 unsigned long flags; /* per process flags, defined below */
579 579 unsigned long ptrace;
580 580  
581   - int lock_depth; /* Lock depth */
  581 + int lock_depth; /* BKL lock depth */
582 582  
583 583 int prio, static_prio;
584 584 struct list_head run_list;
... ... @@ -661,7 +661,10 @@
661 661 struct key *thread_keyring; /* keyring private to this thread */
662 662 #endif
663 663 int oomkilladj; /* OOM kill score adjustment (bit shift). */
664   - char comm[TASK_COMM_LEN];
  664 + char comm[TASK_COMM_LEN]; /* executable name excluding path
  665 + - access with [gs]et_task_comm (which lock
  666 + it with task_lock())
  667 + - initialized normally by flush_old_exec */
665 668 /* file system info */
666 669 int link_count, total_link_count;
667 670 /* ipc stuff */