Eric Lee / linux-smarc-t335x-v3.2

Download as
Browse Code ยป

Commit 372b2312010bece1e36f577d6c99a6193ec54cbd

Authored by Eric Dumazet
Committed by David S. Miller
1 parent 6f404e441d
Exists in master and in 4 other branches v3.2_AM335xPSP_04.06.00.11, v3.2_NEWT335xPSP_04.06.00.11, v3.2_SBC_SMARTMEN, v3.2_SMARCT335xPSP_04.06.00.11

net: use hlist_del_rcu() in dev_change_name() 

Using plain hlist_del() in dev_change_name() is wrong since a
concurrent reader can crash trying to dereference LIST_POISON1.

Bug introduced in commit 72c9528bab94 (net: Introduce
dev_get_by_name_rcu())

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff

... ... @@ -1007,7 +1007,7 @@
1007 1007 }
1008 1008  
1009 1009 write_lock_bh(&dev_base_lock);
1010   - hlist_del(&dev->name_hlist);
  1010 + hlist_del_rcu(&dev->name_hlist);
1011 1011 write_unlock_bh(&dev_base_lock);
1012 1012  
1013 1013 synchronize_rcu();