Commit 3943ac5d99ec024f97442e5f3def1034bb0b1bb0
Committed by
David S. Miller
1 parent
9ba30d7444
Exists in
master
and in
4 other branches
Doc: Fix wrong API example usage of call_rcu().
At some point the API of call_rcu() changed from three parameters to two parameters, correct the documentation. One confusing thing in RCU/listRCU.txt, which is NOT fixed in this patch, is that no reason or explaination is given for using call_rcu() instead of the normal synchronize_rcu() call. Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Jesper Dangaard Brouer <hawk@comx.dk> Signed-off-by: David S. Miller <davem@davemloft.net>
Showing 1 changed file with 3 additions and 3 deletions Side-by-side Diff
Documentation/RCU/listRCU.txt
... | ... | @@ -118,7 +118,7 @@ |
118 | 118 | list_for_each_entry(e, list, list) { |
119 | 119 | if (!audit_compare_rule(rule, &e->rule)) { |
120 | 120 | list_del_rcu(&e->list); |
121 | - call_rcu(&e->rcu, audit_free_rule, e); | |
121 | + call_rcu(&e->rcu, audit_free_rule); | |
122 | 122 | return 0; |
123 | 123 | } |
124 | 124 | } |
... | ... | @@ -206,7 +206,7 @@ |
206 | 206 | ne->rule.action = newaction; |
207 | 207 | ne->rule.file_count = newfield_count; |
208 | 208 | list_replace_rcu(e, ne); |
209 | - call_rcu(&e->rcu, audit_free_rule, e); | |
209 | + call_rcu(&e->rcu, audit_free_rule); | |
210 | 210 | return 0; |
211 | 211 | } |
212 | 212 | } |
... | ... | @@ -283,7 +283,7 @@ |
283 | 283 | list_del_rcu(&e->list); |
284 | 284 | e->deleted = 1; |
285 | 285 | spin_unlock(&e->lock); |
286 | - call_rcu(&e->rcu, audit_free_rule, e); | |
286 | + call_rcu(&e->rcu, audit_free_rule); | |
287 | 287 | return 0; |
288 | 288 | } |
289 | 289 | } |