Eric Lee / linux-smarc-t335x-v3.2

Download as
Browse Code ยป

Commit 3deee42088ddcf5b23021aa089b53444797e565d

Authored by Joe Eykholt
Committed by James Bottomley
1 parent 081f4f4c1a
Exists in master and in 4 other branches v3.2_AM335xPSP_04.06.00.11, v3.2_NEWT335xPSP_04.06.00.11, v3.2_SBC_SMARTMEN, v3.2_SMARCT335xPSP_04.06.00.11

[SCSI] tgt: fix warning 

Using scsi_tgt_lib in a new target module, we were getting
the following warning and a stack traceback on every I/O completion:

WARNING: at block/blk-core.c:1108

Which is claiming we may be leaking a bio.
We don't leak bios (blk_rq_unmap_user should free them).

Set rq->bio to NULL before calling scsi_host_put_command().
This was as advised by Fujita Tomonori.

Signed-off-by: Joe Eykholt <jeykholt@cisco.com>
Acked-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>

Showing 1 changed file with 1 additions and 0 deletions Side-by-side Diff

drivers/scsi/scsi_tgt_lib.c
Diff comments   View file @ 3deee42
... ... @@ -185,6 +185,7 @@
185 185 dprintk("cmd %p %d %u\n", cmd, cmd->sc_data_direction,
186 186 rq_data_dir(cmd->request));
187 187 scsi_unmap_user_pages(tcmd);
  188 + tcmd->rq->bio = NULL;
188 189 scsi_host_put_command(scsi_tgt_cmd_to_host(cmd), cmd);
189 190 }
190 191