Eric Lee / linux-smarc-t335x-v3.2

Commit 4bbd61fb9726808e72ab2aa440401f6e5e1aa8f7

Authored by Christian Gmeiner 2011-06-16 06:08:22 +0800

Committed by Linus Torvalds 2011-06-16 11:04:00 +0800

Exists in master and in 4 other branches

drivers/misc/cs5535-mfgpt.c: fix wrong if condition

Fix the wrong `if' condition for the check if the requested timer is
available.

The bitmap avail is used to store if a timer is used already.  test_bit()
is used to check if the requested timer is available.  If a bit in the
avail bitmap is set it means that the timer is available.

The runtime effect would be that allocating a specific timer always fails
(versus telling cs5535_mfgpt_alloc_timer to allocate the first available
timer, which works).

Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
Acked-by: Andres Salomon <dilinger@queued.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff

drivers/misc/cs5535-mfgpt.c

drivers/misc/cs5535-mfgpt.c

Diff comments View file @ 4bbd61f

...	...	@@ -174,7 +174,7 @@
174	174	timer_nr = t < max ? (int) t : -1;
175	175	} else {
176	176	/* check if the requested timer's available */
177		- if (test_bit(timer_nr, mfgpt->avail))
	177	+ if (!test_bit(timer_nr, mfgpt->avail))
178	178	timer_nr = -1;
179	179	}
180	180