Eric Lee / linux-smarc-t335x-v3.2

Download as
Browse Code ยป

Commit 5729c63a51f0f8a351e0f1dc7b3250ebac12c309

Authored by MyungJoo Ham
Committed by Rafael J. Wysocki
1 parent 8cfe400ca5
Exists in master and in 4 other branches v3.2_AM335xPSP_04.06.00.11, v3.2_NEWT335xPSP_04.06.00.11, v3.2_SBC_SMARTMEN, v3.2_SMARCT335xPSP_04.06.00.11

PM / Hibernate: hibernation_ops->leave should be checked too 

Because hibernate calls hibernation_ops->leave() without checking
whether hibernation_ops->leave is NULL or not, hiberantion_set_ops
should WARN_ON if hibernation_ops->leave is NULL.

This patch added one more condition to check hibernation_ops->leave.

Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>

Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff

kernel/power/hibernate.c
Diff comments   View file @ 5729c63
... ... @@ -62,7 +62,7 @@
62 62 {
63 63 if (ops && !(ops->begin && ops->end && ops->pre_snapshot
64 64 && ops->prepare && ops->finish && ops->enter && ops->pre_restore
65   - && ops->restore_cleanup)) {
  65 + && ops->restore_cleanup && ops->leave)) {
66 66 WARN_ON(1);
67 67 return;
68 68 }