Commit 59247eaea50cc68cc6ce3d3fd3855f3301b65c96
1 parent
a3941ec101
Exists in
master
and in
4 other branches
block: fix missing bio back/front segment size setting in blk_recount_segments()
Commit 1e42807918d17e8c93bf14fbb74be84b141334c1 introduced a bug where we don't get front/back segment sizes in the bio in blk_recount_segments(). Fix this by tracking the back bio as well as the front bio in __blk_recalc_rq_segments(), this also cleans up the interface by getting rid of the segment size pointer passing. Tested-by: Thomas Gleixner <tglx@linutronix.de> Tested-by: Ingo Molnar <mingo@elte.hu> Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
Showing 1 changed file with 9 additions and 16 deletions Side-by-side Diff
block/blk-merge.c
| ... | ... | @@ -39,14 +39,13 @@ |
| 39 | 39 | } |
| 40 | 40 | |
| 41 | 41 | static unsigned int __blk_recalc_rq_segments(struct request_queue *q, |
| 42 | - struct bio *bio, | |
| 43 | - unsigned int *seg_size_ptr) | |
| 42 | + struct bio *bio) | |
| 44 | 43 | { |
| 45 | 44 | unsigned int phys_size; |
| 46 | 45 | struct bio_vec *bv, *bvprv = NULL; |
| 47 | 46 | int cluster, i, high, highprv = 1; |
| 48 | 47 | unsigned int seg_size, nr_phys_segs; |
| 49 | - struct bio *fbio; | |
| 48 | + struct bio *fbio, *bbio; | |
| 50 | 49 | |
| 51 | 50 | if (!bio) |
| 52 | 51 | return 0; |
| 53 | 52 | |
| 54 | 53 | |
| ... | ... | @@ -87,26 +86,20 @@ |
| 87 | 86 | seg_size = bv->bv_len; |
| 88 | 87 | highprv = high; |
| 89 | 88 | } |
| 89 | + bbio = bio; | |
| 90 | 90 | } |
| 91 | 91 | |
| 92 | - if (seg_size_ptr) | |
| 93 | - *seg_size_ptr = seg_size; | |
| 92 | + if (nr_phys_segs == 1 && seg_size > fbio->bi_seg_front_size) | |
| 93 | + fbio->bi_seg_front_size = seg_size; | |
| 94 | + if (seg_size > bbio->bi_seg_back_size) | |
| 95 | + bbio->bi_seg_back_size = seg_size; | |
| 94 | 96 | |
| 95 | 97 | return nr_phys_segs; |
| 96 | 98 | } |
| 97 | 99 | |
| 98 | 100 | void blk_recalc_rq_segments(struct request *rq) |
| 99 | 101 | { |
| 100 | - unsigned int seg_size = 0, phys_segs; | |
| 101 | - | |
| 102 | - phys_segs = __blk_recalc_rq_segments(rq->q, rq->bio, &seg_size); | |
| 103 | - | |
| 104 | - if (phys_segs == 1 && seg_size > rq->bio->bi_seg_front_size) | |
| 105 | - rq->bio->bi_seg_front_size = seg_size; | |
| 106 | - if (seg_size > rq->biotail->bi_seg_back_size) | |
| 107 | - rq->biotail->bi_seg_back_size = seg_size; | |
| 108 | - | |
| 109 | - rq->nr_phys_segments = phys_segs; | |
| 102 | + rq->nr_phys_segments = __blk_recalc_rq_segments(rq->q, rq->bio); | |
| 110 | 103 | } |
| 111 | 104 | |
| 112 | 105 | void blk_recount_segments(struct request_queue *q, struct bio *bio) |
| ... | ... | @@ -114,7 +107,7 @@ |
| 114 | 107 | struct bio *nxt = bio->bi_next; |
| 115 | 108 | |
| 116 | 109 | bio->bi_next = NULL; |
| 117 | - bio->bi_phys_segments = __blk_recalc_rq_segments(q, bio, NULL); | |
| 110 | + bio->bi_phys_segments = __blk_recalc_rq_segments(q, bio); | |
| 118 | 111 | bio->bi_next = nxt; |
| 119 | 112 | bio->bi_flags |= (1 << BIO_SEG_VALID); |
| 120 | 113 | } |