Eric Lee / linux-smarc-t335x-v3.2

Download as
Browse Code ยป

Commit 64e0cc38b69b8d43ab9793f50e4bb09cea0e6bb9

Authored by Linas Vepstas
Committed by Linus Torvalds
1 parent 229395c90a
Exists in master and in 4 other branches v3.2_AM335xPSP_04.06.00.11, v3.2_NEWT335xPSP_04.06.00.11, v3.2_SBC_SMARTMEN, v3.2_SMARCT335xPSP_04.06.00.11

[PATCH] pSeries: hvsi char driver janitorial cleanup 

A set of tty line discipline cleanup patches were introduced before the
dawn of time, in kernel version 2.4.21.  This patch performs that cleanup
for the hvsi driver.

The hvsi driver is used only on IBM pSeries PowerPC boxes.  The driver was
originally written by Hollis Blanchard, who has delegated maintainership to
me.  So this my first and maybe only patch in this official new role,
because this driver is otherwise bug-free :-)

Alan: "Actually its also a bug fix, tty->ldisc should be locked by refcounting
and the helpers do this for you."

Signed-off-by: Linas Vepstas <linas@austin.ibm.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>
Acked-by: Alan Cox <alan@redhat.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

Showing 1 changed file with 1 additions and 4 deletions Side-by-side Diff

... ... @@ -987,10 +987,7 @@
987 987 start_j = 0;
988 988 #endif /* DEBUG */
989 989 wake_up_all(&hp->emptyq);
990   - if (test_bit(TTY_DO_WRITE_WAKEUP, &hp->tty->flags)
991   - && hp->tty->ldisc.write_wakeup)
992   - hp->tty->ldisc.write_wakeup(hp->tty);
993   - wake_up_interruptible(&hp->tty->write_wait);
  990 + tty_wakeup(hp->tty);
994 991 }
995 992  
996 993 out: