Eric Lee / linux-smarc-t335x-v3.2

Download as
Browse Code ยป

Commit 719f2c879f4dda7d7f303bd387d37cd96db29d31

Authored by Artem Bityutskiy
Committed by Al Viro
1 parent 315671f3b8
Exists in master and in 4 other branches v3.2_AM335xPSP_04.06.00.11, v3.2_NEWT335xPSP_04.06.00.11, v3.2_SBC_SMARTMEN, v3.2_SMARCT335xPSP_04.06.00.11

sysv: do not mark superblock dirty on remount 

No need to mark the superblock as dirty in sysv_remount, synchronize
it instead (only if mounting R/O).

I did not find any docs about this file-system, and I have no possibility
to test my changes. Thus, this is untested. I see other issues in sysv,
e.g., why sysv_sync_fs writes only in the FSTYPE_SYSV4 case? However,
it marks its SB bh's dirty for all types, and does not wait for them
ever. With zero docs I'm unable to fix this.

Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

Showing 1 changed file with 2 additions and 2 deletions Side-by-side Diff

... ... @@ -71,8 +71,8 @@
71 71 lock_super(sb);
72 72 if (sbi->s_forced_ro)
73 73 *flags |= MS_RDONLY;
74   - if (!(*flags & MS_RDONLY))
75   - sb->s_dirt = 1;
  74 + if (*flags & MS_RDONLY)
  75 + sysv_write_super(sb);
76 76 unlock_super(sb);
77 77 return 0;
78 78 }