Commit 72f279b256d520e321a850880d094bc0bcbf45d6
Committed by
Ingo Molnar
1 parent
964fe080d9
Exists in
master
and in
4 other branches
generic-ipi: Fix misleading smp_call_function*() description
After commit:8969a5ede0f9e17da4b943712429aef2c9bcd82b "generic-ipi: remove kmalloc()", wait = 0 can be guaranteed. Signed-off-by: Sheng Yang <sheng@linux.intel.com> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Jens Axboe <jens.axboe@oracle.com> Cc: Nick Piggin <npiggin@suse.de> LKML-Reference: <1256210374-25354-1-git-send-email-sheng@linux.intel.com> Signed-off-by: Ingo Molnar <mingo@elte.hu>
Showing 1 changed file with 3 additions and 8 deletions Side-by-side Diff
kernel/smp.c
... | ... | @@ -265,9 +265,7 @@ |
265 | 265 | * @info: An arbitrary pointer to pass to the function. |
266 | 266 | * @wait: If true, wait until function has completed on other CPUs. |
267 | 267 | * |
268 | - * Returns 0 on success, else a negative status code. Note that @wait | |
269 | - * will be implicitly turned on in case of allocation failures, since | |
270 | - * we fall back to on-stack allocation. | |
268 | + * Returns 0 on success, else a negative status code. | |
271 | 269 | */ |
272 | 270 | int smp_call_function_single(int cpu, void (*func) (void *info), void *info, |
273 | 271 | int wait) |
... | ... | @@ -355,9 +353,7 @@ |
355 | 353 | * @wait: If true, wait (atomically) until function has completed |
356 | 354 | * on other CPUs. |
357 | 355 | * |
358 | - * If @wait is true, then returns once @func has returned. Note that @wait | |
359 | - * will be implicitly turned on in case of allocation failures, since | |
360 | - * we fall back to on-stack allocation. | |
356 | + * If @wait is true, then returns once @func has returned. | |
361 | 357 | * |
362 | 358 | * You must not call this function with disabled interrupts or from a |
363 | 359 | * hardware interrupt handler or from a bottom half handler. Preemption |
... | ... | @@ -443,8 +439,7 @@ |
443 | 439 | * Returns 0. |
444 | 440 | * |
445 | 441 | * If @wait is true, then returns once @func has returned; otherwise |
446 | - * it returns just before the target cpu calls @func. In case of allocation | |
447 | - * failure, @wait will be implicitly turned on. | |
442 | + * it returns just before the target cpu calls @func. | |
448 | 443 | * |
449 | 444 | * You must not call this function with disabled interrupts or from a |
450 | 445 | * hardware interrupt handler or from a bottom half handler. |