Eric Lee / linux-smarc-t335x-v3.2

Download as
Browse Code ยป

Commit 7522a8423bed9931cbac5502b9c0657bde2700ea

Authored by Ananth N Mavinakayanahalli
Committed by Linus Torvalds
1 parent 5a7b46b369
Exists in master and in 4 other branches v3.2_AM335xPSP_04.06.00.11, v3.2_NEWT335xPSP_04.06.00.11, v3.2_SBC_SMARTMEN, v3.2_SMARCT335xPSP_04.06.00.11

[PATCH] kprobes: NULL out non-relevant fields in struct kretprobe 

In cases where a struct kretprobe's *_handler fields are non-NULL, it is
possible to cause a system crash, due to the possibility of calls ending up
in zombie functions.  Documentation clearly states that unused *_handlers
should be set to NULL, but kprobe users sometimes fail to do so.

Fix it by setting the non-relevant fields of the struct kretprobe to NULL.

Signed-off-by: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Acked-by: Jim Keniston <jkenisto@us.ibm.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

Showing 1 changed file with 3 additions and 0 deletions Side-by-side Diff

... ... @@ -585,6 +585,9 @@
585 585 int i;
586 586  
587 587 rp->kp.pre_handler = pre_handler_kretprobe;
  588 + rp->kp.post_handler = NULL;
  589 + rp->kp.fault_handler = NULL;
  590 + rp->kp.break_handler = NULL;
588 591  
589 592 /* Pre-allocate memory for max kretprobe instances */
590 593 if (rp->maxactive <= 0) {