Eric Lee / linux-smarc-t335x-v3.2

Download as
Browse Code ยป

Commit 7b8aca65db5dd1aaa6dc1e11f6bfcc0ecd6bc8a4

Authored by Lee, Chun-Yi
Committed by Matthew Garrett
1 parent de96355c11
Exists in master and in 4 other branches v3.2_AM335xPSP_04.06.00.11, v3.2_NEWT335xPSP_04.06.00.11, v3.2_SBC_SMARTMEN, v3.2_SMARCT335xPSP_04.06.00.11

acer-wmi: schedule threeg and interface sysfs for feature removal 

we can now autodetect internal 3G device and already have the threeg
rfkill device. So, we plan to remove threeg sysfs support for it's no
longer necessary.

We also plan to remove interface sysfs file that exposed which ACPI-WMI
interface that was used by acer-wmi driver. It will replaced by information
log when acer-wmi initial.

We keep it around for userspace compatibility reasons, schedule removal
in 2012.

Cc: Carlos Corbacho <carlos@strangeworlds.co.uk>
Cc: Matthew Garrett <mjg@redhat.com>
Cc: Dmitry Torokhov <dtor@mail.ru>
Cc: Corentin Chary <corentincj@iksaif.net>
Acked-by: Thomas Renninger <trenn@suse.de>
Signed-off-by: Lee, Chun-Yi <jlee@novell.com>
Signed-off-by: Matthew Garrett <mjg@redhat.com>

Showing 2 changed files with 20 additions and 2 deletions Side-by-side Diff

Documentation/feature-removal-schedule.txt
Diff comments   View file @ 7b8aca6
... ... @@ -581,4 +581,15 @@
581 581 Who: Alan Stern <stern@rowland.harvard.edu>
582 582  
583 583 ----------------------------
  584 +
  585 +What: threeg and interface sysfs files in /sys/devices/platform/acer-wmi
  586 +When: 2012
  587 +Why: In 3.0, we can now autodetect internal 3G device and already have
  588 + the threeg rfkill device. So, we plan to remove threeg sysfs support
  589 + for it's no longer necessary.
  590 +
  591 + We also plan to remove interface sysfs file that exposed which ACPI-WMI
  592 + interface that was used by acer-wmi driver. It will replaced by
  593 + information log when acer-wmi initial.
  594 +Who: Lee, Chun-Yi <jlee@novell.com>
drivers/platform/x86/acer-wmi.c
Diff comments   View file @ 7b8aca6
... ... @@ -1400,6 +1400,9 @@
1400 1400 {
1401 1401 u32 result; \
1402 1402 acpi_status status;
  1403 +
  1404 + pr_info("This threeg sysfs will be removed in 2012"
  1405 + " - used by: %s\n", current->comm);
1403 1406 if (wmi_has_guid(WMID_GUID3))
1404 1407 status = wmid3_get_device_status(&result,
1405 1408 ACER_WMID3_GDS_THREEG);
... ... @@ -1415,8 +1418,10 @@
1415 1418 {
1416 1419 u32 tmp = simple_strtoul(buf, NULL, 10);
1417 1420 acpi_status status = set_u32(tmp, ACER_CAP_THREEG);
1418   - if (ACPI_FAILURE(status))
1419   - return -EINVAL;
  1421 + pr_info("This threeg sysfs will be removed in 2012"
  1422 + " - used by: %s\n", current->comm);
  1423 + if (ACPI_FAILURE(status))
  1424 + return -EINVAL;
1420 1425 return count;
1421 1426 }
1422 1427 static DEVICE_ATTR(threeg, S_IRUGO | S_IWUSR, show_bool_threeg,
... ... @@ -1425,6 +1430,8 @@
1425 1430 static ssize_t show_interface(struct device *dev, struct device_attribute *attr,
1426 1431 char *buf)
1427 1432 {
  1433 + pr_info("This interface sysfs will be removed in 2012"
  1434 + " - used by: %s\n", current->comm);
1428 1435 switch (interface->type) {
1429 1436 case ACER_AMW0:
1430 1437 return sprintf(buf, "AMW0\n");