Commit 7fa53cc872332b265bc5ba1266f39586f218ad4a

Authored by J. Bruce Fields
1 parent e844a7b980

nfsd: don't allow setting maxblksize after svc created

It's harmless to set this after the server is created, but also
ineffective, since the value is only used at the time of
svc_create_pooled().  So fail the attempt, in keeping with the pattern
set by write_versions, write_{lease,grace}time and write_recoverydir.

(This could break userspace that tried to write to nfsd/max_block_size
between setting up sockets and starting the server.  However, such code
wouldn't have worked anyway, and I don't know of any examples--rpc.nfsd
in nfs-utils, probably the only user of the interface, doesn't do that.)

Signed-off-by: J. Bruce Fields <bfields@redhat.com>

Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff

... ... @@ -1190,7 +1190,7 @@
1190 1190 bsize = NFSSVC_MAXBLKSIZE;
1191 1191 bsize &= ~(1024-1);
1192 1192 mutex_lock(&nfsd_mutex);
1193   - if (nfsd_serv && nfsd_serv->sv_nrthreads) {
  1193 + if (nfsd_serv) {
1194 1194 mutex_unlock(&nfsd_mutex);
1195 1195 return -EBUSY;
1196 1196 }