lmLogOpen() broken failure exit

Callers of lmLogOpen() expect it to return -E... on failure exits, which is what it returns, except for the case of blkdev_get_by_dev() failure. It that case lmLogOpen() return the error with the wrong sign... Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> Acked-by: Dave Kleikamp <dave.kleikamp@oracle.com>

lmLogOpen() broken failure exit
Callers of lmLogOpen() expect it to return -E... on failure exits, which is what it returns, except for the case of blkdev_get_by_dev() failure. It that case lmLogOpen() return the error with the wrong sign... Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> Acked-by: Dave Kleikamp <dave.kleikamp@oracle.com>
Al Viro · Al Viro
1 parent 3ece48a746
Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff
fs/jfs/jfs_logmgr.c
@@ -1123,7 +1123,7 @@
 	bdev = blkdev_get_by_dev(sbi->logdev, FMODE_READ|FMODE_WRITE|FMODE_EXCL,
 				 log);
 	if (IS_ERR(bdev)) {
-		rc = -PTR_ERR(bdev);
+		rc = PTR_ERR(bdev);
 		goto free;
 	}
...	...	@@ -1123,7 +1123,7 @@
1123	1123	bdev = blkdev_get_by_dev(sbi->logdev, FMODE_READ\|FMODE_WRITE\|FMODE_EXCL,
1124	1124	log);
1125	1125	if (IS_ERR(bdev)) {
1126		- rc = -PTR_ERR(bdev);
	1126	+ rc = PTR_ERR(bdev);
1127	1127	goto free;
1128	1128	}
1129	1129