Eric Lee / linux-smarc-t335x-v3.2

Download as
Browse Code ยป

Commit 96050dfb25966612008dcea7d342e91fa01e993c

Authored by Peter Botha
Committed by Linus Torvalds
1 parent a61d90d75d
Exists in master and in 4 other branches v3.2_AM335xPSP_04.06.00.11, v3.2_NEWT335xPSP_04.06.00.11, v3.2_SBC_SMARTMEN, v3.2_SMARCT335xPSP_04.06.00.11

char: mxser, fix ISA board lookup 

There's a bug in the mxser kernel module that still appears in the
2.6.29.4 kernel.

mxser_get_ISA_conf takes a ioaddress as its first argument, by passing the
not of the ioaddr, you're effectively passing 0 which means it won't be
able to talk to an ISA card.  I have tested this, and removing the !
fixes the problem.

Cc: "Peter Botha" <peterb@goldcircle.co.za>
Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Acked-by: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff

drivers/char/mxser.c
Diff comments   View file @ 96050df
... ... @@ -2711,7 +2711,7 @@
2711 2711 continue;
2712 2712  
2713 2713 brd = &mxser_boards[m];
2714   - retval = mxser_get_ISA_conf(!ioaddr[b], brd);
  2714 + retval = mxser_get_ISA_conf(ioaddr[b], brd);
2715 2715 if (retval <= 0) {
2716 2716 brd->info = NULL;
2717 2717 continue;