Commit a2f20c7c274b6241767330c902b3111b9326d901
Committed by
Linus Torvalds
1 parent
969dd061d8
Exists in
master
and in
4 other branches
[PATCH] Clean up char/esp.c
coverity choked at another two !tty checks, in places where tty can never be NULL. Since it removes some code we should remove these checks. (Coverity ids #763,#762) Signed-off-by Eric Sesterhenn <snakebyte@gmx.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Showing 1 changed file with 2 additions and 2 deletions Side-by-side Diff
drivers/char/esp.c
| ... | ... | @@ -1212,7 +1212,7 @@ |
| 1212 | 1212 | if (serial_paranoia_check(info, tty->name, "rs_put_char")) |
| 1213 | 1213 | return; |
| 1214 | 1214 | |
| 1215 | - if (!tty || !info->xmit_buf) | |
| 1215 | + if (!info->xmit_buf) | |
| 1216 | 1216 | return; |
| 1217 | 1217 | |
| 1218 | 1218 | spin_lock_irqsave(&info->lock, flags); |
| ... | ... | @@ -1256,7 +1256,7 @@ |
| 1256 | 1256 | if (serial_paranoia_check(info, tty->name, "rs_write")) |
| 1257 | 1257 | return 0; |
| 1258 | 1258 | |
| 1259 | - if (!tty || !info->xmit_buf) | |
| 1259 | + if (!info->xmit_buf) | |
| 1260 | 1260 | return 0; |
| 1261 | 1261 | |
| 1262 | 1262 | while (1) { |